[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency accross service .. Patch Set 4: (10 comments) http://gerrit.cloudera.org:8080/#/c/4349/4/fe/src/main/java/org/apache/im

[Impala-ASF-CR] Revert org.apache.impala.hive.serde.ParquetOutputFormat

2016-10-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Revert org.apache.impala.hive.serde.ParquetOutputFormat .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4611 To unsubscribe, vis

[Impala-ASF-CR] Revert org.apache.impala.hive.serde.ParquetOutputFormat

2016-10-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Revert org.apache.impala.hive.serde.ParquetOutputFormat .. Revert org.apache.impala.hive.serde.ParquetOutputFormat The patch for IMPALA-3786 replaced

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency accross service .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4349/3/fe/src/main/java/org/apache/imp

[Impala-ASF-CR] IMPALA-4204: Remove KuduScanNodeTest

2016-10-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4204: Remove KuduScanNodeTest .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4609 To unsubscribe, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-889: Add support for an ISO-SQL compliant trim() function.

2016-10-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-889: Add support for an ISO-SQL compliant trim() function. .. Patch Set 6: (32 comments) http://gerrit.cloudera.org:8080/#/c/4474/1//COMMIT_MSG Commit Messa

[Impala-ASF-CR] IMPALA-4213: Planner not pushing some Kudu predicates

2016-10-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4213: Planner not pushing some Kudu predicates .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4613/1/fe/src/main/java/org/apache/impala/anal

[Impala-ASF-CR] IMPALA-4234: Remove astyle config file, looks outdated.

2016-10-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4234: Remove astyle config file, looks outdated. .. IMPALA-4234: Remove astyle config file, looks outdated. Change-Id: Ibdeba67fcfa538a49d335d

[Impala-ASF-CR] IMPALA-4234: Remove astyle config file, looks outdated.

2016-10-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4234: Remove astyle config file, looks outdated. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4578 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-03 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency accross service .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4349/4/fe/src/main/java/org/apache/impa

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-03 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency accross service .. Patch Set 4: (17 comments) http://gerrit.cloudera.org:8080/#/c/4349/3//COMMIT_MSG Commit Message: P

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-03 Thread Huaisi Xu (Code Review)
Huaisi Xu has uploaded a new patch set (#4). Change subject: IMPALA-1702: Enforce table level consistency accross service .. IMPALA-1702: Enforce table level consistency accross service Problems: 1. CatalogServiceCatalog::reset(

[Impala-ASF-CR] Add vim-specific files to .gitignore

2016-10-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add vim-specific files to .gitignore .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4562 To unsubscribe, visit http://gerrit.cl

[Impala-ASF-CR] Add vim-specific files to .gitignore

2016-10-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add vim-specific files to .gitignore .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4562/1/.gitignore File .gitignore: Line 1: *~ > I think th

[Impala-ASF-CR] IMPALA-4213: Planner not pushing some Kudu predicates

2016-10-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/4613 Change subject: IMPALA-4213: Planner not pushing some Kudu predicates .. IMPALA-4213: Planner not pushing some Kudu predicates Folding

[Impala-ASF-CR] Revert org.apache.impala.hive.serde.ParquetOutputFormat

2016-10-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Revert org.apache.impala.hive.serde.ParquetOutputFormat .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4611 To unsubscribe, visit h

[Impala-ASF-CR] Revert org.apache.impala.hive.serde.ParquetOutputFormat

2016-10-03 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/4611 Change subject: Revert org.apache.impala.hive.serde.ParquetOutputFormat .. Revert org.apache.impala.hive.serde.ParquetOutputForm

[Impala-ASF-CR] IMPALA-4239: fix buffer pool test failures in release build

2016-10-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4239: fix buffer pool test failures in release build .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4596 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-4042: count(distinct NULL) fails on a view

2016-10-03 Thread Anonymous Coward (Code Review)
Anonymous Coward #216 has posted comments on this change. Change subject: IMPALA-4042: count(distinct NULL) fails on a view .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4600/2/fe/src/main/java/org/apache/imp

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 2: (34 comments) First pass, didn't get to all of it yet but I thought you might want to see what was done http://ger

[Impala-ASF-CR] IMPALA-4239: fix buffer pool test failures in release build

2016-10-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4239: fix buffer pool test failures in release build .. IMPALA-4239: fix buffer pool test failures in release build Gtest's ASSERT_DEBUG_DEATH macro has pec

[Impala-ASF-CR] IMPALA-4239: fix buffer pool test failures in release build

2016-10-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4239: fix buffer pool test failures in release build .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4596/1/be/src/testutil/death-test-ut

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These support reading

[Impala-ASF-CR] IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-10-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. Patch Set 5: Code-Review+1 Rebase -- To view, visit http://gerrit.cloudera.org:8080/3843 To u

[Impala-ASF-CR] IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-10-03 Thread Tim Armstrong (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3843 to look at the new patch set (#5). Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. I

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 2: > > I'm not sure I understand why a person might want to run the > inferencer again, even if th

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 2: > I'm not sure I understand why a person might want to run the inferencer > again, even if

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 2: > Do you understand the relationship between the resulting > .clang-format file and the changes

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2016-10-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3504: UDF for current timestamp in UTC .. Patch Set 8: Code-Review+1 Carrying the previous +1 so it can be reviewed for a +2. -- To view, visit http://

[Impala-ASF-CR] IMPALA-4204: Remove KuduScanNodeTest

2016-10-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-4204: Remove KuduScanNodeTest .. IMPALA-4204: Remove KuduScanNodeTest In IMPALA-4204, the limit test could fail depending on the timing of the scanner thre

[Impala-ASF-CR] IMPALA-4216: Test became flaky: TestTpchMemLimitError.test low mem limit q20

2016-10-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4216: Test became flaky: TestTpchMemLimitError.test_low_mem_limit_q20 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/45

[Impala-ASF-CR] IMPALA-4204: Remove KuduScanNodeTest

2016-10-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/4609 Change subject: IMPALA-4204: Remove KuduScanNodeTest .. IMPALA-4204: Remove KuduScanNodeTest In IMPALA-4204, the limit test could fail

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-10-03 Thread Tim Armstrong (Code Review)
Hello Internal Jenkins, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4448 to look at the new patch set (#6). Change subject: IMPALA-4023: don't attach buffered tuple streams to batches ...

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 2: Do you understand the relationship between the resulting .clang-format file and the change

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-10-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 5: I ran into some problems with spilling_test, where it does run with the read_size <

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-10-03 Thread Tim Armstrong (Code Review)
Hello Internal Jenkins, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4448 to look at the new patch set (#5). Change subject: IMPALA-4023: don't attach buffered tuple streams to batches ...

[Impala-ASF-CR] IMPALA-4234: Remove astyle config file, looks outdated.

2016-10-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4234: Remove astyle config file, looks outdated. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4578 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-4216: Test became flaky: TestTpchMemLimitError.test low mem limit q20

2016-10-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4216: Test became flaky: TestTpchMemLimitError.test_low_mem_limit_q20 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4572 T

[Impala-ASF-CR] IMPALA-4239: fix buffer pool test failures in release build

2016-10-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4239: fix buffer pool test failures in release build .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4596/1/be/src/testutil/death-test-util.h

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-10-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 5: (3 comments) This looks good to me. One last thing: we should thi

[Impala-ASF-CR] IMPALA-4042: count(distinct NULL) fails on a view

2016-10-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4042: count(distinct NULL) fails on a view .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4600/2/fe/src/main/java/org/apache/impala/analysis

[Impala-ASF-CR] IMPALA-4042: count(distinct NULL) fails on a view

2016-10-03 Thread Anonymous Coward (Code Review)
Anonymous Coward #216 has posted comments on this change. Change subject: IMPALA-4042: count(distinct NULL) fails on a view .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4600/2/fe/src/main/java/org/apache/imp

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency accross service .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/4349/3//COMMIT_MSG Commit M

[Impala-ASF-CR] IMPALA-4042: count(distinct NULL) fails on a view

2016-10-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4042: count(distinct NULL) fails on a view .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4600/2/fe/src/main/java/org/apache/impala/analysis

[Impala-ASF-CR] IMPALA-4042: count(distinct NULL) fails on a view

2016-10-03 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has uploaded a new patch set (#2). Change subject: IMPALA-4042: count(distinct NULL) fails on a view .. IMPALA-4042: count(distinct NULL) fails on a view In case of count(distinct), FunctionCallExpr.analyze() chan

[Impala-ASF-CR] IMPALA-4042: count(distinct NULL) fails on a view

2016-10-03 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has uploaded a new change for review. http://gerrit.cloudera.org:8080/4600 Change subject: IMPALA-4042: count(distinct NULL) fails on a view .. IMPALA-4042: count(distinct NULL) fails on a view In case of count

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-10-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/3937/7/fe/src/test/java/org/apache/impala/cat

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-10-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/3937/7/fe/src/test/java/org/apache/impala/cat

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-10-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/3937/7/fe/src/test/java/org/apache/impala/cat

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-10-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/3937/7/fe/src/test/java/org/apache/impala/cat

[Impala-ASF-CR] IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node.

2016-10-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node. .. Patch Set 1: Code-Review+1 I found this bug while experimenting with a different tu

[Impala-ASF-CR] IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node.

2016-10-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node. .. Patch Set 1: Code-Review+1 Wow, nice catch. How'd you find this? The good news

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4590 To unsubscribe, visit

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4590/1/.clang-format File .clang-format: Line

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-03 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: Match .clang-format more closely to actual practice. .. Match .clang-format more closely to actual practice. In order to attempt to get code like double VeryLongF

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-10-03 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 5: The patch passed an exhaustive run on Jenkins: http://sandbo

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4590/1/.clang-format File .clang-format:

[Impala-ASF-CR] Don't assume that AUX exists just because a shell variable is set

2016-10-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Don't assume that AUX exists just because a shell variable is set .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4563/2/tests/run-custom-cluster-t

[Impala-ASF-CR] Don't assume that AUX exists just because a shell variable is set

2016-10-03 Thread Jim Apple (Code Review)
Hello Michael Brown, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4563 to look at the new patch set (#3). Change subject: Don't assume that AUX exists just because a shell variable is set ..

[Impala-ASF-CR] IMPALA-4239: fix buffer pool test failures in release build

2016-10-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4596 Change subject: IMPALA-4239: fix buffer pool test failures in release build .. IMPALA-4239: fix buffer pool test failures in release buil

[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.

2016-10-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3. .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4582/1//COMMIT_MSG Commit Message: PS1, Line 12: Pl

[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.

2016-10-03 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#3). Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3. .. IMPALA-4230: ASF policy issues from 2.7.0 rc3. In our IPMC vote to release 2.7.0 rc3, Justing Mclean pointed out a nu