[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to clients

2016-10-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4335: Don't send 0-row batches to clients .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4787 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to clients

2016-10-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4335: Don't send 0-row batches to clients .. IMPALA-4335: Don't send 0-row batches to clients This patch restores some behaviour from

[Impala-ASF-CR] IMPALA-4285/IMPALA-4286: Fixes for Parquet scanner with MT DOP > 0.

2016-10-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4285/IMPALA-4286: Fixes for Parquet scanner with MT_DOP > 0. .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4767 To

[Impala-ASF-CR] IMPALA-3884: Support TYPE TIMESTAMP for HashTableCtx::CodegenAssignNullValue()

2016-10-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3884: Support TYPE_TIMESTAMP for HashTableCtx::CodegenAssignNullValue() .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-4295: XFAIL wildcard SSL test

2016-10-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4295: XFAIL wildcard SSL test .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4784 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4295: XFAIL wildcard SSL test

2016-10-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4295: XFAIL wildcard SSL test .. IMPALA-4295: XFAIL wildcard SSL test commit 9f61397fc4d638aa78b37db2cd5b9c35b6deed94 exposed a bug (one that

[Impala-ASF-CR] IMPALA-3884: Support TYPE TIMESTAMP for HashTableCtx::CodegenAssignNullValue()

2016-10-21 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/4794 Change subject: IMPALA-3884: Support TYPE_TIMESTAMP for HashTableCtx::CodegenAssignNullValue() .. IMPALA-3884: Support TYPE_TIMESTAMP for

[Impala-ASF-CR] IMPALA-4241: remove spurious child queries event

2016-10-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4241: remove spurious child queries event .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4768 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4241: remove spurious child queries event

2016-10-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4241: remove spurious child queries event .. IMPALA-4241: remove spurious child queries event "IMPALA-4037,IMPALA-4038: fix locking during

[Impala-ASF-CR] IMPALA-4120: Incorrect results with LEAD() analytic function

2016-10-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4120: Incorrect results with LEAD() analytic function .. Patch Set 4: Code-Review+2 Carry Dan's +2 forward. -- To view, visit

[Impala-ASF-CR] IMPALA-4120: Incorrect results with LEAD() analytic function

2016-10-21 Thread Michael Ho (Code Review)
Hello Matthew Jacobs, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4740 to look at the new patch set (#4). Change subject: IMPALA-4120: Incorrect results with LEAD() analytic function

[Impala-ASF-CR] IMPALA-4120: Incorrect results with LEAD() analytic function

2016-10-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4120: Incorrect results with LEAD() analytic function .. Patch Set 3: (4 comments)

[Impala-ASF-CR] Enabling end-to-end tests on a remote cluster

2016-10-21 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#3). Change subject: Enabling end-to-end tests on a remote cluster .. Enabling end-to-end tests on a remote cluster This patch enables data loading and running end-to-end tests on a

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to clients

2016-10-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4335: Don't send 0-row batches to clients .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4787 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to clients

2016-10-21 Thread Henry Robinson (Code Review)
Hello Matthew Jacobs, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4787 to look at the new patch set (#4). Change subject: IMPALA-4335: Don't send 0-row batches to clients

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink

2016-10-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4335: Don't send 0-row batches to sink .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4787/3//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink

2016-10-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4335: Don't send 0-row batches to sink .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4787/2/be/src/exec/plan-root-sink.cc File

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink

2016-10-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4335: Don't send 0-row batches to sink .. Patch Set 2: Code-Review+2 Thanks. I verified it fixed case w/ the KuduScanNode. -- To view, visit

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-10-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 9: (7 comments) Thanks, the renaming helps a lot. My feeling is that the separation of

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-21 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#7). Change subject: IMPALA-2521: Add clustered hint to insert statements .. IMPALA-2521: Add clustered hint to insert statements This change introduces a clustered/noclustered hint for

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink

2016-10-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4335: Don't send 0-row batches to sink .. Patch Set 2: Code-Review+1 (1 comment) I suspect that whatever test we add may become stale pretty easily. The

[Impala-ASF-CR] IMPALA-3718: Add test cancellation tests for Kudu

2016-10-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3718: Add test_cancellation tests for Kudu .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4700 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3718: Add test cancellation tests for Kudu

2016-10-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3718: Add test_cancellation tests for Kudu .. IMPALA-3718: Add test_cancellation tests for Kudu Additional functional tests for Kudu.

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 11: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4047/11/be/src/exec/kudu-table-sink.cc

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink

2016-10-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4335: Don't send 0-row batches to sink .. Patch Set 1: Code-Review+1 (1 comment) Thanks. Not sure why it doesn't repro for you, Michael Brown repro'd

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink

2016-10-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4787 Change subject: IMPALA-4335: Don't send 0-row batches to sink .. IMPALA-4335: Don't send 0-row batches to sink This patchr restores

[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.

2016-10-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Minor fixes to remove more "cloudera"s from the code. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-21 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4047 to look at the new patch set (#10). Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. IMPALA-3725

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-21 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 10: (8 comments)

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4339: ensure coredumps end up in IMPALA HOME

2016-10-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4785 Change subject: IMPALA-4339: ensure coredumps end up in IMPALA_HOME .. IMPALA-4339: ensure coredumps end up in IMPALA_HOME Change-Id:

[Impala-ASF-CR] IMPALA-4295: XFAIL wildcard SSL test

2016-10-21 Thread Jim Apple (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4784 to look at the new patch set (#2). Change subject: IMPALA-4295: XFAIL wildcard SSL test .. IMPALA-4295: XFAIL

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 3: (9 comments) even w/o the new section, how does compute stats behave?

[Impala-ASF-CR] IMPALA-4295: 9f61397fc4d638aa78b37db2cd5b9c35b6deed94 exposed a bug

2016-10-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4295: 9f61397fc4d638aa78b37db2cd5b9c35b6deed94 exposed a bug .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-10-21 Thread Tim Armstrong (Code Review)
Hello Internal Jenkins, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4448 to look at the new patch set (#9). Change subject: IMPALA-4023: don't attach buffered tuple streams to batches

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-10-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/4448/8//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 6: (8 comments) http://gerrit.cloudera.org:8080/#/c/4728/6/be/src/exec/kudu-table-sink.cc File

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-21 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#5). Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. IMPALA-4309: Introduce Expr rewrite phase and supporting classes. Introduces a new phase for

[Impala-ASF-CR] IMPALA-4241: remove spurious child queries event

2016-10-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4241: remove spurious child queries event .. Patch Set 2: Code-Review+2 carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4768 To unsubscribe,

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-10-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. Patch Set 6: Rebased onto the codegen interface changes. -- To view, visit

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-10-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions This change enables codegen

[Impala-ASF-CR] IMPALA-4212: Add sink output expressions to explain output

2016-10-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4783 Change subject: IMPALA-4212: Add sink output expressions to explain output .. IMPALA-4212: Add sink output expressions to explain

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-10-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. Patch Set 4: (13 comments)

[Impala-ASF-CR] IMPALA-4120: Incorrect results with LEAD() analytic function

2016-10-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4120: Incorrect results with LEAD() analytic function .. Patch Set 3: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-21 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 3: (8 comments) As discussed, eliminated the separate list on the

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-21 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. IMPALA-1169: Admission control info on the queries debug webpage This patch adds a

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-10-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. .. Patch Set 18: Congrats, Amos! We are good to merge this patch. Do you have time to rebase it? -- To

[Impala-ASF-CR] IMPALA-3788: Support for Kudu 'read-your-writes' consistency

2016-10-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-3788: Support for Kudu 'read-your-writes' consistency .. IMPALA-3788: Support for Kudu 'read-your-writes' consistency Kudu provides an API to get/set a

[Impala-ASF-CR] IMPALA-4285/IMPALA-4286: Fixes for Parquet scanner with MT DOP > 0.

2016-10-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4285/IMPALA-4286: Fixes for Parquet scanner with MT_DOP > 0. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4767 To

[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.

2016-10-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Minor fixes to remove more "cloudera"s from the code. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4774/1//COMMIT_MSG Commit Message: Line 7:

[Impala-ASF-CR] IMPALA-3718: Add test cancellation tests for Kudu

2016-10-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3718: Add test_cancellation tests for Kudu .. Patch Set 3: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/4700 To unsubscribe,

[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.

2016-10-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Minor fixes to remove more "cloudera"s from the code. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4774/1//COMMIT_MSG Commit Message: Line 7:

Re: [Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-21 Thread Alex Behm
Thanks for your contribution! On Fri, Oct 21, 2016 at 12:45 AM, Internal Jenkins (Code Review) < ger...@cloudera.org> wrote: > Internal Jenkins has submitted this change and it was merged. > > Change subject: IMPALA-4325: StmtRewrite lost parentheses of > CompoundPredicate >

[Impala-ASF-CR] IMPALA-4285/IMPALA-4286: Fixes for Parquet scanner with MT DOP > 0.

2016-10-21 Thread Alex Behm (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4767 to look at the new patch set (#5). Change subject: IMPALA-4285/IMPALA-4286: Fixes for Parquet scanner with MT_DOP > 0.

[Impala-ASF-CR] IMPALA-4285/IMPALA-4286: Fixes for Parquet scanner with MT DOP > 0.

2016-10-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4285/IMPALA-4286: Fixes for Parquet scanner with MT_DOP > 0. .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/4767/4//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3739: Enable stress tests on Kudu .. IMPALA-3739: Enable stress tests on Kudu This commit modifies the stress test framework to run TPC-H and

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4753 To