[Impala-ASF-CR] IMPALA-4643: [DOCS] Set up many new keydefs

2017-02-06 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5923 Change subject: IMPALA-4643: [DOCS] Set up many new keydefs .. IMPALA-4643: [DOCS] Set up many new keydefs Make keydefs corresponding to

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5909/1/www/memz.tmpl File

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-06 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .. Patch Set 6: Pre-review build:

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-06 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#6). Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .. IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS The Kudu query tests were failing

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-02-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 14: (11 comments) http://gerrit.cloudera.org:8080/#/c/5649/14/docs/topics/impala_explain.xml File

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#14). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Make it easy to work with big numbers .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5902/2/be/src/util/decimal-util.h File

[Impala-ASF-CR] IMPALA-4880: Clarify synchronization policy for 'done ' in KuduScanNode

2017-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4880: Clarify synchronization policy for 'done_' in KuduScanNode .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 17: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#13). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-02-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 14: OK, maybe "any second" =~ "about a week". But I think all Dimitris's final comments are now

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-02-06 Thread John Russell (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5649 to look at the new patch set (#14). Change subject: [DOCS] Major update to Impala + Kudu page .. [DOCS]

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/11/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4731: Crash when sorting on non-deterministic expr

2017-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4731: Crash when sorting on non-deterministic expr .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5914/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/11/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 7: Thanks for the review Dan. I'll wait for Alex's +2. I ran a quick test against an

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 11: (9 comments) http://gerrit.cloudera.org:8080/#/c/5776/11/be/src/exprs/string-functions-ir.cc File

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

2017-02-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2020: Make it easy to work with big numbers .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/5902/2//COMMIT_MSG Commit Message: PS2, Line

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#3). Change subject: IMPALA-2020: Make it easy to work with big numbers .. IMPALA-2020: Make it easy to work with big numbers We're going to be working with some really big numbers that

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Make it easy to work with big numbers .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5902/2/be/src/util/decimal-util.h File

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 17: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/241/ --

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 17: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/5161 To

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-06 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5161 to look at the new patch set (#16). Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 16: Code-Review+2 carry -- To view, visit http://gerrit.cloudera.org:8080/5161 To

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 15: (4 comments)

[Impala-ASF-CR] IMPALA-4849: IllegalStateException from rewritten CASE expr

2017-02-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/5917 Change subject: IMPALA-4849: IllegalStateException from rewritten CASE expr .. IMPALA-4849: IllegalStateException from

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 7: I thought the missing stats was a query warning, but it looks like it's not. I agree it

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-06 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#12). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the

[Impala-ASF-CR] IMPALA-4738: STDDEV SAMP should return NULL for single record input

2017-02-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4738: STDDEV_SAMP should return NULL for single record input .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5800 To

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-06 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5828 to look at the new patch set (#7). Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning ..

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 6: (3 comments) - I'm not totally sure why IMPALA-1427 wasn't closed. Looks like it

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5389 To

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. IMPALA-3524: Don't process spilled partitions with 0 probe rows In the

[Impala-ASF-CR] IMPALA-4880: Clarify synchronization policy for 'done ' in KuduScanNode

2017-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4880: Clarify synchronization policy for 'done_' in KuduScanNode .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-4880: Clarify synchronization policy for 'done ' in KuduScanNode

2017-02-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4880: Clarify synchronization policy for 'done_' in KuduScanNode .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5494

[Impala-ASF-CR] IMPALA-4880: Clarify synchronization policy for 'done ' in KuduScanNode

2017-02-06 Thread Sailesh Mukil (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5494 to look at the new patch set (#4). Change subject: IMPALA-4880: Clarify synchronization policy for 'done_' in KuduScanNode

[Impala-ASF-CR] IMPALA-4880: Clarify synchronization policy for 'done ' in KuduScanNode

2017-02-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4880: Clarify synchronization policy for 'done_' in KuduScanNode .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-3909 (follow-up): Properly qualify min() and max() in header

2017-02-06 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5916 Change subject: IMPALA-3909 (follow-up): Properly qualify min() and max() in header .. IMPALA-3909 (follow-up): Properly qualify min()

[Impala-ASF-CR] IMPALA-3909 (follow-up): Properly qualify min() and max() in header

2017-02-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3909 (follow-up): Properly qualify min() and max() in header .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5916/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4880: Clarify synchronization policy for 'done ' in KuduScanNode

2017-02-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4880: Clarify synchronization policy for 'done_' in KuduScanNode .. Patch Set 3: (2 comments) looks fine to me

[Impala-ASF-CR] IMPALA-4738: STDDEV SAMP should return NULL for single record input

2017-02-06 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-4738: STDDEV_SAMP should return NULL for single record input .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/5800/3//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4738: STDDEV SAMP should return NULL for single record input

2017-02-06 Thread anujphadke (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5800 to look at the new patch set (#4). Change subject: IMPALA-4738: STDDEV_SAMP should return NULL for single record input

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

2017-02-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020: Make it easy to work with big numbers .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5902/2/be/src/util/decimal-util.h File

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 11: (15 comments) Please also add exprs.test as discussed offline to cover cases in which pattern or replace are

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 6: (3 comments) AFAICT, IMPALA-1427 should have been resolved when we stopped printing the

[Impala-ASF-CR] IMPALA-4731: Crash when sorting on non-deterministic expr

2017-02-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/5914 Change subject: IMPALA-4731: Crash when sorting on non-deterministic expr .. IMPALA-4731: Crash when sorting on

[Impala-ASF-CR] IMPALA-3748: Part 1: Clean up resource estimation in planner

2017-02-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3748: Part 1: Clean up resource estimation in planner .. Patch Set 3: (19 comments) http://gerrit.cloudera.org:8080/#/c/5847/3//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-02-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5389 To

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-02-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-02-06 Thread Thomas Tauber-Marshall (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5389 to look at the new patch set (#10). Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/5792/6/be/src/util/logging-support.cc

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#7). Change subject: IMPALA-4822: Implement dynamic log level changes .. IMPALA-4822: Implement dynamic log level changes Very often we have to change the logging levels of