[Impala-ASF-CR] IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6171 To uns

[Impala-ASF-CR] IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput .. IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput To test this,

[Impala-ASF-CR] IMPALA-4997: Fix overflows in Sorter::TupleIterator

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4997: Fix overflows in Sorter::TupleIterator .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6169 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-4997: Fix overflows in Sorter::TupleIterator

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4997: Fix overflows in Sorter::TupleIterator .. IMPALA-4997: Fix overflows in Sorter::TupleIterator Various places in Sorter::TupleIterat

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6132/8/be/src/runtime/decimal-value.inline.h File be/src/r

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6132/8/be/src/runtime/decimal-value.inline.h File be/src/r

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/6132/8/be/src/exprs/expr-test.cc File be/src/exprs/expr-t

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 15: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/319/ -- To view

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 8: (12 comments) Thanks for the review! http://gerrit.cloudera.org:8080/#/c/6132/8/be/src/exprs/expr-test.

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 15: Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/316/ -- To view,

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#9). Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and multiply when results are truncated. Testing:

[Impala-ASF-CR] IMPALA-4810: add DECIMAL test case to strict mode tests

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4810: add DECIMAL test case to strict_mode tests .. Patch Set 3: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/3

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 8: (12 comments) http://gerrit.cloudera.org:8080/#/c/6132/8/be/src/exprs/expr-test.cc File be/src/exprs/expr-

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6132/8/be/src/runtime/decimal-test.cc File be/src/runtim

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5969/6/be/src/exprs/timestamp-functions.cc Fi

[Impala-ASF-CR] IMPALA-4877: fix precedence of unary -/+

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4877: fix precedence of unary -/+ .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6044 To unsubscribe, visit http://

[Impala-ASF-CR] IMPALA-4877: fix precedence of unary -/+

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4877: fix precedence of unary -/+ .. IMPALA-4877: fix precedence of unary -/+ Currently, expressions such as "-2 / 3" parse as "-(2 / 3)"

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-28 Thread Taras Bobrovytsky (Code Review)
Hello Jim Apple, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5969 to look at the new patch set (#7). Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 ...

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/5969/6/be/src/exprs/timestamp-functi

[Impala-ASF-CR] IMPALA-5005: Don't allow server to send SASL COMPLETE msg out of order

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5005: Don't allow server to send SASL COMPLETE msg out of order .. IMPALA-5005: Don't allow server to send SASL COMPLETE msg out of order

[Impala-ASF-CR] IMPALA-5005: Don't allow server to send SASL COMPLETE msg out of order

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5005: Don't allow server to send SASL COMPLETE msg out of order .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/619

[Impala-ASF-CR] IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput

2017-02-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput .. Patch Set 2: Code-Review+2 Updated commit message, carrying Tim's +2. -- To view, visit http:/

[Impala-ASF-CR] IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/318

[Impala-ASF-CR] IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput

2017-02-28 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6171 to look at the new patch set (#2). Change subject: IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput

[Impala-ASF-CR] IMPALA-4997: Fix overflows in Sorter::TupleIterator

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4997: Fix overflows in Sorter::TupleIterator .. Patch Set 7: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/317/ -- To vi

[Impala-ASF-CR] IMPALA-4997: Fix overflows in Sorter::TupleIterator

2017-02-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4997: Fix overflows in Sorter::TupleIterator .. Patch Set 7: Build seems to have failed due to the S3 outage. Will restart it. -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-2328: Address additional comments

2017-02-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2328: Address additional comments .. Patch Set 3: (3 comments) Thanks for the review. Please see PS4. http://gerrit.cloudera.org:8080/#/c/6147/3/be/src/ex

[Impala-ASF-CR] IMPALA-2328: Address additional comments

2017-02-28 Thread Lars Volker (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6147 to look at the new patch set (#4). Change subject: IMPALA-2328: Address additional comments .. IMPALA-2328: Address ad

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Add a build flag for the undefined behavior sanitizer, aka "ubsan". Ubsa

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6186 T

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#8). Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and multiply when results are truncated. Testing:

[Impala-ASF-CR] PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables

2017-02-28 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables .. PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables Bulk inserts into Kudu are currentl

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 7: Okay, this is good for review. Sorry for so many test cases - but they ended up finding a few good bugs

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#7). Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and multiply when results are truncated. Testing:

[Impala-ASF-CR] IMPALA-4899: Fix parquet table writer dictionary leak

2017-02-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-4899: Fix parquet table writer dictionary leak .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6181/3/be/src/exec/hdfs-table-sink.h File

[Impala-ASF-CR] IMPALA-4899: Fix parquet table writer dictionary leak

2017-02-28 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6181 to look at the new patch set (#4). Change subject: IMPALA-4899: Fix parquet table writer dictionary leak .. IMPALA

[Impala-ASF-CR] IMPALA-4982: Add parquet stats test

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4982: Add parquet stats test .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6130 To unsubscribe, visit http://gerri

[Impala-ASF-CR] IMPALA-4982: Add parquet stats test

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4982: Add parquet stats test .. IMPALA-4982: Add parquet stats test IMPALA-2328 added support for skipping row groups based on parquet::S

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/6132/6/be/src/runtime/decimal-value.inline.h File be/sr

[Impala-ASF-CR] IMPALA-4998: Fix missing table lock acquisition.

2017-02-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4998: Fix missing table lock acquisition. .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6177/5/fe/src/main/java/org/apache/impal

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 15: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/316/ -- To view

[Impala-ASF-CR] Remove deadcode from frontend - Part 1

2017-02-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: Remove deadcode from frontend - Part 1 .. Patch Set 1: (1 comment) Also I'm afraid if the stuff I removed from this might affect xplain tool as I rememb

[Impala-ASF-CR] Remove deadcode from frontend - Part 1

2017-02-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#2). Change subject: Remove deadcode from frontend - Part 1 .. Remove deadcode from frontend - Part 1 Change-Id: I3fa810cf4eaf9f9ff545fe80a11bc62619039224 --- M fe/src/main/java

[Impala-ASF-CR] IMPALA-4899: Fix parquet table writer dictionary leak

2017-02-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4899: Fix parquet table writer dictionary leak .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/6181/3/be/src/exec/hdfs-tabl

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#6). Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and multiply when results are truncated. Testing:

[Impala-ASF-CR] IMPALA-4810: add DECIMAL test case to strict mode tests

2017-02-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: add DECIMAL test case to strict_mode tests .. Patch Set 3: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/6150 To unsubscribe,

[Impala-ASF-CR] IMPALA-4810: add DECIMAL test case to strict mode tests

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4810: add DECIMAL test case to strict_mode tests .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/315/ -- T

[Impala-ASF-CR] IMPALA-4810: add DECIMAL test case to strict mode tests

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4810: add DECIMAL test case to strict_mode tests .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/314/ -- T

[Impala-ASF-CR] IMPALA-4810: add DECIMAL test case to strict mode tests

2017-02-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4810: add DECIMAL test case to strict_mode tests .. Patch Set 2: Code-Review+2 Looks good to me, thanks for adding these. -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-3401: [DOCS] Remove blocks of content devoted to CM

2017-02-28 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: IMPALA-3401: [DOCS] Remove blocks of content devoted to CM .. Patch Set 4: I don't have a clean build. Are there references to impala_howto_rm still remaining in

[Impala-ASF-CR] IMPALA-4877: fix precedence of unary -/+

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4877: fix precedence of unary -/+ .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/313/ -- To view, visit h

[Impala-ASF-CR] IMPALA-4877: fix precedence of unary -/+

2017-02-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4877: fix precedence of unary -/+ .. Patch Set 5: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/6044 To unsubscribe, visit http://g

[Impala-ASF-CR] IMPALA-2328: Address additional comments

2017-02-28 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2328: Address additional comments .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6147/3/be/src/exec/hdfs-parquet-scanner.cc File be/

[Impala-ASF-CR] IMPALA-4997: Fix overflows in Sorter::TupleIterator

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4997: Fix overflows in Sorter::TupleIterator .. Patch Set 7: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/307/

[Impala-ASF-CR] IMPALA-2328: Address additional comments

2017-02-28 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2328: Address additional comments .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6147/3/be/src/exec/hdfs-parquet-scanner.cc Fi

[Impala-ASF-CR] IMPALA-4899: Fix parquet table writer dictionary leak

2017-02-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-4899: Fix parquet table writer dictionary leak .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6181/2//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-4624: Implement Parquet dictionary filtering

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4624: Implement Parquet dictionary filtering .. Patch Set 16: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/306/

[Impala-ASF-CR] IMPALA-5005: Don't allow server to send SASL COMPLETE msg out of order

2017-02-28 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5005: Don't allow server to send SASL COMPLETE msg out of order .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6190 To unsu

[Impala-ASF-CR] IMPALA-4899: Fix parquet table writer dictionary leak

2017-02-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#3). Change subject: IMPALA-4899: Fix parquet table writer dictionary leak .. IMPALA-4899: Fix parquet table writer dictionary leak Currently, in HdfsTableSink, OutputPartitions are ad

[Impala-ASF-CR] Remove deadcode from frontend - Part 1

2017-02-28 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Remove deadcode from frontend - Part 1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6172/1/fe/src/main/java/org/apache/impala/analysis/AnalyticIn

[Impala-ASF-CR] IMPALA-4998: Fix missing table lock acquisition.

2017-02-28 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#5). Change subject: IMPALA-4998: Fix missing table lock acquisition. .. IMPALA-4998: Fix missing table lock acquisition. The following commit broke test_views_compatibility.py which only

[Impala-ASF-CR] IMPALA-4998: Fix missing table lock acquisition.

2017-02-28 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#4). Change subject: IMPALA-4998: Fix missing table lock acquisition. .. IMPALA-4998: Fix missing table lock acquisition. The following commit broke test_views_compatibility.py which only

[Impala-ASF-CR] IMPALA-4998: Fix missing table lock acquisition.

2017-02-28 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4998: Fix missing table lock acquisition. .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6177/3/fe/src/main/java/org/apache/impala/catalog/

[Impala-ASF-CR] IMPALA-5005: Don't allow server to send SASL COMPLETE msg out of order

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5005: Don't allow server to send SASL COMPLETE msg out of order .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dr

[Impala-ASF-CR] IMPALA-5005: Don't allow server to send SASL COMPLETE msg out of order

2017-02-28 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6190 Change subject: IMPALA-5005: Don't allow server to send SASL COMPLETE msg out of order .. IMPALA-5005: Don't allow server to send SASL

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 15: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/310/ -

[Impala-ASF-CR] Remove deadcode from frontend - Part 1

2017-02-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: Remove deadcode from frontend - Part 1 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6172/1/fe/src/main/java/org/apache/impala/analysi

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 5: (9 comments) http://gerrit.cloudera.org:8080/#/c/6132/2/be/src/exprs/decimal-operators-ir.cc File be/src

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 15: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/310/ -- To view

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 15: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/311/ -- To view

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. IMPALA-4885: Expose Jvm thread info in web UI This commit exposes information about JVM threads to the imp

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/6013/2/be/src/util/thread.cc File be/src

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 15: Code-Review+2 Thanks Henry. Rebased and increased the page width to 50% for it look good

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-28 Thread Bharath Vissapragada (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5792 to look at the new patch set (#15). Change subject: IMPALA-4822: Implement dynamic log level changes .. IMPALA-48

[Impala-ASF-CR] Fix parquet table writer dictionary leak

2017-02-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Fix parquet table writer dictionary leak .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6181/2//COMMIT_MSG Commit Message: Line 7: Fix parque

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryru

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-02-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6186 To unsubsc

[Impala-ASF-CR] Fix parquet table writer dictionary leak

2017-02-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: Fix parquet table writer dictionary leak .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6181/1/be/src/exec/hdfs-table-sink.cc File be/src/exec

[Impala-ASF-CR] Fix parquet table writer dictionary leak

2017-02-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#2). Change subject: Fix parquet table writer dictionary leak .. Fix parquet table writer dictionary leak Currently, in HdfsTableSink, OutputPartitions are added to the RuntimeState ob

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-02-28 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 1: This is a simpler version of https://gerrit.cloudera.org/#/c/5082/, which also

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-02-28 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/6186 Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Add a build flag for the undefined behavior sanitizer

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 14: Code-Review+2 Discussed offline. I believe the out-of-the-box behaviour hasn't changed. -- T

[Impala-ASF-CR] IMPALA-3401: [DOCS] Remove blocks of content devoted to CM

2017-02-28 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3401: [DOCS] Remove blocks of content devoted to CM .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6179/2//COMMIT_MSG Commit Message: L

[Impala-ASF-CR] IMPALA-3401: [DOCS] Remove blocks of content devoted to CM

2017-02-28 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#4). Change subject: IMPALA-3401: [DOCS] Remove blocks of content devoted to CM .. IMPALA-3401: [DOCS] Remove blocks of content devoted to CM Change-Id: I07d56463939fe152c1c6124cc0ad559

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager.

2017-02-28 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#3). Change subject: IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager. .. IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera

[Impala-ASF-CR] Fix parquet table writer dictionary leak

2017-02-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Fix parquet table writer dictionary leak .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6181/1/be/src/exec/hdfs-table-sink.cc File be/src/exec

[Impala-ASF-CR] IMPALA-4982: Add parquet stats test

2017-02-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4982: Add parquet stats test .. Patch Set 6: Code-Review+2 Added num_nodes=1 to the exec_option of the test. Carrying Alex's +2. -- To view, visit http://

[Impala-ASF-CR] IMPALA-4982: Add parquet stats test

2017-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4982: Add parquet stats test .. Patch Set 6: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/308/ -- To view, visit http:/

[Impala-ASF-CR] IMPALA-4982: Add parquet stats test

2017-02-28 Thread Lars Volker (Code Review)
Hello Impala Public Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6130 to look at the new patch set (#6). Change subject: IMPALA-4982: Add parquet stats test .. IMPAL

[Impala-ASF-CR] Fix parquet table writer dictionary leak

2017-02-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6181 Change subject: Fix parquet table writer dictionary leak .. Fix parquet table writer dictionary leak Currently, in HdfsTableSink, Output

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager.

2017-02-28 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager. .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6179/2//CO

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references

2017-02-28 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references .. Patch Set 4: Code-Review+1 Build looks good. -- To view, visit http://gerrit.cloudera.org:8080/6146 To

[Impala-ASF-CR] IMPALA-4966: Add flatbuffers to build

2017-02-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6180 Change subject: IMPALA-4966: Add flatbuffers to build .. IMPALA-4966: Add flatbuffers to build FlatBuffers version 1.6.0 is alre

[Impala-ASF-CR] IMPALA-4624: Implement Parquet dictionary filtering

2017-02-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4624: Implement Parquet dictionary filtering .. Patch Set 16: It looks like you'll have to do a follow-on patch to solve the bootstrapping problem with t

[Impala-ASF-CR] IMPALA-4624: Implement Parquet dictionary filtering

2017-02-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4624: Implement Parquet dictionary filtering .. Patch Set 14: (7 comments) Flushing out some comments I made while in transit. I don't have any concerns

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references

2017-02-28 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6146/3/docs/topics/impala_avro.xml File d

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references

2017-02-28 Thread John Russell (Code Review)
Hello Ambreen Kazi, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6146 to look at the new patch set (#4). Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references .. IMPALA

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager.

2017-02-28 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#2). Change subject: IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager. .. IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager.

2017-02-28 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6179 Change subject: IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager. .. IMPALA-3401: [DOCS] Physically re

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references

2017-02-28 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6146/3/docs/topics/impala_avro.xml File d

  1   2   >