[Impala-ASF-CR] IMPALA-4675: Case-insensitive matching of Parquet fields.

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4675: Case-insensitive matching of Parquet fields. .. Patch Set 6: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/336/ --

[Impala-ASF-CR] IMPALA-4675: Case-insensitive matching of Parquet fields.

2017-03-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4675: Case-insensitive matching of Parquet fields. .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5891 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-03-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2020: Inline big number strings .. Patch Set 12: Code-Review+1 Thanks for simplifying so much. -- To view, visit http://gerrit.cloudera.org:8080/5902 To uns

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-03-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/5811/5/be/src/runtime/buffered-tuple-st

[Impala-ASF-CR] IMPALA-4675: Case-insensitive matching of Parquet fields.

2017-03-02 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4675: Case-insensitive matching of Parquet fields. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5891 To unsubscribe

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-03-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020: Inline big number strings .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/5902/12/be/src/runtime/decimal-value.inline.h File be/src/ru

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-03-02 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Inline big number strings .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/5902/12/be/src/runtime/decimal-value.inline.h File be/src/

[Impala-ASF-CR] IMPALA-5015: Run parquet stats test.py with mt dop > 0

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5015: Run parquet_stats_test.py with mt_dop > 0 .. Patch Set 2: Code-Review+2 Rebased. Carrying Marcel's +2. -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-03-02 Thread Zach Amsden (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5902 to look at the new patch set (#12). Change subject: IMPALA-2020: Inline big number strings .. IMPALA-2020: Inline big

[Impala-ASF-CR] IMPALA-5015: Run parquet stats test.py with mt dop > 0

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5015: Run parquet_stats_test.py with mt_dop > 0 .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/335/ -- To

[Impala-ASF-CR] IMPALA-5008: Fix reading stats for TINYINT and SMALLINT

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5008: Fix reading stats for TINYINT and SMALLINT .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/334/ -- T

[Impala-ASF-CR] IMPALA-5008: Fix reading stats for TINYINT and SMALLINT

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5008: Fix reading stats for TINYINT and SMALLINT .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6226 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5008: Fix reading stats for TINYINT and SMALLINT

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5008: Fix reading stats for TINYINT and SMALLINT .. Patch Set 3: Rebased. Carrying Tim's +2. -- To view, visit http://gerrit.cloudera.org:8080/6226 To uns

[Impala-ASF-CR] IMPALA-5008: Fix reading stats for TINYINT and SMALLINT

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5008: Fix reading stats for TINYINT and SMALLINT .. Patch Set 3: (2 comments) Thanks for your review. I addressed the comments in PS4. Will rebase next. h

[Impala-ASF-CR] IMPALA-5008: Fix reading stats for TINYINT and SMALLINT

2017-03-02 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6226 to look at the new patch set (#4). Change subject: IMPALA-5008: Fix reading stats for TINYINT and SMALLINT .. IMPA

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 11: After talking to Alex, I completely rewrote the patch and reran the benchmarks. The state

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#11). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as AP

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-02 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#11). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage ..

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/6025/10/be/src/exprs/aggregate-functions-

[Impala-ASF-CR] IMPALA-4946: fix hang in BufferPool

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4946: fix hang in BufferPool .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6224 To unsubscribe, visit http://gerri

[Impala-ASF-CR] IMPALA-4946: fix hang in BufferPool

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4946: fix hang in BufferPool .. IMPALA-4946: fix hang in BufferPool Once the write is removed from the "in flight" list, both the Client

[Impala-ASF-CR] PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables

2017-03-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables .. Patch Set 3: Thanks, Thomas. I think the overall approach makes sense. I haven't gone through and

[Impala-ASF-CR] IMPALA-2328: Address additional comments

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-2328: Address additional comments .. IMPALA-2328: Address additional comments - test_parquet_stats.py was missing and the tests weren't r

[Impala-ASF-CR] IMPALA-2328: Address additional comments

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2328: Address additional comments .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6147 To unsubscribe, visit http://

[Impala-ASF-CR] IMPALA-4675: Case-insensitive matching of Parquet fields.

2017-03-02 Thread Alex Behm (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5891 to look at the new patch set (#5). Change subject: IMPALA-4675: Case-insensitive matching of Parquet fields. .. IMPA

[Impala-ASF-CR] IMPALA-4675: Case-insensitive matching of Parquet fields.

2017-03-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4675: Case-insensitive matching of Parquet fields. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5891/4/be/src/exec/parquet-metadata-utils.

[Impala-ASF-CR] Update parameter order in test mt dop.py

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Update parameter order in test_mt_dop.py .. Update parameter order in test_mt_dop.py The rest of the code base uses them in a different order. T

[Impala-ASF-CR] Update parameter order in test mt dop.py

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Update parameter order in test_mt_dop.py .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6228 To unsubscribe, visit http://

[Impala-ASF-CR] IMPALA-4810: add DECIMAL test case to strict mode tests

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4810: add DECIMAL test case to strict_mode tests .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6150 To unsubscribe

[Impala-ASF-CR] IMPALA-4810: add DECIMAL test case to strict mode tests

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4810: add DECIMAL test case to strict_mode tests .. IMPALA-4810: add DECIMAL test case to strict_mode tests The string parsing code alrea

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-03-02 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Inline big number strings .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/5902/5//COMMIT_MSG Commit Message: PS5, Line 38: 0.83s >

[Impala-ASF-CR] IMPALA-4616: Add missing Kudu column options

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4616: Add missing Kudu column options .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6220 To unsubscribe, visit htt

[Impala-ASF-CR] IMPALA-4616: Add missing Kudu column options

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4616: Add missing Kudu column options .. IMPALA-4616: Add missing Kudu column options Adds support for missing Kudu column options in ALT

[Impala-ASF-CR] IMPALA-4899: Fix parquet table writer dictionary leak

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4899: Fix parquet table writer dictionary leak .. IMPALA-4899: Fix parquet table writer dictionary leak Currently, in HdfsTableSink, Outp

[Impala-ASF-CR] IMPALA-4899: Fix parquet table writer dictionary leak

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4899: Fix parquet table writer dictionary leak .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6181 To unsubscribe,

[Impala-ASF-CR] IMPALA-5008: Fix reading stats for TINYINT and SMALLINT

2017-03-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5008: Fix reading stats for TINYINT and SMALLINT .. Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/6226/3/be/src/exec/parque

[native-toolchain-CR] Add a script to build Kudu using existing toolchain artifacts

2017-03-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Add a script to build Kudu using existing toolchain artifacts .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6167 To unsubscribe,

[native-toolchain-CR] Add a script to build Kudu using existing toolchain artifacts

2017-03-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: Add a script to build Kudu using existing toolchain artifacts .. Add a script to build Kudu using existing toolchain artifacts Adds 'build-kudu-only.sh

[native-toolchain-CR] Add a script to build Kudu using existing toolchain artifacts

2017-03-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add a script to build Kudu using existing toolchain artifacts .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6167 To unsubscrib

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. IMPALA-4546: Fix Moscow timezone conversion after 2014 In 2014 Moscow timezone rules c

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5969 To unsubscribe,

[Impala-ASF-CR] IMPALA-4946: fix hang in BufferPool

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4946: fix hang in BufferPool .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/333/ -- To view, visit http:/

[native-toolchain-CR] Add a script to build Kudu using existing toolchain artifacts

2017-03-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: Add a script to build Kudu using existing toolchain artifacts .. Add a script to build Kudu using existing toolchain artifacts Adds 'build-kudu-only.sh' to allow

[native-toolchain-CR] Add a script to build Kudu using existing toolchain artifacts

2017-03-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Add a script to build Kudu using existing toolchain artifacts .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/6167/2/build-kudu-single.sh File

[Impala-ASF-CR] IMPALA-4675: Case-insensitive matching of Parquet fields.

2017-03-02 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4675: Case-insensitive matching of Parquet fields. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5891/4/be/src/exec/parquet-metadata

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-03-02 Thread Zach Amsden (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5902 to look at the new patch set (#10). Change subject: IMPALA-2020: Inline big number strings .. IMPALA-2020: Inline big

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-03-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2020: Inline big number strings .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/5902/5//COMMIT_MSG Commit Message: PS5, Line 38: 0.83s > wh

[Impala-ASF-CR] Update parameter order in test mt dop.py

2017-03-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Update parameter order in test_mt_dop.py .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6228/2/tests/query_test/test_mt_dop.py File tests/query_tes

[Impala-ASF-CR] IMPALA-5006 [DOCS] Remove chunks of Cloudera-specific content from the Impala Security Guide.

2017-03-02 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: IMPALA-5006 [DOCS] Remove chunks of Cloudera-specific content from the Impala Security Guide. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/62

[Impala-ASF-CR] IMPALA-5006 [DOCS] Remove chunks of Cloudera-specific content from the Impala Security Guide.

2017-03-02 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has uploaded a new patch set (#2). Change subject: IMPALA-5006 [DOCS] Remove chunks of Cloudera-specific content from the Impala Security Guide. .. IMPALA-5006 [DOCS] Remove chunks of Cloudera-specific content from

[Impala-ASF-CR] IMPALA-5015: Run parquet stats test.py with mt dop > 0

2017-03-02 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5015: Run parquet_stats_test.py with mt_dop > 0 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6232 To unsubscribe, v

[native-toolchain-CR] Bump breakpad version

2017-03-02 Thread Lars Volker (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6213 to look at the new patch set (#3). Change subject: Bump breakpad version .. Bump breakpad version This will give

[Impala-ASF-CR] PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables

2017-03-02 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6037/1/be/src/runtime/data-s

[Impala-ASF-CR] PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables

2017-03-02 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables .. PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables Bulk inserts into Kudu are currentl

[native-toolchain-CR] Bump breakpad version

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. Change subject: Bump breakpad version .. Bump breakpad version This will give us better support for DWARF version 4, support for redaction of sensitive data, and a multit

[native-toolchain-CR] Bump breakpad version

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Bump breakpad version .. Patch Set 3: Code-Review+2 Verified+1 (2 comments) Thank you for the review. I addressed all your comments and ran a full build. http://

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal.

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6070 To unsubscri

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal.

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. .. IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. Most of these fixes entai

[Impala-ASF-CR] IMPALA-5006 [DOCS] Remove chunks of Cloudera-specific content from the Impala Security Guide.

2017-03-02 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-5006 [DOCS] Remove chunks of Cloudera-specific content from the Impala Security Guide. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/62

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal.

2017-03-02 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6070 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal.

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/58/ -- To

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal.

2017-03-02 Thread Laurel Hale (Code Review)
Hello John Russell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6070 to look at the new patch set (#4). Change subject: IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. .. IMP

[Impala-ASF-CR] IMPALA-4675: Case-insensitive matching of Parquet fields.

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4675: Case-insensitive matching of Parquet fields. .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5891 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-5015: Run parquet stats test.py with mt dop > 0

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5015: Run parquet_stats_test.py with mt_dop > 0 .. Patch Set 1: This has merge conflicts because it depends on "IMPALA-2328: Address additional comments",

[Impala-ASF-CR] IMPALA-5015: Run parquet stats test.py with mt dop > 0

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/6232 Change subject: IMPALA-5015: Run parquet_stats_test.py with mt_dop > 0 .. IMPALA-5015: Run parquet_stats_test.py with mt_dop > 0 Change-Id

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. Most of these fixes entailed hiding the paragraph where there are mentions of CM and writing a replacement paragraph for the u

2017-03-02 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. Most of these fixes entailed hiding the paragraph where there are mentions of CM and writing a replacement paragraph for the upstream docs. This removes the CM references

[Impala-ASF-CR] IMPALA-5006 [DOCS] Remove chunks of Cloudera-specific content from the Impala Security Guide.

2017-03-02 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has uploaded a new change for review. http://gerrit.cloudera.org:8080/6231 Change subject: IMPALA-5006 [DOCS] Remove chunks of Cloudera-specific content from the Impala Security Guide. .. IMPALA-5006 [DOCS] Remov

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. Most of these fixes entailed hiding the paragraph where there are mentions of CM and writing a replacement paragraph for the u

2017-03-02 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. Most of these fixes entailed hiding the paragraph where there are mentions of CM and writing a replacement paragraph for the upstream docs. This removes the CM references f

[Impala-ASF-CR] Update parameter order in test mt dop.py

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Update parameter order in test_mt_dop.py .. Patch Set 1: (1 comment) > Sure, for the sake of consistency, I'm OK with this change. > > There are actually two p

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. Most of these fixes entailed hiding the paragraph where there are mentions of CM and writing a replacement paragraph for the u

2017-03-02 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#3). Change subject: IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. Most of these fixes entailed hiding the paragraph where there are mentions of CM and writing a replacement paragraph for the upstream docs. This removes the CM references f

[Impala-ASF-CR] IMPALA-2328: Address additional comments

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2328: Address additional comments .. Patch Set 6: Code-Review+2 Rebased, carrying Marcel's +2. -- To view, visit http://gerrit.cloudera.org:8080/6147 To u

[Impala-ASF-CR] IMPALA-2328: Address additional comments

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2328: Address additional comments .. Patch Set 6: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/332/ -- To view, visit h

[Impala-ASF-CR] Update parameter order in test mt dop.py

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Update parameter order in test_mt_dop.py .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/331/ -- To view, visit h

[Impala-ASF-CR] Update parameter order in test mt dop.py

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Update parameter order in test_mt_dop.py .. Patch Set 2: Code-Review+2 Carrying MJ's +2. -- To view, visit http://gerrit.cloudera.org:8080/6228 To unsubscribe, v

[Impala-ASF-CR] Update parameter order in test mt dop.py

2017-03-02 Thread Lars Volker (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6228 to look at the new patch set (#2). Change subject: Update parameter order in test_mt_dop.py .. Update parameter o

[Impala-ASF-CR] IMPALA-4810: add DECIMAL test case to strict mode tests

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4810: add DECIMAL test case to strict_mode tests .. Patch Set 6: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/330/ -- T

[Impala-ASF-CR] Fix parameter order in test mt dop.py

2017-03-02 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Fix parameter order in test_mt_dop.py .. Patch Set 1: Sure, for the sake of consistency, I'm OK with this change. There are actually two places where this occurs.

[Impala-ASF-CR] IMPALA-4810: add DECIMAL test case to strict mode tests

2017-03-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: add DECIMAL test case to strict_mode tests .. Patch Set 6: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/6150 To unsubscribe,

[Impala-ASF-CR] IMPALA-4810: add DECIMAL test case to strict mode tests

2017-03-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4810: add DECIMAL test case to strict_mode tests .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6150 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-4810: add DECIMAL test case to strict mode tests

2017-03-02 Thread Dan Hecht (Code Review)
Hello Impala Public Jenkins, Matthew Jacobs, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6150 to look at the new patch set (#5). Change subject: IMPALA-4810: add DECIMAL test case to strict_mode tests ...

[Impala-ASF-CR] IMPALA-4899: Fix parquet table writer dictionary leak

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4899: Fix parquet table writer dictionary leak .. Patch Set 6: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/329/ -- To

[Impala-ASF-CR] IMPALA-4899: Fix parquet table writer dictionary leak

2017-03-02 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4899: Fix parquet table writer dictionary leak .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6181 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-4946: fix hang in BufferPool

2017-03-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4946: fix hang in BufferPool .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6224 To unsubscribe, visit http://gerrit.clouder

[Impala-ASF-CR] Fix parameter order in test mt dop.py

2017-03-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Fix parameter order in test_mt_dop.py .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6228/1/tests/query_test/test_mt_dop.py File

[Impala-ASF-CR] IMPALA-2328: Address additional comments

2017-03-02 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2328: Address additional comments .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6147 To unsubscribe, visit http://ge

[Impala-ASF-CR] Fix parameter order in test mt dop.py

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Fix parameter order in test_mt_dop.py .. Patch Set 1: (1 comment) Thanks for having a look. David, please see my reply to MJ's comment. http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-4616: Add missing Kudu column options

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4616: Add missing Kudu column options .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/328/ -- To view, vis

[Impala-ASF-CR] IMPALA-4616: Add missing Kudu column options

2017-03-02 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4616: Add missing Kudu column options .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6220 To unsubscribe, visit http:

[Impala-ASF-CR] IMPALA-5008: Fix reading stats for TINYINT and SMALLINT

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5008: Fix reading stats for TINYINT and SMALLINT .. Patch Set 2: (3 comments) Thanks for the review. Please see PS 3. http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] Fix parameter order in test mt dop.py

2017-03-02 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Fix parameter order in test_mt_dop.py .. Patch Set 1: With pytest fixtures, I don't think order matters. -- To view, visit http://gerrit.cloudera.org:8080/6228 T

[Impala-ASF-CR] IMPALA-5008: Fix reading stats for TINYINT and SMALLINT

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). Change subject: IMPALA-5008: Fix reading stats for TINYINT and SMALLINT .. IMPALA-5008: Fix reading stats for TINYINT and SMALLINT TINYINT and SMALLINT types use 1 and 2 byte slots

[Impala-ASF-CR] Fix parameter order in test mt dop.py

2017-03-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Fix parameter order in test_mt_dop.py .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6228/1/tests/query_test/test_mt_dop.py File tests/query_t

[Impala-ASF-CR] IMPALA-2328: Address additional comments

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2328: Address additional comments .. Patch Set 4: (3 comments) Thanks for the review, please see PS5. http://gerrit.cloudera.org:8080/#/c/6147/4/be/src/ex

[Impala-ASF-CR] IMPALA-2328: Address additional comments

2017-03-02 Thread Lars Volker (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6147 to look at the new patch set (#5). Change subject: IMPALA-2328: Address additional comments .. IMPALA-2328: Address ad

[Impala-ASF-CR] IMPALA-4616: Add missing Kudu column options

2017-03-02 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4616: Add missing Kudu column options .. Patch Set 1: i'll take this. -- To view, visit http://gerrit.cloudera.org:8080/6220 To unsubscribe, visit ht

[Impala-ASF-CR] IMPALA-2328: Address additional comments

2017-03-02 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2328: Address additional comments .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6147/4/be/src/exec/hdfs-parquet-scanner.cc File be/

[Impala-ASF-CR] IMPALA-4675: Case-insensitive matching of Parquet fields.

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4675: Case-insensitive matching of Parquet fields. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5891/4/tests/query_test/test_scanners.py

[Impala-ASF-CR] Fix parameter order in test mt dop.py

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/6228 Change subject: Fix parameter order in test_mt_dop.py .. Fix parameter order in test_mt_dop.py Change-Id: I925711eb4d4334c179d336f6ebcc91d

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references .. IMPALA-3402: [DOCS] Remove/reword all CDH 4 references Along the way, remove nearby re

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6146 To unsubscribe,

  1   2   >