[Impala-ASF-CR] IMPALA-3973: optional 2nd and 3rd arguments for instr().

2017-03-07 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3973: optional 2nd and 3rd arguments for instr(). .. Patch Set 2: PS2 was posted more than two months ago. Are you interested in continuing this? If not, you

[native-toolchain-CR](cdh5.11.0) IMPALA-5025: upgrade to binutils 2.26.1

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5025: upgrade to binutils 2.26.1 .. Patch Set 1: Verified+1 Build ID 364-1b266466ae -- To view, visit http://gerrit.cloudera.org:8080/6310 To unsubscrib

[native-toolchain-CR](cdh5.11.0) IMPALA-5025: upgrade to binutils 2.26.1

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-5025: upgrade to binutils 2.26.1 .. IMPALA-5025: upgrade to binutils 2.26.1 This has two fixes that we care about: * The slow linking problem tha

[Impala-ASF-CR] IMPALA-5039: Fix variability in parquet dictionary filtering test

2017-03-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5039: Fix variability in parquet dictionary filtering test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6301/1/tests/query_test/test_mt_d

[Impala-ASF-CR] IMPALA-4711: clarify is null semantics in udf.h

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4711: clarify is_null semantics in udf.h .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/6311 To unsubscribe, v

[Impala-ASF-CR] IMPALA-4711: clarify is null semantics in udf.h

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4711: clarify is_null semantics in udf.h .. IMPALA-4711: clarify is_null semantics in udf.h This is to reduce the chance of confusion about what

[Impala-ASF-CR] IMPALA-4711: clarify is null semantics in udf.h

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4711: clarify is_null semantics in udf.h .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6311 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#10). Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement union passthrough The union node acts as pass through operator and forwards row batches fro

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 9: (12 comments) http://gerrit.cloudera.org:8080/#/c/5816/9//COMMIT_MSG Commit Message: Line 15: as a

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-07 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5816 to look at the new patch set (#10). Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-07 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5816 to look at the new patch set (#10). Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement

[native-toolchain-CR](cdh5.11.0) IMPALA-5025: upgrade to binutils 2.26.1

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5025: upgrade to binutils 2.26.1 .. Patch Set 1: I'm building it as we speak -- To view, visit http://gerrit.cloudera.org:8080/6310 To unsubscribe, visi

[Impala-ASF-CR] IMPALA-4711: clarify is null semantics in udf.h

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4711: clarify is_null semantics in udf.h .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/356/ -- To view,

[Impala-ASF-CR] IMPALA-4711: clarify is null semantics in udf.h

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4711: clarify is_null semantics in udf.h .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6311/1/be/src/udf/udf.h File be/sr

[Impala-ASF-CR] IMPALA-4711: clarify is null semantics in udf.h

2017-03-07 Thread Tim Armstrong (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6311 to look at the new patch set (#2). Change subject: IMPALA-4711: clarify is_null semantics in udf.h .. IMPALA-4711: cl

[Impala-ASF-CR] IMPALA-5021: Fix count(*) remaining rows overflow in Parquet.

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5021: Fix count(*) remaining rows overflow in Parquet. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6286 To unsub

[Impala-ASF-CR] IMPALA-5021: Fix count(*) remaining rows overflow in Parquet.

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5021: Fix count(*) remaining rows overflow in Parquet. .. IMPALA-5021: Fix count(*) remaining rows overflow in Parquet. Zero-slot scans o

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 3: (17 comments) Few stylistic comments. http://gerrit.cloudera.org:8080/#/c/6037/4/be/src/runtime/d

[Impala-ASF-CR] IMPALA-5027: addendum - remove unneeded #define

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5027: addendum - remove unneeded #define .. IMPALA-5027: addendum - remove unneeded #define Change-Id: I8b460fc69ddb08ef0b68be725ec16782a

[Impala-ASF-CR] IMPALA-5027: addendum - remove unneeded #define

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5027: addendum - remove unneeded #define .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6298 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4725: Query option to control Parquet array resolution.

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4725: Query option to control Parquet array resolution. .. Patch Set 3: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-d

[Impala-ASF-CR] IMPALA-4711: clarify is null semantics in udf.h

2017-03-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4711: clarify is_null semantics in udf.h .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6311/1/be/src/udf/udf.h File be/src/u

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. IMPALA-4885: Expose Jvm thread info in web UI This commit exposes information about JVM threads

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6013 To unsubscribe, visit ht

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#4). Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. IMPALA-3742: partitions DMLs for Kudu tables Bulk DMLs (INSERT, UPSERT, UPDATE, and DELETE) for Kudu are c

[Impala-ASF-CR] IMPALA-4996: Single-threaded KuduScanNode

2017-03-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6312 Change subject: IMPALA-4996: Single-threaded KuduScanNode .. IMPALA-4996: Single-threaded KuduScanNode This introduces KuduScanNodeMt, t

[Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5038: Fix file size regex to include bytes .. IMPALA-5038: Fix file size regex to include bytes There is a regex to remove file sizes fro

[Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5038: Fix file size regex to include bytes .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6288 To unsubscribe, visi

[Impala-ASF-CR] IMPALA-4711: clarify is null semantics in udf.h

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6311 Change subject: IMPALA-4711: clarify is_null semantics in udf.h .. IMPALA-4711: clarify is_null semantics in udf.h This is to reduce the

[native-toolchain-CR](cdh5.11.0) IMPALA-5025: upgrade to binutils 2.26.1

2017-03-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5025: upgrade to binutils 2.26.1 .. Patch Set 1: Code-Review+2 Have you tested this builds correctly on this branch (as opposed to master) ? -- To view

[native-toolchain-CR](cdh5.11.0) IMPALA-5025: upgrade to binutils 2.26.1

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6310 Change subject: IMPALA-5025: upgrade to binutils 2.26.1 .. IMPALA-5025: upgrade to binutils 2.26.1 This has two fixes that we care about

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-07 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5816 to look at the new patch set (#10). Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-03-07 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#4). Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT .. IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT No reason not to allow this. Rather

[Impala-ASF-CR] IMPALA-4925: Cancel finstance if query has finished

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4925: Cancel finstance if query has finished .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5987/1/be/src/runtime/coordinator.cc File be

[Impala-ASF-CR] IMPALA-4925: Cancel finstance if query has finished

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4925: Cancel finstance if query has finished .. Patch Set 1: (2 comments) The code change makes sense now that I've wrapped my head around it. Can we ad

[Impala-ASF-CR] IMPALA-3748: estimate minimum buffers in planner

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: estimate minimum buffers in planner .. Patch Set 7: As discussed offline, I went ahead and implemented the second planned patchset. The minimum buf

[Impala-ASF-CR] IMPALA-3748: estimate minimum buffers in planner

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-3748: estimate minimum buffers in planner .. IMPALA-3748: estimate minimum buffers in planner Compute the minimum buffer requirement for spilling nodes and

[Impala-ASF-CR] IMPALA-5028: Lock table in /catalog objects endpoint.

2017-03-07 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#3). Change subject: IMPALA-5028: Lock table in /catalog_objects endpoint. .. IMPALA-5028: Lock table in /catalog_objects endpoint. There was a missing lock acquisition before Table.toThri

[Impala-ASF-CR] IMPALA-5028: Lock table in /catalog objects endpoint.

2017-03-07 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-5028: Lock table in /catalog_objects endpoint. .. IMPALA-5028: Lock table in /catalog_objects endpoint. There was a missing lock acquisition before Table.toThri

[Impala-ASF-CR] IMPALA-5028: Lock table in /catalog objects endpoint.

2017-03-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5028: Lock table in /catalog_objects endpoint. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6296/1/tests/webserver/test_web_pages.py File

[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal.

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6069 To unsubscrib

[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal.

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. .. IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involve

[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal.

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. .. Patch Set 6: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/64/ -- To

[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal.

2017-03-07 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. .. Patch Set 6: Code-Review+2 Previous comment was on wrong patch set, all looks good now. -- To view,

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. .. IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upst

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-docs

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs.

2017-03-07 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6067

[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal.

2017-03-07 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6069/3//COMMIT_MSG Commit Message: PS3,

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal .. IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal Removed references to "Clou

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6083 To unsubscrib

[Impala-ASF-CR] IMPALA-5039: Fix variability in parquet dictionary filtering test

2017-03-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6301 Change subject: IMPALA-5039: Fix variability in parquet dictionary filtering test .. IMPALA-5039: Fix variability in parquet dictionary

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/62/ -- To

[Impala-ASF-CR] IMPALA-3748: estimate minimum buffers in plann

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-3748: estimate minimum buffers in plann .. IMPALA-3748: estimate minimum buffers in plann Compute the minimum buffer requirement for spilling nodes and per-

[Impala-ASF-CR] IMPALA-3748: estimate minimum buffers in planner

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-3748: estimate minimum buffers in planner .. IMPALA-3748: estimate minimum buffers in planner Compute the minimum buffer requirement for spilling nodes and

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal

2017-03-07 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal .. Patch Set 3: Code-Review+2 That's the charm. -- To view, visit http://gerrit.cloudera.org:8080/6083

[Impala-ASF-CR] IMPALA-5021: Fix count(*) remaining rows overflow in Parquet.

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5021: Fix count(*) remaining rows overflow in Parquet. .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/355/

[Impala-ASF-CR] IMPALA-5021: Fix count(*) remaining rows overflow in Parquet.

2017-03-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5021: Fix count(*) remaining rows overflow in Parquet. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6286 To unsubscribe, v

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#9). Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool Add a copy of BufferedTupleStream that a

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. Patch Set 8: (19 comments) http://gerrit.cloudera.org:8080/#/c/5811/8/be/src/runtime/buffered-tup

[Impala-ASF-CR] IMPALA-5027: addendum - remove unneeded #define

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5027: addendum - remove unneeded #define .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/354/ -- To view,

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#14). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as AP

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 13: (5 comments) http://gerrit.cloudera.org:8080/#/c/6025/13/be/src/exprs/aggregate-functions-

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-07 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#14). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage ..

[Impala-ASF-CR] IMPALA-4725: Query option to control Parquet array resolution.

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4725: Query option to control Parquet array resolution. .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/353/

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-07 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#14). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage ..

[Impala-ASF-CR] IMPALA-4725: Query option to control Parquet array resolution.

2017-03-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4725: Query option to control Parquet array resolution. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6250 To unsubscribe,

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-07 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#14). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage ..

[Impala-ASF-CR] IMPALA-4725: Query option to control Parquet array resolution.

2017-03-07 Thread Alex Behm (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6250 to look at the new patch set (#3). Change subject: IMPALA-4725: Query option to control Parquet array resolution. .. I

[Impala-ASF-CR] IMPALA-4725: Query option to control Parquet array resolution.

2017-03-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4725: Query option to control Parquet array resolution. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6250/2/be/src/exec/parquet-metadata-u

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/352/ -- To view, vi

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-03-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 4: Code-Review+2 Rebase and keep Henry's +2 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-5027: addendum - remove unneeded #define

2017-03-07 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5027: addendum - remove unneeded #define .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6298 To unsubscribe, visit http://ge

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-03-07 Thread Dimitris Tsirogiannis (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6013 to look at the new patch set (#4). Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. IMPALA-4885:

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-03-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6013/3/be/src/util/thread.cc File be/src/

[Impala-ASF-CR] IMPALA-5025: Update binutils to 2.26.1

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6287 Change subject: IMPALA-5025: Update binutils to 2.26.1 .. IMPALA-5025: Update binutils to 2.26.1 This release includes the fix for IMPAL

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal

2017-03-07 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal .. Patch Set 2: John--I removed the sections that you requested. Please take another look. Thanks. -- T

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal

2017-03-07 Thread Laurel Hale (Code Review)
Laurel Hale has uploaded a new patch set (#3). Change subject: IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal .. IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal Removed references to "Cloudera Manager" mostly

[Impala-ASF-CR] IMPALA-3401 [DOCS] Part2 Removing 'Cloudera Manager' from upstream docs.

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Part2 Removing 'Cloudera Manager' from upstream docs. .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6

[Impala-ASF-CR] IMPALA-3401 [DOCS] Part2 Removing 'Cloudera Manager' from upstream docs.

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3401 [DOCS] Part2 Removing 'Cloudera Manager' from upstream docs. .. IMPALA-3401 [DOCS] Part2 Removing 'Cloudera Manager' from upstream d

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-07 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#14). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage ..

[Impala-ASF-CR] IMPALA-5027: make udf headers buildable externally

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5027: make udf headers buildable externally .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6251/1/be/src/udf/udf.h File be/src/udf/udf.h

[Impala-ASF-CR] IMPALA-5027: addendum - remove unneeded #define

2017-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6298 Change subject: IMPALA-5027: addendum - remove unneeded #define .. IMPALA-5027: addendum - remove unneeded #define Change-Id: I8b460fc69

[Impala-ASF-CR] IMPALA-3401 [DOCS] Part2 Removing 'Cloudera Manager' from upstream docs.

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Part2 Removing 'Cloudera Manager' from upstream docs. .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-su

[Impala-ASF-CR] IMPALA-3401 [DOCS] Part2 Removing 'Cloudera Manager' from upstream docs.

2017-03-07 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Part2 Removing 'Cloudera Manager' from upstream docs. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6064 To

[Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5038: Fix file size regex to include bytes .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/350/ -- To view

[Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes

2017-03-07 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5038: Fix file size regex to include bytes .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6288 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes

2017-03-07 Thread Joe McDonnell (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6288 to look at the new patch set (#2). Change subject: IMPALA-5038: Fix file size regex to include bytes .. IMPALA-

[Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes

2017-03-07 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5038: Fix file size regex to include bytes .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6288 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes

2017-03-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5038: Fix file size regex to include bytes .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6288/1//COMMIT_MSG Commit Message: Line 9: T

[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references

2017-03-07 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references .. Patch Set 1: (6 comments) Most of this looks great, but I was a little confused about your intended

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal

2017-03-07 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal .. Patch Set 2: (2 comments) Please switch the 2 instances of conflict resolution where material that I

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6108 To unsubscrib

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal .. IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal Removed the topic "impala_h

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal

2017-03-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/60/ -- To

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal

2017-03-07 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6108 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-03-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 3: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/6013/3/be/src/util/thread.cc File

[Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes

2017-03-07 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5038: Fix file size regex to include bytes .. Patch Set 1: (3 comments) could you also fix up the contaminated tests as part of this? http://gerrit.c

[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references

2017-03-07 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references .. Patch Set 1: (19 comments) http://gerrit.cloudera.org:8080/#/c/6267/1/docs/shared/impala_common.xml

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2017-03-07 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/5115 To unsubscribe, visit http:

  1   2   >