[Impala-ASF-CR] Pass build type to Impala LZO.

2017-03-20 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/6446 Change subject: Pass build type to Impala LZO. .. Pass build type to Impala LZO. Before, the build type used for Impala LZO was always

[Impala-ASF-CR] IMPALA-5088: Fix heap buffer overflow

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5088: Fix heap buffer overflow .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/401/ -- To view, visit

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 20: (2 comments) http://gerrit.cloudera.org:8080/#/c/5816/19/be/src/exec/union-node.cc File

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0) .. IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0) Change-Id:

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0) .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6436 To

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#20). Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement union passthrough The union node acts as pass through operator and forwards row batches

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. IMPALA-5072: Fix test_recover_partitions on S3 On S3, directory creation is a nop, so we have

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-20 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5816 to look at the new patch set (#20). Change subject: IMPALA-3586: Implement union passthrough ..

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6408 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 19: (14 comments) http://gerrit.cloudera.org:8080/#/c/5816/19/be/src/exec/union-node.cc File

[Impala-ASF-CR] IMPALA-3203: Part 1: Free list implementation

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3203: Part 1: Free list implementation .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6410 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3203: Part 1: Free list implementation

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3203: Part 1: Free list implementation .. IMPALA-3203: Part 1: Free list implementation We will have a single free list per size class.

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-20 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5816 to look at the new patch set (#20). Change subject: IMPALA-3586: Implement union passthrough ..

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/5816/19/be/src/exec/union-node.cc File

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-20 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: [DOCS] Replace LZO setup instructions with placeholder .. Patch Set 3: Code-Review+1 Builds cleanly and renders well in both html & pdf. -- To view, visit

[Impala-ASF-CR] [DOCS] Genericize references to ODBC driver versions

2017-03-20 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: [DOCS] Genericize references to ODBC driver versions .. Patch Set 1: Code-Review+1 Builds cleanly and changes render well in both HTML & PDF. I agree with Jim

[Impala-ASF-CR] IMPALA-5088: Fix heap buffer overflow

2017-03-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5088: Fix heap buffer overflow .. Patch Set 2: As if to prove the point about this not just being a hypothetical bug, I just hit this, in unison, on

[Impala-ASF-CR] IMPALA-5088: Fix heap buffer overflow

2017-03-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5088: Fix heap buffer overflow .. Patch Set 2: Code-Review+2 Thanks for the review, Tim. Updated the commit message to mention the commit that

[Impala-ASF-CR] IMPALA-5088: Fix heap buffer overflow

2017-03-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-5088: Fix heap buffer overflow .. IMPALA-5088: Fix heap buffer overflow In a recent patch (IMPALA-4787), we introduced a change where we are reading

[Impala-ASF-CR] IMPALA-5088: Fix heap buffer overflow

2017-03-20 Thread Taras Bobrovytsky (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6441 to look at the new patch set (#2). Change subject: IMPALA-5088: Fix heap buffer overflow .. IMPALA-5088: Fix heap

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 19: (14 comments) nice cleanup http://gerrit.cloudera.org:8080/#/c/5816/19/be/src/exec/union-node.cc File

[Impala-ASF-CR] IMPALA-5088: Fix heap buffer overflow

2017-03-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5088: Fix heap buffer overflow .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6441 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5088: Fix heap buffer overflow

2017-03-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/6441 Change subject: IMPALA-5088: Fix heap buffer overflow .. IMPALA-5088: Fix heap buffer overflow In a recent patch, we introduced a

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views

2017-03-20 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#6). Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. IMPALA-5003: Constant propagation in scan nodes and inline views When conjuncts are pushed into

[Impala-ASF-CR] [DOCS] Genericize references to ODBC driver versions

2017-03-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: [DOCS] Genericize references to ODBC driver versions .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6440/1/docs/topics/impala_ports.xml File

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

2017-03-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0) .. Patch Set 2: Code-Review+2 Seems reasonable so long as it doesn't conflict with other in-flight

[Impala-ASF-CR] PREVIEW: IMPALA-4678: port backend exec to use buffer pool

2017-03-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: PREVIEW: IMPALA-4678: port backend exec to use buffer pool .. PREVIEW: IMPALA-4678: port backend exec to use buffer pool Always create global BufferPool at

[Impala-ASF-CR] PREVIEW: IMPALA-4678: port backend exec to use buffer pool

2017-03-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: PREVIEW: IMPALA-4678: port backend exec to use buffer pool .. PREVIEW: IMPALA-4678: port backend exec to use buffer pool Always create global BufferPool at

[Impala-ASF-CR] IMPALA-5003: Generic constant propagation in planner

2017-03-20 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Generic constant propagation in planner .. Patch Set 3: (12 comments) I'll post a WIP update to this diff as there was some refactoring that turned

[Impala-ASF-CR] IMPALA-4914,IMPALA-4999: remove flaky TestSpillStress

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4914,IMPALA-4999: remove flaky TestSpillStress .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6437 To unsubscribe,

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0) .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/400/ --

[Impala-ASF-CR] IMPALA-4914,IMPALA-4999: remove flaky TestSpillStress

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4914,IMPALA-4999: remove flaky TestSpillStress .. IMPALA-4914,IMPALA-4999: remove flaky TestSpillStress The test does not work as

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

2017-03-20 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6436 to look at the new patch set (#2). Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

[Impala-ASF-CR] IMPALA-4846: Upgrade Snappy to 1.1.4

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4846: Upgrade Snappy to 1.1.4 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6428 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4846: Upgrade Snappy to 1.1.4

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4846: Upgrade Snappy to 1.1.4 .. IMPALA-4846: Upgrade Snappy to 1.1.4 Change-Id: I2f3439019ae22bbcf4db7f731e45ba5f7899fcc2 Reviewed-on:

[Impala-ASF-CR] Bump Kudu client version to 16dd6e4

2017-03-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Bump Kudu client version to 16dd6e4 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6423 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/399/ -- To view,

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 3: Sorry for noise. Somehow two Gerrit jobs started. -- To view, visit

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 3: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/398/ --

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 3: Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/397/ -- To view,

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/397/ -- To view,

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/398/ -- To view,

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 3: Yes, Michael, if you could start a build, that should unbreak S3 tests. :) -- To view, visit

[Impala-ASF-CR] Allow BlockingQueue and ThreadPool to accept rvalue args

2017-03-20 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6442 Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args .. Allow BlockingQueue and ThreadPool to accept rvalue args

[Impala-ASF-CR] IMPALA-3203: Part 1: Free list implementation

2017-03-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3203: Part 1: Free list implementation .. Patch Set 10: Code-Review+2 Missed updating benchmark-test to reflect the change in optional arguments -- To

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-03-20 Thread Zach Amsden (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6261 to look at the new patch set (#8). Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

[Impala-ASF-CR] IMPALA-3203: Part 1: Free list implementation

2017-03-20 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Jim Apple, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6410 to look at the new patch set (#10). Change subject: IMPALA-3203: Part 1: Free list implementation

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

2017-03-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0) .. Patch Set 1: All the Kudu tests failed, not clear why one of the table servers failed to start.

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0) .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-03-20 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/6261/7//COMMIT_MSG Commit

[Impala-ASF-CR] [DOCS] Genericize references to ODBC driver versions

2017-03-20 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6440 Change subject: [DOCS] Genericize references to ODBC driver versions .. [DOCS] Genericize references to ODBC driver versions Make the

[Impala-ASF-CR] IMPALA-3203: Part 1: Free list implementation

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3203: Part 1: Free list implementation .. Patch Set 9: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/395/ --

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6408 To unsubscribe,

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 3: Zach, let me know if you would like a build started for this patch, and I can do it. -- To

[Impala-ASF-CR] [DOCS] Rewrite github URL for timezone source file

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] Rewrite github URL for timezone source file .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6438 To unsubscribe,

[Impala-ASF-CR] [DOCS] Rewrite github URL for timezone source file

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: [DOCS] Rewrite github URL for timezone source file .. [DOCS] Rewrite github URL for timezone source file Use the corresponding Apache github

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6408 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 3: Yes, updated diff attached. -- To view, visit http://gerrit.cloudera.org:8080/6408 To

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Zach Amsden (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6408 to look at the new patch set (#3). Change subject: IMPALA-5072: Fix test_recover_partitions on S3 ..

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-20 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-20 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 2: (10 comments)

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: [DOCS] Replace LZO setup instructions with placeholder .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6439/2/docs/topics/impala_txtfile.xml File

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: [DOCS] Replace LZO setup instructions with placeholder .. Patch Set 2: I thought the plan was to leave in as much as possible about LZO? -- To view, visit

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-20 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Replace LZO setup instructions with placeholder .. Patch Set 3: Patch set 2 = fix a stray 'cdh' inside the same impala_txtfile page. Patch set 3 = fix a

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-20 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#3). Change subject: [DOCS] Replace LZO setup instructions with placeholder .. [DOCS] Replace LZO setup instructions with placeholder An "under construction" banner since

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-20 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#2). Change subject: [DOCS] Replace LZO setup instructions with placeholder .. [DOCS] Replace LZO setup instructions with placeholder An "under construction" banner since

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-20 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Replace LZO setup instructions with placeholder .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6439/1/docs/topics/impala_txtfile.xml

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-20 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6439 Change subject: [DOCS] Replace LZO setup instructions with placeholder .. [DOCS] Replace LZO setup instructions with placeholder An

[Impala-ASF-CR] [DOCS] Rewrite github URL for timezone source file

2017-03-20 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: [DOCS] Rewrite github URL for timezone source file .. Patch Set 1: Code-Review+1 Builds cleanly, displays perfectly in both html & pdf. -- To view, visit

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#19). Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement union passthrough The union node acts as pass through operator and forwards row batches

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-20 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5816 to look at the new patch set (#19). Change subject: IMPALA-3586: Implement union passthrough ..

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 18: (5 comments) http://gerrit.cloudera.org:8080/#/c/5816/18/be/src/exec/union-node.h File

[Impala-ASF-CR] IMPALA-5031: Suppress noisy UBSAN errors from Thrift.

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5031: Suppress noisy UBSAN errors from Thrift. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6425 To unsubscribe,

[Impala-ASF-CR] IMPALA-5031: Suppress noisy UBSAN errors from Thrift.

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5031: Suppress noisy UBSAN errors from Thrift. .. IMPALA-5031: Suppress noisy UBSAN errors from Thrift. This suppresses a Thrift

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-20 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5816 to look at the new patch set (#19). Change subject: IMPALA-3586: Implement union passthrough ..

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-20 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5816 to look at the new patch set (#19). Change subject: IMPALA-3586: Implement union passthrough ..

[Impala-ASF-CR] [DOCS] Rewrite github URL for timezone source file

2017-03-20 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6438 Change subject: [DOCS] Rewrite github URL for timezone source file .. [DOCS] Rewrite github URL for timezone source file Use the

[Impala-ASF-CR] IMPALA-3203: Part 1: Free list implementation

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3203: Part 1: Free list implementation .. Patch Set 9: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/395/ -- To view,

[Impala-ASF-CR] IMPALA-3203: Part 1: Free list implementation

2017-03-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3203: Part 1: Free list implementation .. Patch Set 9: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/6410 To unsubscribe,

[Impala-ASF-CR] IMPALA-3203: Part 1: Free list implementation

2017-03-20 Thread Tim Armstrong (Code Review)
Hello Jim Apple, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6410 to look at the new patch set (#9). Change subject: IMPALA-3203: Part 1: Free list implementation ..

[Impala-ASF-CR] IMPALA-4914,IMPALA-4999: remove flaky TestSpillStress

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4914,IMPALA-4999: remove flaky TestSpillStress .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/394/ -- To

[Impala-ASF-CR] IMPALA-4846: Upgrade Snappy to 1.1.4

2017-03-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4846: Upgrade Snappy to 1.1.4 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6428 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4846: Upgrade Snappy to 1.1.4

2017-03-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4846: Upgrade Snappy to 1.1.4 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6428 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4846: Upgrade Snappy to 1.1.4

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4846: Upgrade Snappy to 1.1.4 .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/393/ -- To view, visit

[Impala-ASF-CR] IMPALA-4846: Upgrade Snappy to 1.1.4

2017-03-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4846: Upgrade Snappy to 1.1.4 .. Patch Set 1: With Snappy 1.1.3, that query against a 96 million row table took on average 6.1s. With Snappy 1.1.4,

[Impala-ASF-CR] IMPALA-3203: Part 1: Free list implementation

2017-03-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3203: Part 1: Free list implementation .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6410 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4914,IMPALA-4999: remove flaky TestSpillStress

2017-03-20 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4914,IMPALA-4999: remove flaky TestSpillStress .. Patch Set 2: Code-Review+2 Thanks for the commit message explaining better test alternatives. -- To

[Impala-ASF-CR] IMPALA-4914,IMPALA-4999: remove flaky TestSpillStress

2017-03-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4914,IMPALA-4999: remove flaky TestSpillStress .. IMPALA-4914,IMPALA-4999: remove flaky TestSpillStress The test does not work as intended and would likely

[Impala-ASF-CR] IMPALA-IMPALA-4914,IMPALA-4999: remove flaky TestSpillStress

2017-03-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6437 Change subject: IMPALA-IMPALA-4914,IMPALA-4999: remove flaky TestSpillStress .. IMPALA-IMPALA-4914,IMPALA-4999: remove flaky

[Impala-ASF-CR] IMPALA-4846: Upgrade Snappy to 1.1.4

2017-03-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4846: Upgrade Snappy to 1.1.4 .. Patch Set 1: I'll try and do this now. Because of the way the toolchain works, we can't get any other version changes

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0) .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/392/ --

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

2017-03-20 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6436 Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0) .. IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-03-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. IMPALA-4029: Reduce memory requirements for storing file metadata This commit

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-03-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 1: (15 comments) http://gerrit.cloudera.org:8080/#/c/6406/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 2: > Also, we might consider only creating data files on S3. It slows > down the tests on HDFS

[Impala-ASF-CR] IMPALA-3203: Part 1: Free list implementation

2017-03-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3203: Part 1: Free list implementation .. Patch Set 7: (3 comments)

[Impala-ASF-CR] IMPALA-3203: Part 1: Free list implementation

2017-03-20 Thread Tim Armstrong (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6410 to look at the new patch set (#8). Change subject: IMPALA-3203: Part 1: Free list implementation .. IMPALA-3203: Part

[Impala-ASF-CR] IMPALA-4846: Upgrade Snappy to 1.1.4

2017-03-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4846: Upgrade Snappy to 1.1.4 .. Patch Set 1: Can you do a quick benchmark to sanity-check the performance scanning compressed parquet? You can do

[Impala-ASF-CR] IMPALA-5031: Suppress noisy UBSAN errors from Thrift.

2017-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5031: Suppress noisy UBSAN errors from Thrift. .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/391/ -- To

  1   2   >