[Impala-ASF-CR] IMPALA-3748: minimum buffer requirements in planner

2017-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#14). Change subject: IMPALA-3748: minimum buffer requirements in planner .. IMPALA-3748: minimum buffer requirements in planner Compute the minimum buffer requirement for spilling

[Impala-ASF-CR] IMPALA-5073: Use mmap() instead of malloc() for buffer pool

2017-04-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5073: Use mmap() instead of malloc() for buffer pool .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-5124: add tests for scratch read errors

2017-04-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5124: add tests for scratch read errors .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6562 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4883: Union Codegen

2017-04-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4883: Union Codegen .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/6459/8/be/src/codegen/gen_ir_descriptions.py File

[Impala-ASF-CR] IMPALA-4883: Union Codegen

2017-04-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#9). Change subject: IMPALA-4883: Union Codegen .. IMPALA-4883: Union Codegen For each non-passthrough child of the Union node, codegen the loop that does per row tuple

[Impala-ASF-CR] IMPALA-4883: Union Codegen

2017-04-10 Thread Taras Bobrovytsky (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6459 to look at the new patch set (#9). Change subject: IMPALA-4883: Union Codegen .. IMPALA-4883: Union

[Impala-ASF-CR] IMPALA-4883: Union Codegen

2017-04-10 Thread Taras Bobrovytsky (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6459 to look at the new patch set (#9). Change subject: IMPALA-4883: Union Codegen .. IMPALA-4883: Union

[Impala-ASF-CR](asf-site) Add Impala docs from branch master, commit hash 68f32e52bc42bef578330a4fe0edc5b292891eea. This is the last commit made by JRussell in the cleanup project.

2017-04-10 Thread Laurel Hale (Code Review)
Laurel Hale has uploaded a new change for review. http://gerrit.cloudera.org:8080/6604 Change subject: Add Impala docs from branch master, commit hash 68f32e52bc42bef578330a4fe0edc5b292891eea. This is the last commit made by JRussell in the cleanup project.

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-04-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache .. Patch Set 3: (11 comments) initial thoughts on the partitioned map.

[Impala-ASF-CR] IMPALA-3040: Fix test caching ddl test

2017-04-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6603 Change subject: IMPALA-3040: Fix test_caching_ddl test .. IMPALA-3040: Fix test_caching_ddl test This commmit adds a 30sec

[Impala-ASF-CR] IMPALA-5184: build fe against both Hive 1 & 2 APIs

2017-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs .. Patch Set 7: (11 comments) http://gerrit.cloudera.org:8080/#/c/5538/7//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-5184: build fe against both Hive 1 & 2 APIs

2017-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs .. IMPALA-5184: build fe against both Hive 1 & 2 APIs This adds a compatibility shim layer with Hive 1 and Hive

[Impala-ASF-CR] IMPALA-4883: Union Codegen

2017-04-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4883: Union Codegen .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/6459/8/be/src/codegen/gen_ir_descriptions.py File

[Impala-ASF-CR] IMPALA-3748: minimum buffer requirements in planner

2017-04-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3748: minimum buffer requirements in planner .. Patch Set 13: (23 comments)

[Impala-ASF-CR] IMPALA-3973: optional 3rd and 4th arguments for instr().

2017-04-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3973: optional 3rd and 4th arguments for instr(). .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-3973: optional 3rd and 4th arguments for instr().

2017-04-10 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3973: optional 3rd and 4th arguments for instr(). .. Patch Set 2: (12 comments)

[Impala-ASF-CR] IMPALA-3973: optional 3rd and 4th arguments for instr().

2017-04-10 Thread John Russell (Code Review)
Hello Zoltan Ivanfi, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5589 to look at the new patch set (#4). Change subject: IMPALA-3973: optional 3rd and 4th arguments for instr(). ..

[Impala-ASF-CR] IMPALA-4883: Union Codegen

2017-04-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4883: Union Codegen .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6459 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3973: optional 3rd and 4th arguments for instr().

2017-04-10 Thread John Russell (Code Review)
Hello Zoltan Ivanfi, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5589 to look at the new patch set (#3). Change subject: IMPALA-3973: optional 3rd and 4th arguments for instr(). ..

[Impala-ASF-CR] IMPALA-5031: Remove undefined behavior: left shift of large signed

2017-04-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5031: Remove undefined behavior: left shift of large signed .. Patch Set 2: There are 16 open blocker bugs right now, so I'm going to hold off on

[Impala-ASF-CR](asf-site) First publishing of Apache Impala (incubating) documentation to the Apache web site.

2017-04-10 Thread Laurel Hale (Code Review)
Laurel Hale has abandoned this change. Change subject: First publishing of Apache Impala (incubating) documentation to the Apache web site. .. Abandoned There were a couple problems with the publish procedure I followed so

[Impala-ASF-CR] IMPALA-4883: Union Codegen

2017-04-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#8). Change subject: IMPALA-4883: Union Codegen .. IMPALA-4883: Union Codegen For each non-passthrough child of the Union node, codegen the loop that does per row tuple

[Impala-ASF-CR] IMPALA-4883: Union Codegen

2017-04-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4883: Union Codegen .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/6459/7/be/src/exec/union-node-ir.cc File

[Impala-ASF-CR] IMPALA-4883: Union Codegen

2017-04-10 Thread Taras Bobrovytsky (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6459 to look at the new patch set (#8). Change subject: IMPALA-4883: Union Codegen .. IMPALA-4883: Union Codegen For

[Impala-ASF-CR](asf-site) First publishing of Apache Impala (incubating) documentation to the Apache web site.

2017-04-10 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: First publishing of Apache Impala (incubating) documentation to the Apache web site. .. Patch Set 1: > (1 comment) I'm going to abandon this review because of

[Impala-ASF-CR](asf-site) First publishing of Apache Impala (incubating) documentation to the Apache web site.

2017-04-10 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: First publishing of Apache Impala (incubating) documentation to the Apache web site. .. Patch Set 1: > (1 comment) I'll abandon this review and start over. Will

[Impala-ASF-CR] IMPALA-5184: build fe against both Hive 1 & 2 APIs

2017-04-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs .. Patch Set 7: (9 comments) http://gerrit.cloudera.org:8080/#/c/5538/7//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5031: Remove undefined behavior: left shift of large signed

2017-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5031: Remove undefined behavior: left shift of large signed .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6528 To

[Impala-ASF-CR] [DOCS] Add placeholder for DECIMAL V2 query option

2017-04-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: [DOCS] Add placeholder for DECIMAL_V2 query option .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6596 To unsubscribe, visit

[Impala-ASF-CR] [DOCS] Add placeholder for DECIMAL V2 query option

2017-04-10 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: [DOCS] Add placeholder for DECIMAL_V2 query option .. Patch Set 2: Code-Review+1 lgtm -- To view, visit http://gerrit.cloudera.org:8080/6596 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-04-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 6: I will post a new patch once the draft has gotten further along. Please feel free to wait till then

[Impala-ASF-CR] IMPALA-5184: build fe against both Hive 1 & 2 APIs

2017-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs .. IMPALA-5184: build fe against both Hive 1 & 2 APIs This adds a compatibility shim layer with Hive 1 and Hive

[Impala-ASF-CR] IMPALA-4817: Populate Parquet Statistics for Strings

2017-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4817: Populate Parquet Statistics for Strings .. Patch Set 2: (7 comments) I had a few high-level comments/questions.

[Impala-ASF-CR](asf-site) First publishing of Apache Impala (incubating) documentation to the Apache web site.

2017-04-10 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: First publishing of Apache Impala (incubating) documentation to the Apache web site. .. Patch Set 1: (1 comment)

[Impala-ASF-CR](asf-site) First publishing of Apache Impala (incubating) documentation to the Apache web site.

2017-04-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: First publishing of Apache Impala (incubating) documentation to the Apache web site. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-04-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-4817: Populate Parquet Statistics for Strings

2017-04-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4817: Populate Parquet Statistics for Strings .. Patch Set 2: (15 comments)

[Impala-ASF-CR] IMPALA-4817: Populate Parquet Statistics for Strings

2017-04-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4817: Populate Parquet Statistics for Strings .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6563/2/common/thrift/parquet.thrift

[Impala-ASF-CR] IMPALA-3079: Fix sequence file writer

2017-04-10 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-3079: Fix sequence file writer .. Patch Set 6: (2 comments) Thanks for the review.

[Impala-ASF-CR] IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet

2017-04-10 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#6). Change subject: IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet .. IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet Before this

[Impala-ASF-CR] IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet

2017-04-10 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#6). Change subject: IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet .. IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet Before this

[Impala-ASF-CR] IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet

2017-04-10 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet

2017-04-10 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#6). Change subject: IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet .. IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet Before this

[Impala-ASF-CR] IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet

2017-04-10 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet .. Patch Set 5: (26 comments) Thanks for the review.

[Impala-ASF-CR] IMPALA-4817: Populate Parquet Statistics for Strings

2017-04-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4817: Populate Parquet Statistics for Strings .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6563/2/common/thrift/parquet.thrift File

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-04-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 3: (3 comments)

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-10 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: > > > @Matthew: Would you be needing the ppc64le infra for temporary > > > usage to test the

[Impala-ASF-CR] IMPALA-4883: Union Codegen

2017-04-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4883: Union Codegen .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6459/7/be/src/exec/union-node-ir.cc File be/src/exec/union-node-ir.cc: