[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new change for review. http://gerrit.cloudera.org:8080/6651 Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. IMPALA-4943: Speed up block md

[Impala-ASF-CR] IMPALA-5198: Error messages are sometimes dropped before reaching client

2017-04-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5198: Error messages are sometimes dropped before reaching client .. Patch Set 3: (5 comments) Running a private test to make sure none of the tests

[Impala-ASF-CR] IMPALA-5198: Error messages are sometimes dropped before reaching client

2017-04-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#4). Change subject: IMPALA-5198: Error messages are sometimes dropped before reaching client .. IMPALA-5198: Error messages are sometimes dropped before reaching client The

[Impala-ASF-CR] [DOCS] Mention Kerberos and TLS for Kudu security

2017-04-14 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [DOCS] Mention Kerberos and TLS for Kudu security .. Patch Set 1: The link will be https://kudu.apache.org/docs/security.html, but it's not published quite yet.

[Impala-ASF-CR] IMPALA-5198: Error messages are sometimes dropped before reaching client

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5198: Error messages are sometimes dropped before reaching client .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-5159: Optimze predicates

2017-04-14 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/6650 Change subject: IMPALA-5159: Optimze predicates .. IMPALA-5159: Optimze predicates In addition to propagating constants, we can infer

[Impala-ASF-CR] IMPALA-2800: make memory maintenance less aggressive

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-2800: make memory maintenance less aggressive .. Patch Set 4: Code-Review+1 Thanks for doing this -- To view, visit

[Impala-ASF-CR] [DOCS] Mention Kerberos and TLS for Kudu security

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [DOCS] Mention Kerberos and TLS for Kudu security .. Patch Set 1: (1 comment) lets wait to hear from JD/Dan about the right link

[Impala-ASF-CR] [DOCS] Mention Kerberos and TLS for Kudu security

2017-04-14 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Mention Kerberos and TLS for Kudu security .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6634/1/docs/shared/impala_common.xml File

[Impala-ASF-CR] [DOCS] Mention Kerberos and TLS for Kudu security

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [DOCS] Mention Kerberos and TLS for Kudu security .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6634/1/docs/shared/impala_common.xml File

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-04-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 4: (12 comments) http://gerrit.cloudera.org:8080/#/c/6535/4/be/src/runtime/coordinator-backend-state.cc

[Impala-ASF-CR] IMPALA-2924: [DOCS] Add docs for HDFS cache-related hints

2017-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-2924: [DOCS] Add docs for HDFS cache-related hints .. IMPALA-2924: [DOCS] Add docs for HDFS cache-related hints The JIRA discusses a

[Impala-ASF-CR] IMPALA-2924: [DOCS] Add docs for HDFS cache-related hints

2017-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2924: [DOCS] Add docs for HDFS cache-related hints .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6631 To

[Impala-ASF-CR] IMPALA-3040: Fix test caching ddl test

2017-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3040: Fix test_caching_ddl test .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6603 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3040: Fix test caching ddl test

2017-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3040: Fix test_caching_ddl test .. IMPALA-3040: Fix test_caching_ddl test This commmit adds a 30sec timeout on the validation step of

[Impala-ASF-CR] IMPALA-2924: [DOCS] Add docs for HDFS cache-related hints

2017-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2924: [DOCS] Add docs for HDFS cache-related hints .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/111/ --

[Impala-ASF-CR] IMPALA-2924: [DOCS] Add docs for HDFS cache-related hints

2017-04-14 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-2924: [DOCS] Add docs for HDFS cache-related hints .. Patch Set 3: Code-Review+2 Promoting to master, then will cherry-pick to downstream CDH docs. --

[Impala-ASF-CR] IMPALA-2924: [DOCS] Add docs for HDFS cache-related hints

2017-04-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2924: [DOCS] Add docs for HDFS cache-related hints .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6631 To unsubscribe,

[Impala-ASF-CR] IMPALA-2924: [DOCS] Add docs for HDFS cache-related hints

2017-04-14 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#3). Change subject: IMPALA-2924: [DOCS] Add docs for HDFS cache-related hints .. IMPALA-2924: [DOCS] Add docs for HDFS cache-related hints The JIRA discusses a RANDOM_REPLICA query

[Impala-ASF-CR] IMPALA-2924: [DOCS] Add docs for HDFS cache-related hints

2017-04-14 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-2924: [DOCS] Add docs for HDFS cache-related hints .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6631/2/docs/topics/impala_hints.xml

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-04-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5080: OutOfMemory PermGen space .. Patch Set 2: Code-Review+2 (1 comment) Thanks for investigating and fixing!

[Impala-ASF-CR] [DOCS] Mention Kerberos and TLS for Kudu security

2017-04-14 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: [DOCS] Mention Kerberos and TLS for Kudu security .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6634 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-04-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5080: OutOfMemory PermGen space .. Patch Set 2: (1 comment) > (1 comment) > > Have you tried Bharath's URLClassLoader.close() suggestion?

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-04-14 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6642 to look at the new patch set (#2). Change subject: IMPALA-5080: OutOfMemory PermGen space .. IMPALA-5080:

[Impala-ASF-CR] [DOCS] Remove references to DSSD storage appliance

2017-04-14 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Remove references to DSSD storage appliance .. Patch Set 1: This is more of a marketing-related change, so I'll make it in downstream docs but not

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-04-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5080: OutOfMemory PermGen space .. Patch Set 1: (1 comment) Have you tried Bharath's URLClassLoader.close() suggestion?

[Impala-ASF-CR] IMPALA-5085: large rows in BufferedTupleStreamV2

2017-04-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5085: large rows in BufferedTupleStreamV2 .. IMPALA-5085: large rows in BufferedTupleStreamV2 The stream defaults to pages of default_page_len_. If a row

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5080: OutOfMemory PermGen space .. Patch Set 1: Code-Review+1 (1 comment) Thanks for your work on this Thomas, I think this looks like a reasonable

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-1726: Treat parquet ENUMs as STRINGs when creating tables.

2017-04-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1726: Treat parquet ENUMs as STRINGs when creating tables. .. Patch Set 1: Hey Jakub. Have you had time to think about how we could test this? Let me know

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. IMPALA-5147: Add the ability to exclude hosts from query execution This commit

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 1: (15 comments)

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-04-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/6642 Change subject: IMPALA-5080: OutOfMemory PermGen space .. IMPALA-5080: OutOfMemory PermGen space The problem is that over time

[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. Patch Set 4: Perf results from running on the 10 node cluster: For smaller queries that we

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-04-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 4: (41 comments) Some more comments. Still going through the QueryState code and need to do more passes

[native-toolchain-CR] IMPALA-5187: Bump breakpad version for Breakpad bug #681

2017-04-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5187: Bump breakpad version for Breakpad bug #681 .. Patch Set 2: Code-Review-2 I just noticed that the build fails on CentOS 5. The reason seems to be

[Impala-ASF-CR] IMPALA-2800: make memory maintenance less aggressive

2017-04-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2800: make memory maintenance less aggressive .. Patch Set 3: (2 comments) Did some additional testing and added the description to the commit msg.

[Impala-ASF-CR] IMPALA-2800: make memory maintenance less aggressive

2017-04-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-2800: make memory maintenance less aggressive .. IMPALA-2800: make memory maintenance less aggressive Memory maintenance isn't necessary for correctness -

[native-toolchain-CR] IMPALA-5187: Bump breakpad version for Breakpad bug #681

2017-04-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5187: Bump breakpad version for Breakpad bug #681 .. Patch Set 2: > why don't we need > 0002-Increase-maximum-number-of-threads-for-minidump_stac.patch >

[native-toolchain-CR] IMPALA-5187: Bump breakpad version for Breakpad bug #681

2017-04-14 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-5187: Bump breakpad version for Breakpad bug #681 .. IMPALA-5187: Bump breakpad version for Breakpad bug #681 Breakpad had an issue [1] with random GUID

[Impala-ASF-CR] IMPALA-4893: Efficiently update the rows read counter for sequence file

2017-04-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4893: Efficiently update the rows read counter for sequence file .. Patch Set 6: Code-Review+2 We've had some build stability issues. I'm going to hold

[Impala-ASF-CR] IMPALA-4893: Efficiently update the rows read counter for sequence file

2017-04-14 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-4893: Efficiently update the rows read counter for sequence file .. Patch Set 6: (1 comment) Moed the set NUM_NODES=1 option from the

[Impala-ASF-CR] IMPALA-4893: Efficiently update the rows read counter for sequence file

2017-04-14 Thread anujphadke (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6522 to look at the new patch set (#6). Change subject: IMPALA-4893: Efficiently update the rows read counter for sequence file

[Impala-ASF-CR] IMPALA-3040: Fix test caching ddl test

2017-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3040: Fix test_caching_ddl test .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/455/ -- To view, visit

[Impala-ASF-CR] IMPALA-5198: Error messages are sometimes dropped before reaching client

2017-04-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5198: Error messages are sometimes dropped before reaching client .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5198: Error messages are sometimes dropped before reaching client

2017-04-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#3). Change subject: IMPALA-5198: Error messages are sometimes dropped before reaching client .. IMPALA-5198: Error messages are sometimes dropped before reaching client The

[Impala-ASF-CR] IMPALA-5198: Error messages are sometimes dropped before reaching client

2017-04-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5198: Error messages are sometimes dropped before reaching client .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6627/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-5198: Error messages are sometimes dropped before reaching client

2017-04-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: IMPALA-5198: Error messages are sometimes dropped before reaching client .. IMPALA-5198: Error messages are sometimes dropped before reaching client The

[native-toolchain-CR] IMPALA-5187: Bump breakpad version for Breakpad bug #681

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5187: Bump breakpad version for Breakpad bug #681 .. Patch Set 1: why don't we need 0002-Increase-maximum-number-of-threads-for-minidump_stac.patch

[Impala-ASF-CR] [DOCS] Mention Kerberos and TLS for Kudu security

2017-04-14 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: [DOCS] Mention Kerberos and TLS for Kudu security .. Patch Set 1: JD, Dan - Let us know when you have a link for the upstream Kudu security doc. -- To view,

[Impala-ASF-CR] [DOCS] Mention Kerberos and TLS for Kudu security

2017-04-14 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6634 Change subject: [DOCS] Mention Kerberos and TLS for Kudu security .. [DOCS] Mention Kerberos and TLS for Kudu security Link to Apache

[Impala-ASF-CR](asf-site) Change incubator logo, following edict from IPMC

2017-04-14 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: Change incubator logo, following edict from IPMC .. Change incubator logo, following edict from IPMC For the full set of new incubator logos, see:

[Impala-ASF-CR](asf-site) Change incubator logo, following edict from IPMC

2017-04-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Change incubator logo, following edict from IPMC .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6632 To unsubscribe, visit

[Impala-ASF-CR](asf-site) Change incubator logo, following edict from IPMC

2017-04-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Change incubator logo, following edict from IPMC .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6632/1//COMMIT_MSG Commit Message: PS1, Line 13:

[native-toolchain-CR] IMPALA-5187: Bump breakpad version for Breakpad bug #681

2017-04-14 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/6633 Change subject: IMPALA-5187: Bump breakpad version for Breakpad bug #681 .. IMPALA-5187: Bump breakpad version for Breakpad bug #681

[Impala-ASF-CR](asf-site) Change incubator logo, following edict from IPMC

2017-04-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Change incubator logo, following edict from IPMC .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6632/1//COMMIT_MSG Commit Message: PS1, Line

[Impala-ASF-CR](asf-site) Change incubator logo, following edict from IPMC

2017-04-14 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/6632 Change subject: Change incubator logo, following edict from IPMC .. Change incubator logo, following edict from IPMC For the full set of