[Impala-ASF-CR] IMPALA-5031: Remove undefined behavior "reference binding to null"

2017-06-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5031: Remove undefined behavior "reference binding to null" .. Patch Set 4: -Code-Review (1 comment) http://gerrit.cloudera.org:8080/#/c/7008/4/be/src/exe

[Impala-ASF-CR] IMPALA-5282: Handle overflows in computeResourceProfile().

2017-06-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). .. IMPALA-5282: Handle overflows in computeResourceProfile(). An overflow in computeR

[Impala-ASF-CR] IMPALA-5282: Handle overflows in computeResourceProfile().

2017-06-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7084 To unsubscr

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/7045/4/fe/src/main/java/o

[Impala-ASF-CR] IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables.

2017-06-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables. .. Patch Set 7: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerr

[Impala-ASF-CR] IMPALA-4859: [DOCS] Update example to show IS [NOT] NULL pushed to Kudu

2017-06-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4859: [DOCS] Update example to show IS [NOT] NULL pushed to Kudu .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/70

[Impala-ASF-CR] IMPALA-4859: [DOCS] Update example to show IS [NOT] NULL pushed to Kudu

2017-06-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4859: [DOCS] Update example to show IS [NOT] NULL pushed to Kudu .. IMPALA-4859: [DOCS] Update example to show IS [NOT] NULL pushed to Ku

[Impala-ASF-CR] IMPALA-4859: [DOCS] Update example to show IS [NOT] NULL pushed to Kudu

2017-06-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4859: [DOCS] Update example to show IS [NOT] NULL pushed to Kudu .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-sub

[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.

2017-06-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. IMPALA-5438: Always eval union const exprs in subplan. The bug was that the constant e

[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.

2017-06-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7091 To unsubscribe,

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6955/3/fe/src/main/java/org/apache/impala/analysis/Alt

[Impala-ASF-CR] IMPALA-5431: Remove redundant path exists check during table load

2017-06-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5431: Remove redundant path exists check during table load .. Patch Set 1: Seems fine to me, but there are way more exists() places that can be removed imo

[Impala-ASF-CR] PREVIEW: IMPALA-4674: port backend exec to use buffer pool

2017-06-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#17). Change subject: PREVIEW: IMPALA-4674: port backend exec to use buffer pool .. PREVIEW: IMPALA-4674: port backend exec to use buffer pool Always create global BufferPool at startu

[Impala-ASF-CR] PREVIEW: IMPALA-4703: reservation denial debug action

2017-06-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: PREVIEW: IMPALA-4703: reservation denial debug action .. PREVIEW: IMPALA-4703: reservation denial debug action This is a preview because it depends on the buffer p

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6955/3/fe/src/main/java/org/apache/impala/anal

[Impala-ASF-CR] IMPALA-5286: Kudu column name case cleanup

2017-06-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5286: Kudu column name case cleanup .. Patch Set 2: (6 comments) Is all of the special casing for "kudu case" and "impala case" in code that doesn't ca

[Impala-ASF-CR] IMPALA-1575: Yield admission control resources at query end

2017-06-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-1575: Yield admission control resources at query end .. Patch Set 1: Testing shows that the current approach doesn't work for mem_limit based admission c

[Impala-ASF-CR] IMPALA-5431: Remove redundant path exists check during table load

2017-06-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5431: Remove redundant path exists check during table load .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7095/1/

[Impala-ASF-CR] PREVIEW: IMPALA-4674: port backend exec to use buffer pool

2017-06-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: PREVIEW: IMPALA-4674: port backend exec to use buffer pool .. Patch Set 16: Fixed a bug found by a prototype of the reservation stress option: IMPALA-4703 -- T

[Impala-ASF-CR] PREVIEW: IMPALA-4674: port backend exec to use buffer pool

2017-06-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#16). Change subject: PREVIEW: IMPALA-4674: port backend exec to use buffer pool .. PREVIEW: IMPALA-4674: port backend exec to use buffer pool Always create global BufferPool at startu

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 3: (4 comments) Nice patch, though I still have a feeling the AlterColumnStmt/AlterTableChangeColStmt th

[Impala-ASF-CR] IMPALA-5431: Remove redundant path exists check during table load

2017-06-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new change for review. http://gerrit.cloudera.org:8080/7095 Change subject: IMPALA-5431: Remove redundant path exists check during table load .. IMPALA-5431: Remove redundant path exists ch

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-06 Thread Steve Carlin (Code Review)
Steve Carlin has uploaded a new patch set (#3). Change subject: IMPALA-4892: Session ID included in error message .. IMPALA-4892: Session ID included in error message Included the Session ID in the invalid session ID message. C

[Impala-ASF-CR] IMPALA-5031: Remove undefined behavior "reference binding to null"

2017-06-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5031: Remove undefined behavior "reference binding to null" .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7008 To unsubs

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-06 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. Patch Set 4: Alex / Dimitris - any further thoughts here? -- To view, visit http:

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-06 Thread Steve Carlin (Code Review)
Steve Carlin has uploaded a new patch set (#3). Change subject: IMPALA-4892: Session ID included in error message .. IMPALA-4892: Session ID included in error message Included the Session ID in the invalid session ID message. C

[Impala-ASF-CR] IMPALA-5315 Cast to timestamp fails for YYYY-M-D format

2017-06-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5315 Cast to timestamp fails for -M-D format .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7009/2/be/src/exprs/expr-test.cc File be/

[Impala-ASF-CR] Bump Kudu version for 1.4.0-RC1

2017-06-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: Bump Kudu version for 1.4.0-RC1 .. Bump Kudu version for 1.4.0-RC1 Change-Id: Icee687aa00e79274ecc1d53235f23253f8f338df Reviewed-on: http://gerrit.clou

[Impala-ASF-CR] Bump Kudu version for 1.4.0-RC1

2017-06-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Bump Kudu version for 1.4.0-RC1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7093 To unsubscribe, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-5316: Adds last day() function

2017-06-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5316: Adds last_day() function .. Patch Set 5: Code-Review+1 Nice work, thanks for doing this! Let's see if Marcel, Alex, or Dan want to check anything

[Impala-ASF-CR] IMPALA-5357: Fix unixtime to UTC TimestampValue perf

2017-06-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5357: Fix unixtime to UTC TimestampValue perf .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/691/ -- To v

[Impala-ASF-CR] IMPALA-5357: Fix unixtime to UTC TimestampValue perf

2017-06-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5357: Fix unixtime to UTC TimestampValue perf .. Patch Set 3: Code-Review+2 A few unrelated planner tests failed, seems unrelated and I can't repro it l

[Impala-ASF-CR] IMPALA-5282: Handle overflows in computeResourceProfile().

2017-06-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/690/ --

[Impala-ASF-CR] IMPALA-5282: Handle overflows in computeResourceProfile().

2017-06-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7084 To unsubscribe, visi

[Impala-ASF-CR] IMPALA-5282: Handle overflows in computeResourceProfile().

2017-06-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). .. Patch Set 3: Makes sense -- To view, visit http://gerrit.cloudera.org:8080/7084 To unsubscribe, v

[Impala-ASF-CR] IMPALA-5282: Handle overflows in computeResourceProfile().

2017-06-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). .. Patch Set 3: It's easy to add a test for this case specifically, but I'm thinking we should rather foc

[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test

2017-06-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5400: Execute tests in subplans.test .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7038/2/testdata/workloads/functional-query/queries/Quer

[Impala-ASF-CR] IMPALA-5282: Handle overflows in computeResourceProfile().

2017-06-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). .. Patch Set 3: Code-Review+1 The change looks good to me. It would be nice to have a regression test

[Impala-ASF-CR] IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables.

2017-06-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables. .. Patch Set 7: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-

[Impala-ASF-CR] IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables.

2017-06-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables. .. Patch Set 7: Code-Review+2 I did a minor edit to fix indentation in AnalyzeDDLTest.java

[Impala-ASF-CR] IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables.

2017-06-06 Thread Alex Behm (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6550 to look at the new patch set (#7). Change subject: IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables. ..

[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.

2017-06-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/688/ -- To

[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.

2017-06-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. Patch Set 3: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/7091 To unsubscribe,

[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.

2017-06-06 Thread Alex Behm (Code Review)
Hello anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7091 to look at the new patch set (#3). Change subject: IMPALA-5438: Always eval union const exprs in subplan. .

[Impala-ASF-CR] IMPALA-5282: Handle overflows in computeResourceProfile().

2017-06-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). .. Patch Set 3: Tim, any more comments on this patch? -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.

2017-06-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7091 To unsubscribe, visi

[Impala-ASF-CR] IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables.

2017-06-06 Thread Jakub Kukul (Code Review)
Jakub Kukul has posted comments on this change. Change subject: IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables. .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6550/4/testdata/workload

[Impala-ASF-CR] IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables.

2017-06-06 Thread Jakub Kukul (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6550 to look at the new patch set (#6). Change subject: IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables. ..

[Impala-ASF-CR] Bump Kudu version for 1.4.0-RC1

2017-06-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version for 1.4.0-RC1 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7093 To unsubscribe, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-5357: Fix unixtime to UTC TimestampValue perf

2017-06-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5357: Fix unixtime to UTC TimestampValue perf .. Patch Set 2: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/686/

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-06 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#7). Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. IMPALA-5388: Only retry RPC on lost connection in send call Previously, DoRpc() blacklists only a coupl

[Impala-ASF-CR] IMPALA-5316: Adds last day() function

2017-06-06 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#5). Change subject: IMPALA-5316: Adds last_day() function .. IMPALA-5316: Adds last_day() function This change adds last_day() function. The function takes exactly one TIMESTAMP argume

[Impala-ASF-CR] IMPALA-5316: Adds last day() function

2017-06-06 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5316: Adds last_day() function .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6991/4/be/src/exprs/timestamp-functions.h File be/src/exprs

[Impala-ASF-CR] IMPALA-5315 Cast to timestamp fails for YYYY-M-D format

2017-06-06 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#2). Change subject: IMPALA-5315 Cast to timestamp fails for -M-D format .. IMPALA-5315 Cast to timestamp fails for -M-D format This change allows casting of a string in 'lazy'

[Impala-ASF-CR] IMPALA-5315 Cast to timestamp fails for YYYY-M-D format

2017-06-06 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5315 Cast to timestamp fails for -M-D format .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7009/1/be/src/exprs/expr-test.cc File be

<    1   2