[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/6955/5/fe/src/main/java/org/apache/impala/analysis/AlterTa

[Impala-ASF-CR] IMPALA-5389: simplify BufferDescriptor lifetime

2017-06-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5389: simplify BufferDescriptor lifetime .. Patch Set 3: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/7182 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-5389: simplify BufferDescriptor lifetime

2017-06-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5389: simplify BufferDescriptor lifetime .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/741/ -- To view,

Re: [Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-15 Thread Alexander Behm
A bunch of PlannerTests failed, please fix. On Thu, Jun 15, 2017 at 10:20 PM, Impala Public Jenkins (Code Review) < ger...@cloudera.org> wrote: > Impala Public Jenkins has posted comments on this change. > > Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN > predicate >

[Impala-ASF-CR] IMPALA-5286/IMPALA-5283: Kudu column name case cleanup

2017-06-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5286/IMPALA-5283: Kudu column name case cleanup .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6902/3/fe/src/main/java/org/apa

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 7: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 5: Code-Review+1 (3 comments) Final nits. I'm happy with this patch. Dan should give the final +2 http://

[Impala-ASF-CR] IMPALA-4418: Fixes extra blank lines in query result

2017-06-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4418: Fixes extra blank lines in query result .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/740/ -- To v

[Impala-ASF-CR] IMPALA-4418: Fixes extra blank lines in query result

2017-06-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4418: Fixes extra blank lines in query result .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7055 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-4418: Fixes extra blank lines in query result

2017-06-15 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#4). Change subject: IMPALA-4418: Fixes extra blank lines in query result .. IMPALA-4418: Fixes extra blank lines in query result This change avoids printing blank lines when the Impala

[Impala-ASF-CR] IMPALA-5389: simplify BufferDescriptor lifetime

2017-06-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5389: simplify BufferDescriptor lifetime .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7182 To unsubscribe, visit http://ge

[Impala-ASF-CR] IMPALA-4418: Extra blank lines in query result

2017-06-15 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-4418: Extra blank lines in query result .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/7055/3//COMMIT_MSG Commit Message: Line 11: that

[Impala-ASF-CR] IMPALA-5085: large rows in BufferedTupleStreamV2

2017-06-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5085: large rows in BufferedTupleStreamV2 .. Patch Set 13: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6638/13/be/src/runtime/buffered-tupl

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Import kudu util library from kudu@314c9d8

2017-06-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Import kudu_util library from kudu@314c9d8 .. Patch Set 9: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-

[Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

2017-06-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC .. Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/5720/13/be/src/rpc/rpc.

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2017-06-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3504: UDF for current timestamp in UTC .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7203/1/be/src/exprs/expr-test.cc File be/src/exprs/exp

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-06-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/5715/15/be/src/kudu/util/logging.cc File

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 8: (1 comment) Any thoughts? http://gerrit.cloudera.org:8080/#/c/6963/8//COMMIT_M

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-06-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 15: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2017-06-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3504: UDF for current timestamp in UTC .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7203/1/be/src/exprs/expr-test.cc File be/src/expr

[Impala-ASF-CR] IMPALA-5085: large rows in BufferedTupleStreamV2

2017-06-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5085: large rows in BufferedTupleStreamV2 .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/6638/10/be/src/runtime/buffered-tuple-stream-v

[Impala-ASF-CR] IMPALA-5085: large rows in BufferedTupleStreamV2

2017-06-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#13). Change subject: IMPALA-5085: large rows in BufferedTupleStreamV2 .. IMPALA-5085: large rows in BufferedTupleStreamV2 The stream defaults to pages of default_page_len_. If a row d

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2017-06-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3504: UDF for current timestamp in UTC .. Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/7203/1/be/src/exprs/expr-test.cc File be/src/exp

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2017-06-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3504: UDF for current timestamp in UTC .. Patch Set 1: (15 comments) http://gerrit.cloudera.org:8080/#/c/7203/1/be/src/exprs/expr-test.cc File be/src/exprs/e

[Impala-ASF-CR] IMPALA-5286/IMPALA-5283: Kudu column name case cleanup

2017-06-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5286/IMPALA-5283: Kudu column name case cleanup .. Patch Set 3: (10 comments) http://gerrit.cloudera.org:8080/#/c/6902/2/common/thrift/CatalogOb

[Impala-ASF-CR] IMPALA-5286/IMPALA-5283: Kudu column name case cleanup

2017-06-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#4). Change subject: IMPALA-5286/IMPALA-5283: Kudu column name case cleanup .. IMPALA-5286/IMPALA-5283: Kudu column name case cleanup Impala is case insensitive for column nam

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 7: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/73

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 7: Code-Review+2 I fixed another indentation issue. -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-15 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#7). Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. IMPALA-5280: Coalesce chains of OR conditions to an IN predicate This change introduces a new rule

[Impala-ASF-CR] Add nested testdata flattener

2017-06-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: Add nested testdata flattener .. Add nested testdata flattener The TableFlattener takes a nested dataset and creates an equivalent unnested dataset. The unnest

[Impala-ASF-CR] Add nested testdata flattener

2017-06-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: Add nested testdata flattener .. Add nested testdata flattener The TableFlattener takes a nested dataset and creates an equivalent unnested dataset. The unnest

[Impala-ASF-CR] Add nested testdata flattener

2017-06-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: Add nested testdata flattener .. Patch Set 1: (14 comments) http://gerrit.cloudera.org:8080/#/c/5787/1//COMMIT_MSG Commit Message: Line 22: > How was this

[Impala-ASF-CR] IMPALA-3909: [DOCS] Add general info about Parquet min/max optimization

2017-06-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: [DOCS] Add general info about Parquet min/max optimization .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7068 To

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 4: (11 comments) http://gerrit.cloudera.org:8080/#/c/6812/4/be/src/exec/hdfs-parquet-scanner.cc Fi

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 5: (18 comments) > We should add an e2e test that exhaustively tests all combinations > of colum

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#5). Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. IMPALA-4622: Add ALTER COLUMN statement. Kudu recently added the ability to alter a column's default value and

[Impala-ASF-CR] IMPALA-3909: [DOCS] Add general info about Parquet min/max optimization

2017-06-15 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3909: [DOCS] Add general info about Parquet min/max optimization .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7068/2/docs/topics/impa

[Impala-ASF-CR] IMPALA-3909: [DOCS] Add general info about Parquet min/max optimization

2017-06-15 Thread John Russell (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7068 to look at the new patch set (#3). Change subject: IMPALA-3909: [DOCS] Add general info about Parquet min/max optimization .

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-06-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 15: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/738/ --

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-15 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 6: (2 comments) addressed comments. http://gerrit.cloudera.org:8080/#/c/7110

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-15 Thread sandeep akinapelli (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7110 to look at the new patch set (#6). Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate ..

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Import kudu util library from kudu@314c9d8

2017-06-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Import kudu_util library from kudu@314c9d8 .. Patch Set 9: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/737

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Import kudu util library from kudu@314c9d8

2017-06-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Import kudu_util library from kudu@314c9d8 .. Patch Set 9: Code-Review+2 Carry +2. -- To view, visit http://gerrit.cloudera.org:8080/5714

[Impala-ASF-CR] IMPALA-5497: spilling hash joins that output build rows hit OOM

2017-06-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5497: spilling hash joins that output build rows hit OOM .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7180/3/be/src/exec/partitioned-h

[Impala-ASF-CR] IMPALA-5497: spilling hash joins that output build rows hit OOM

2017-06-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-5497: spilling hash joins that output build rows hit OOM .. IMPALA-5497: spilling hash joins that output build rows hit OOM The bug is that the join tried t

[Impala-ASF-CR] IMPALA-5497: spilling hash joins that output build rows hit OOM

2017-06-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5497: spilling hash joins that output build rows hit OOM .. IMPALA-5497: spilling hash joins that output build rows hit OOM The bug is that the join tried t

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-06-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 5: Code-Review+2 Trying to refresh my memory but looks like we're ok to go forward once the comment

[Impala-ASF-CR] IMPALA-5389: simplify BufferDescriptor lifetime

2017-06-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5389: simplify BufferDescriptor lifetime .. Patch Set 2: Code-Review+1 Carry +1 -- To view, visit http://gerrit.cloudera.org:8080/7182 To unsubscribe, v

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6527 To unsubsc

[Impala-ASF-CR] IMPALA-5061: Populate null count in parquet::statistics

2017-06-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5061: Populate null_count in parquet::statistics .. IMPALA-5061: Populate null_count in parquet::statistics The null_count in the statist

[Impala-ASF-CR] IMPALA-5061: Populate null count in parquet::statistics

2017-06-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5061: Populate null_count in parquet::statistics .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7058 To unsubscrib

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-06-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 15: Code-Review+2 Please consider deleting minudmp.cc from the code base if that's feasible.

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-06-15 Thread Henry Robinson (Code Review)
Hello Matthew Jacobs, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5715 to look at the new patch set (#15). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ..

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-06-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/5715/14/be/src/common/config.h.in File b

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-06-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5715/13/be/src/kudu/util/minidump.cc

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-06-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5715/13/be/src/kudu/util/minidump.cc File

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-06-15 Thread Henry Robinson (Code Review)
Hello Matthew Jacobs, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5715 to look at the new patch set (#14). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ..

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-06-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/5715/13/be/src/common/logging.cc Fil

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-06-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/5715/13/be/src/common/logging.cc File be

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 5: Exhaustive build passed: http://sandbox.jenkins.cloudera.com/view/Impala/view/Privat

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2017-06-15 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new change for review. http://gerrit.cloudera.org:8080/7203 Change subject: IMPALA-3504: UDF for current timestamp in UTC .. IMPALA-3504: UDF for current timestamp in UTC This change adds a UDF "

[Impala-ASF-CR] IMPALA-5158: report buffer pool free memory in MemTracker

2017-06-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5158: report buffer pool free memory in MemTracker .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6993 To unsubscri

[Impala-ASF-CR] IMPALA-5158: report buffer pool free memory in MemTracker

2017-06-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5158: report buffer pool free memory in MemTracker .. IMPALA-5158: report buffer pool free memory in MemTracker Clean pages and free buff

[Impala-ASF-CR] IMPALA-3909: [DOCS] Add general info about Parquet min/max optimization

2017-06-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3909: [DOCS] Add general info about Parquet min/max optimization .. Patch Set 2: Code-Review+1 (2 comments) LGTM, only nits. http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-3909: [DOCS] Add general info about Parquet min/max optimization

2017-06-15 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3909: [DOCS] Add general info about Parquet min/max optimization .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7068/1/docs/topics/impa

[Impala-ASF-CR] IMPALA-3909: [DOCS] Add general info about Parquet min/max optimization

2017-06-15 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#2). Change subject: IMPALA-3909: [DOCS] Add general info about Parquet min/max optimization .. IMPALA-3909: [DOCS] Add general info about Parquet min/max optimization Just putting an

[Impala-ASF-CR] IMPALA-5517: Allow default IMPALA LOGS DIR to be explicity overridden

2017-06-15 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/7197 Change subject: IMPALA-5517: Allow default IMPALA_LOGS_DIR to be explicity overridden .. IMPALA-5517: Allow default IMPALA_LOGS_DIR to be

[Impala-ASF-CR] IMPALA-5061: Populate null count in parquet::statistics

2017-06-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5061: Populate null_count in parquet::statistics .. Patch Set 10: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/736/ --

[Impala-ASF-CR] IMPALA-5061: Populate null count in parquet::statistics

2017-06-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5061: Populate null_count in parquet::statistics .. Patch Set 10: Code-Review+2 Carrying Dan's +2 -- To view, visit http://gerrit.cloudera.org:8080/7058 T

[Impala-ASF-CR] IMPALA-5061: Populate null count in parquet::statistics

2017-06-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5061: Populate null_count in parquet::statistics .. Patch Set 9: Pooja, please rebase on latest master and push the rebased diff and then we can kick off the

[Impala-ASF-CR] IMPALA-5061: Populate null count in parquet::statistics

2017-06-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5061: Populate null_count in parquet::statistics .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7058 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds

2017-06-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7115 To uns

[Impala-ASF-CR] IMPALA-5061: Populate null count in parquet::statistics

2017-06-15 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. Change subject: IMPALA-5061: Populate null_count in parquet::statistics .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/7058/8/be/src/exec/parquet-column-st

[Impala-ASF-CR] IMPALA-5061: Populate null count in parquet::statistics

2017-06-15 Thread Pooja Nilangekar (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7058 to look at the new patch set (#9). Change subject: IMPALA-5061: Populate null_count in parquet::statistics .. IMPALA

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 5: Code-Review+2 (2 comments) Nice! Please address the final comments, rebase and uplo

[Impala-ASF-CR] IMPALA-5158: report buffer pool free memory in MemTracker

2017-06-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5158: report buffer pool free memory in MemTracker .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/735/ --

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-15 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 5: (4 comments) addressed review comments http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-15 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has uploaded a new patch set (#5). Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. IMPALA-5280: Coalesce chains of OR conditions to an IN predicate This change introduces a

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-06-15 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new patch set (#2). Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. IMPALA-5513: Fix display message exception when using invalid KEYVAL Function Print_to_stderr

[Impala-ASF-CR] IMPALA-5514: Add the joint judgment of ldap password cmd and ldap

2017-06-15 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new patch set (#2). Change subject: IMPALA-5514: Add the joint judgment of ldap_password_cmd and ldap .. IMPALA-5514: Add the joint judgment of ldap_password_cmd and ldap When only with ldap_password_c

[Impala-ASF-CR] IMPALA-5514: Add the joint judgment of ldap password cmd and ldap

2017-06-15 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new change for review. http://gerrit.cloudera.org:8080/7188 Change subject: IMPALA-5514: Add the joint judgment of ldap_password_cmd and ldap .. IMPALA-5514: Add the joint judgment of ldap_password_c

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-06-15 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new change for review. http://gerrit.cloudera.org:8080/7187 Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. IMPALA-5513: Fix display message exception when usi

[Impala-ASF-CR] IMPALA-5158: report buffer pool free memory in MemTracker

2017-06-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5158: report buffer pool free memory in MemTracker .. Patch Set 3: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun