[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 4: (3 comments) Nice cleanup! I don't have much to

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8334 ) Change subject: IMPALA-6060: Check the return value of JNI exception handling functions .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-4918: Support getting column comments via HS2

2017-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8315 ) Change subject: IMPALA-4918: Support getting column comments via HS2 .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4918: Support getting column comments via HS2

2017-10-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8315 ) Change subject: IMPALA-4918: Support getting column comments via HS2 .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. IMPALA-5789: Add always_false flag in bloom

[Impala-ASF-CR] IMPALA-6063: stress test: report test duration

2017-10-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8339 ) Change subject: IMPALA-6063: stress test: report test duration .. IMPALA-6063: stress test: report test duration At

[Impala-ASF-CR] IMPALA-6063: stress test: report test duration

2017-10-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8339 ) Change subject: IMPALA-6063: stress test: report test duration .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-19 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8146 to look at the new patch set (#10). Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. Patch Set 9: (4 comments)

[Impala-ASF-CR] IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

2017-10-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7822 ) Change subject: IMPALA-2494: Support for byte array encoded decimals in Parquet scanner .. Patch Set 5: (6 comments) Mostly just

[Impala-ASF-CR] IMPALA-5018: Error on decimal divide by and modulo zero

2017-10-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal divide by and modulo zero .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5018: Error on decimal divide by and modulo zero

2017-10-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal divide by and modulo zero .. Patch Set 1: (1 comment) I need to look at the other

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-19 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 18: Run of gerrit-verify-dryun-external

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-19 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 18: (5 comments)

[Impala-ASF-CR] IMPALA-5018: Error on decimal divide by and modulo zero

2017-10-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8344 Change subject: IMPALA-5018: Error on decimal divide by and modulo zero .. IMPALA-5018: Error on decimal divide by and modulo zero

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-19 Thread Tim Wood (Code Review)
Hello Matthew Mulder, Michael Brown, David Knupp, Alex Behm, Mostafa Mokhtar, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8102 to look at the new patch set (#18). Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-19 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8170 to look at the new patch set (#8). Change subject: IMPALA-5789: Add always_false flag in bloom filter

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-19 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-19 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8305 to look at the new patch set (#5). Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src.

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-19 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 4: > What about common-metrics.cc? > > And

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-10-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 8: (18 comments) Thank you for reworking

[Impala-ASF-CR] IMPALA-6063: stress test: report test duration

2017-10-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8339 ) Change subject: IMPALA-6063: stress test: report test duration .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6063: stress test: report test duration

2017-10-19 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8339 ) Change subject: IMPALA-6063: stress test: report test duration .. Patch Set 1: Code-Review+2 Your refactoring looks good to my eye,

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Patch Set 7: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-10-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 10: (5 comments)

[Impala-ASF-CR] IMPALA-6063: stress test: report test duration

2017-10-19 Thread Matthew Mulder (Code Review)
Matthew Mulder has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8339 Change subject: IMPALA-6063: stress test: report test duration .. IMPALA-6063: stress test: report test duration At the end of the

[Impala-ASF-CR] IMPALA-1422: support a constant on LHS of IN predicates.

2017-10-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8322 ) Change subject: IMPALA-1422: support a constant on LHS of IN predicates. .. Patch Set 3: latest patch handles analytic functions and

[Impala-ASF-CR] IMPALA-1422: support a constant on LHS of IN predicates.

2017-10-19 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8322 to look at the new patch set (#3). Change subject: IMPALA-1422: support a constant on LHS of IN predicates.

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-10-19 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8267 to look at the new patch set (#9). Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding ..

[Impala-ASF-CR] IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

2017-10-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/7822 ) Change subject: IMPALA-2494: Support for byte array encoded decimals in Parquet scanner .. Patch Set 4: (16 comments)

[Impala-ASF-CR] IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

2017-10-19 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Matthew Jacobs, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7822 to look at the new patch set (#5). Change subject: IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2017-10-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 9: (2 comments) > > (1 comment) > >

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2017-10-19 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7938 to look at the new patch set (#9). Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 4: What about common-metrics.cc? And then, I

[Impala-ASF-CR] IMPALA-6803: [DOCS] Clarify scope of STRAIGHT JOIN hint

2017-10-19 Thread John Russell (Code Review)
Hello Alex Behm, Mala Chikka Kempanna, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8336 to look at the new patch set (#3). Change subject: IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint

[Impala-ASF-CR] [DOCS] Clarify scope of STRAIGHT JOIN hint

2017-10-19 Thread John Russell (Code Review)
Hello Alex Behm, Mala Chikka Kempanna, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8336 to look at the new patch set (#2). Change subject: [DOCS] Clarify scope of STRAIGHT_JOIN hint ..

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-19 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8305 to look at the new patch set (#4). Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src.

[Impala-ASF-CR] [DOCS] Clarify scope of STRAIGHT JOIN hint

2017-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8336 ) Change subject: [DOCS] Clarify scope of STRAIGHT_JOIN hint .. Patch Set 1: (4 comments)

[Impala-ASF-CR] [DOCS] Clarify scope of STRAIGHT JOIN hint

2017-10-19 Thread John Russell (Code Review)
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8336 Change subject: [DOCS] Clarify scope of STRAIGHT_JOIN hint .. [DOCS] Clarify scope of STRAIGHT_JOIN hint Add some boilerplate wording

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-19 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8170 to look at the new patch set (#7). Change subject: IMPALA-5789: Add always_false flag in bloom filter

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-19 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8334 Change subject: IMPALA-6060: Check the return value of JNI exception handling functions .. IMPALA-6060: Check the return value of JNI

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 8: Verified-1 Code-Review+2 > (1 comment)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-19 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 10: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4918: Support getting column comments via HS2

2017-10-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8315 ) Change subject: IMPALA-4918: Support getting column comments via HS2 .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. Patch Set 9: (4 comments) Looks good

[Impala-ASF-CR] IMPALA-4918: Support getting column comments via HS2

2017-10-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8315 ) Change subject: IMPALA-4918: Support getting column comments via HS2 .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-19 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Michael Brown, Matthew Jacobs, Philip Zeyliger, anujphadke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#10). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-19 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-19 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Michael Brown, Matthew Jacobs, Philip Zeyliger, anujphadke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#9). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+

2017-10-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8274 ) Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+ .. Patch Set 4: Code-Review+2 Yeah I see there are some existing

[Impala-ASF-CR] IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+

2017-10-19 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8274 ) Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+ .. Patch Set 4: Looks like I finally got a good GVO on this. Tim,

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 8: (11 comments)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-19 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Michael Brown, Matthew Jacobs, Philip Zeyliger, anujphadke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#8). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-10-19 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8311 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-10-19 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8311 Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. IMPALA-5607: Add additional units to EXTRACT,

[Impala-ASF-CR] IMPALA-6073: Fail on misconfigured CLASSPATH.

2017-10-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8327 ) Change subject: IMPALA-6073: Fail on misconfigured CLASSPATH. .. Patch Set 1: > I think this check seems not to be enough. Let me leave a