[native-toolchain-CR] Fixes github Issues#23 "ARCH FLAGS: unbound variable" for mac

2017-10-23 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8356 ) Change subject: Fixes github Issues#23 "ARCH_FLAGS: unbound variable" for mac .. Patch Set 1: > Thanks Valencia! Thanks, Tim!

[native-toolchain-CR] Fixes github Issues#23 "ARCH FLAGS: unbound variable" for mac

2017-10-23 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8356 Change subject: Fixes github Issues#23 "ARCH_FLAGS: unbound variable" for mac .. Fixes github Issues#23 "ARCH_FLAGS: unbound varia

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-06-01 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 6: > Was able to run Impala exhaustive tests with this toolchain > version. > > Thanks Valenci

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-29 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 5: > nice! that's a good result. Thanks, Valencia. > > I have no other comments. Let's let Tim

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-26 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 5: (1 comment) Thanks, Matthew/Jim. http://gerrit.cloudera.org:8080/#/c/6468/5/source/breakpad/b

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-25 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 5: (3 comments) Thanks, Matthew! http://gerrit.cloudera.org:8080/#/c/6468/5/buildall.sh File bui

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-24 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 4: (1 comment) Thanks, Tim! I'd like to inform you that I've initialized the new CONFIGURE_FLAG_

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-24 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has uploaded a new patch set (#5). Change subject: Ported native-toolchain to work on ppc64le .. Ported native-toolchain to work on ppc64le Change-Id: I7931752ca497bc7a5e3cc574bbb54637f382c72a --- M buildall

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-19 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 2: (14 comments) Thanks for the comments on the patchset, Tim! I've worked on the points you men

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-19 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has uploaded a new patch set (#4). Change subject: Ported native-toolchain to work on ppc64le .. Ported native-toolchain to work on ppc64le Change-Id: I7931752ca497bc7a5e3cc574bbb54637f382c72a --- M buildall

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-07 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 3: > Uploaded patch set 3. It would be great if I could get your comments on the new patchset I'v

[native-toolchain-CR] Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply patches function to appropriately apply patches w.r.t host arch's

2017-04-27 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has abandoned this change. Change subject: Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply_patches function to appropriately apply patches w.r.t host arch's .

[native-toolchain-CR] Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply patches function to appropriately apply patches w.r.t host arch's

2017-04-27 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply_patches function to appropriately apply patches w.r.t host arch's

[native-toolchain-CR] Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply patches function to appropriately apply patches w.r.t host arch's

2017-04-26 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply_patches function to appropriately apply patches w.r.t host arch's

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-26 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has uploaded a new patch set (#3). Change subject: Ported native-toolchain to work on ppc64le .. Ported native-toolchain to work on ppc64le Change-Id: I7931752ca497bc7a5e3cc574bbb54637f382c72a --- M buildall

[native-toolchain-CR] Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply patches function to appropriately apply patches w.r.t host arch's

2017-04-26 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply_patches function to appropriately apply patches w.r.t host arch's

[native-toolchain-CR] Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply patches function to appropriately apply patches w.r.t host arch's

2017-04-26 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has uploaded a new change for review. http://gerrit.cloudera.org:8080/6739 Change subject: Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply_patches function to appropriately apply patches w.r.t host arch's ..

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-25 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: (1 comment) Patch set2 is ready. I'm having a complete run of it, so as to consolidate the lo

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-24 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: (1 comment) Thanks, Tim. http://gerrit.cloudera.org:8080/#/c/6468/1/source/crcutil/build.sh F

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-20 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: > We talked about this on dev@ and it seems there are no objections > to starting code reviews

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-10 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: > > > @Matthew: Would you be needing the ppc64le infra for temporary > > > usage to test the c

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-06 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: @Matthew: Would you be needing the ppc64le infra for temporary usage to test the changes until

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-06 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: Matthew, could you let me know the system configuration required on the ppc64le infra ? -- T

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-04 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: > Valencia, before we continue the discussion of the work on this > toolchain patch much furth

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-03-30 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: (1 comment) I'm ready with almost all required changes, except, for crcutil. Before I push th

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-03-28 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: (16 comments) > (5 comments) @Matt: Thanks for your comments. I've incorporated the modificat

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-03-27 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: @Matthew, @Tim: Thanks for reviewing the patch. I'm working on the pointers you have suggested

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-03-24 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has uploaded a new change for review. http://gerrit.cloudera.org:8080/6468 Change subject: Ported native-toolchain to work on ppc64le .. Ported native-toolchain to work on ppc64le Change-Id: I7931752ca497