[Impala-ASF-CR] DRAFT - IMPALA-5498: Support for partial sorts

2017-06-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: DRAFT - IMPALA-5498: Support for partial sorts .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7267/2/common/thrift/PlanNodes.thrift File common/thr

[Impala-ASF-CR] DRAFT - IMPALA-5498: Support for partial sorts

2017-06-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: DRAFT - IMPALA-5498: Support for partial sorts .. Patch Set 2: (2 comments) did a quick pass again, I think it looks pretty good. Anything major needed before

[Impala-ASF-CR] DRAFT - IMPALA-5498: Support for partial sorts

2017-06-23 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: DRAFT - IMPALA-5498: Support for partial sorts .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/7267/1/be/src/exec/partial-sort-node.cc

[Impala-ASF-CR] DRAFT - IMPALA-5498: Support for partial sorts

2017-06-23 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: DRAFT - IMPALA-5498: Support for partial sorts .. DRAFT - IMPALA-5498: Support for partial sorts Impala currently supports total sorts (the entire set of

[Impala-ASF-CR] DRAFT - IMPALA-5498: Support for partial sorts

2017-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: DRAFT - IMPALA-5498: Support for partial sorts .. Patch Set 1: (2 comments) The overall approach makes sense to me. Happy to talk about the computeResourceProf

[Impala-ASF-CR] DRAFT - IMPALA-5498: Support for partial sorts

2017-06-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: DRAFT - IMPALA-5498: Support for partial sorts .. Patch Set 1: (4 comments) I think the interface changes make sense. I'm not digging into the code details mu

[Impala-ASF-CR] DRAFT - IMPALA-5498: Support for partial sorts

2017-06-22 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: DRAFT - IMPALA-5498: Support for partial sorts .. Patch Set 1: (2 comments) I haven't looked much at the Planner changes needed, eg. in SortNode.compu

[Impala-ASF-CR] DRAFT - IMPALA-5498: Support for partial sorts

2017-06-22 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/7267 Change subject: DRAFT - IMPALA-5498: Support for partial sorts .. DRAFT - IMPALA-5498: Support for partial sorts Impala current