Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 21: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5816
To unsubscribe, visit http:/
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards r
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 21:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/402/
--
To view, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 21: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5816
To unsubscribe, visit http://gerrit.c
Taras Bobrovytsky has uploaded a new patch set (#21).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
fro
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 20:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5816/19/be/src/exec/union-node.cc
File be/src/exec/union-
Taras Bobrovytsky has uploaded a new patch set (#20).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
fro
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#20).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 19:
(14 comments)
http://gerrit.cloudera.org:8080/#/c/5816/19/be/src/exec/union-node.cc
File be/src/ex
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#20).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 19:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5816/19/be/src/exec/union-node.cc
File be/src/exec/union-n
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 19:
(14 comments)
nice cleanup
http://gerrit.cloudera.org:8080/#/c/5816/19/be/src/exec/union-node.cc
File be/
Alex Behm has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 19: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5816
To unsubscribe, visit http://gerrit.c
Taras Bobrovytsky has uploaded a new patch set (#19).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
fro
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#19).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 18:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/5816/18/be/src/exec/union-node.h
File be/src/exec
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#19).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#19).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Alex Behm has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 18:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/5816/18/be/src/exec/union-node.h
File be/src/exec/union-n
Taras Bobrovytsky has uploaded a new patch set (#18).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
fro
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 17:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/5816/17//COMMIT_MSG
Commit Message:
Line 19: A n
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#18).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#18).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#18).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#18).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#18).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Alex Behm has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 17:
(8 comments)
I'm pretty happy with the change. Only minor comment/naming issue left to fix.
http://gerrit
Taras Bobrovytsky has uploaded a new patch set (#17).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
fro
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#17).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#17).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 16:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/5816/9//COMMIT_MSG
Commit Message:
Line 15: hand
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#17).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Alex Behm has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5816/9//COMMIT_MSG
Commit Message:
Line 15: as a precautio
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5816/9//COMMIT_MSG
Commit Message:
Line 15: as a pr
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 16:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5816/16/be/src/exec/union-node.h
File be/src/exec/union-no
Alex Behm has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 16:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/5816/14/be/src/exec/union-node.cc
File be/src/exec/union-
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 16:
Forgot to update planner tests in patch 15.
--
To view, visit http://gerrit.cloudera.org:8080/581
Taras Bobrovytsky has uploaded a new patch set (#16).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
fro
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#16).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Taras Bobrovytsky has uploaded a new patch set (#15).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
fro
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#15).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 14:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/5816/14/be/src/exec/union-node.cc
File be/src/ex
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#15).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Alex Behm has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 14:
(13 comments)
The new code is much clearer! I think we can still improve it further though.
Happy to go o
Taras Bobrovytsky has uploaded a new patch set (#14).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
fro
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#14).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 13:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/5816/13/be/src/exec/union-node.cc
File be/src/exe
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#14).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#14).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#14).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Alex Behm has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 13:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/5816/13/be/src/exec/union-node.cc
File be/src/exec/union-
Taras Bobrovytsky has uploaded a new patch set (#13).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
fro
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#13).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 12:
As Dan pointed out, we don't set eos in the passthrough case, which is a little
weird because ther
Taras Bobrovytsky has uploaded a new patch set (#12).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
fro
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#12).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 11:
Dan, I verified that for many of the existing tests (even in non-exhaustive
mode), we call get nex
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 11:
> No, we do not break out of the loop, we return right away (see line
> 149 in the original union-node.cc)
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 11:
No, we do not break out of the loop, we return right away (see line 149 in the
original union-node
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 11:
> The same thing can happen in the
> non-passthrough case though (without my patch).
Is that true? Won't
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 11:
Yes, that's true that we never set eos=true in the passthrough case if there is
no limit. Do you t
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 11:
> > (2 comments)
> >
> > Dan, I don't think multiple row batches are necessary to exercise
> > the close
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 11:
> (2 comments)
>
> Dan, I don't think multiple row batches are necessary to exercise
> the close on nex
Taras Bobrovytsky has uploaded a new patch set (#11).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
fro
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#11).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 10:
(2 comments)
Dan, I don't think multiple row batches are necessary to exercise the close on
next
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 10: Code-Review+2
(2 comments)
Do any of the tests exercise multiple child row-batches (to exercise that child
Alex Behm has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5816/9//COMMIT_MSG
Commit Message:
Line 15: as a precautio
Taras Bobrovytsky has uploaded a new patch set (#10).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
fro
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 9:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/5816/9//COMMIT_MSG
Commit Message:
Line 15: as a
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#10).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#10).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5816
to look at the new patch set (#10).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5816/9/be/src/exec/union-node.cc
File be/src/exec/union
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5816/9/be/src/exec/union-node.cc
File be/src/exec/union-nod
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5816/9/be/src/exec/union-node.cc
File be/src/exec/union
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 9:
(11 comments)
http://gerrit.cloudera.org:8080/#/c/5816/9//COMMIT_MSG
Commit Message:
Line 15: as a precaut
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 9:
I'll review the be side.
--
To view, visit http://gerrit.cloudera.org:8080/5816
To unsubscribe, vis
Alex Behm has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 9: Code-Review+1
(1 comment)
FE changes lgtm.
http://gerrit.cloudera.org:8080/#/c/5816/9/be/src/exec/union-no
Taras Bobrovytsky has uploaded a new patch set (#9).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
from
Taras Bobrovytsky has uploaded a new patch set (#9).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
from
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 8:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/5816/8/be/src/exec/union-node.h
File be/src/exec/u
Alex Behm has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 7:
(7 comments)
I'm pretty happy with this change
http://gerrit.cloudera.org:8080/#/c/5816/8/be/src/exec/unio
Taras Bobrovytsky has uploaded a new patch set (#8).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
from
Taras Bobrovytsky has uploaded a new patch set (#8).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
from
Taras Bobrovytsky has uploaded a new patch set (#8).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
from
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 7:
(40 comments)
http://gerrit.cloudera.org:8080/#/c/5816/7/be/src/exec/analytic-eval-node.cc
File be/
Taras Bobrovytsky has uploaded a new patch set (#8).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
from
Alex Behm has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 7:
(40 comments)
http://gerrit.cloudera.org:8080/#/c/5816/7/be/src/exec/analytic-eval-node.cc
File be/src/exec
Taras Bobrovytsky has uploaded a new patch set (#7).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
from
Taras Bobrovytsky has uploaded a new patch set (#7).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
from
Taras Bobrovytsky has uploaded a new patch set (#7).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
from
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 6:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5816/4/be/src/exec/union-node.cc
File be/src/exec/
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3586: Implement union passthrough
..
Patch Set 4:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5816/4/be/src/exec/union-node.cc
File be/src/exec/unio
Taras Bobrovytsky has uploaded a new patch set (#6).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
from
Taras Bobrovytsky has uploaded a new patch set (#6).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
from
Taras Bobrovytsky has uploaded a new patch set (#6).
Change subject: IMPALA-3586: Implement union passthrough
..
IMPALA-3586: Implement union passthrough
The union node acts as pass through operator and forwards row batches
from
Taras Bobrovytsky has uploaded a new patch set (#6).
Change subject: IMPALA-3586: Implement Union Passthrough
..
IMPALA-3586: Implement Union Passthrough
The union node acts as pass through operator and forwards row batches
from
98 matches
Mail list logo
