[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 This change fixes the frontend tests to make

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7073 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 10: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/796/ -- To view,

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 10: Code-Review+2 Rebased, carrying Alex's +2. -- To view, visit http://gerrit.cloudera.org:8080/707

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 9: Thank you for the review. I will rebase the change and make sure one more time that tests pass on

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7073 To unsubscribe, visit http://ge

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7073/7/fe/src/main/java/org/apache/impala/analysis

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-27 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#9). Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 This change fixes the frontend tests to make them run on Java 8, b

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7073/7/fe/src/main/java/org/apache/impala/analysis/C

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7073/7/fe/src/main/java/org/apache/impala/analysis

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7073/7/fe/src/main/java/org/apache/impala/analys

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7073/7/fe/src/main/java/org/apache/impala/analys

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 7: (3 comments) Thank you for the review. Please see my comments and PS8. http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-27 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#8). Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 This change fixes the frontend tests to make them run on Java 8, b

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 7: (3 comments) Let's move forward with this change. http://gerrit.cloudera.org:8080/#/c/7073/7/fe/src

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-23 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#7). Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 This change fixes the frontend tests to make them run on Java 8, b

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 6: > Lars can obviously chime in but I'll give my rationale for the +1. > > My understanding is we

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 6: (11 comments) http://gerrit.cloudera.org:8080/#/c/7073/6/fe/src/main/cup/sql-parser.cup File fe/sr

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 6: Lars can obviously chime in but I'll give my rationale for the +1. My understanding is we will s

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 6: > Maybe the associated JIRA is a better place to have this > discussion, but I am trying to understa

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 6: Maybe the associated JIRA is a better place to have this discussion, but I am trying to

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 6: (12 comments) Looks good. Just have minor comments then I'm ready to +1. I think Alex or Dimitr

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/7073/5/fe/src/main/java/org/apache/impala/analysi

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-16 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#6). Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 This change fixes the frontend tests to make them run on Java 8, b

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 5: I'm reluctant to hold up the fix because it's important, but I think if this goes in as-is it co

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 5: (6 comments) I had a few high-level comments: * A lot of this depends on order being preserved a

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 2: Dimitris, also there are changes the behavior of the union node. Pass through is enabled mor

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 5: > Many of these changes are essentially needed just for generating > consistent tests results when w

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 5: Many of these changes are essentially needed just for generating consistent tests result

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7073/2/fe/src/main/java/org/apache/impala/analysi

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-05 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#5). Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 This change fixes the frontend tests to make them run on Java 8, b

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/7073/4/testdata/workloads/functional-planne

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7073/2/fe/src/main/java/org/apache/impala/analy

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7073/2/testdata/workloads/functional-planner/quer

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7073/2//COMMIT_MSG Commit Message: PS2, Line 10: L

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7073/2/testdata/workloads/functional-planner/que

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 2: (6 comments) Thank you for the review. Please see my inline comments and PS4. http://gerrit.cloud

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-04 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#4). Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 This change fixes the frontend tests to make them run on Java 8, b

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/7073/2//COMMIT_MSG Commit Message: PS2, Line 10: r

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-04 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 This change fixes the frontend tests to make them run on Java 8, b

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-04 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 This change fixes the frontend tests to make them run on Java 8, b

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-04 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/7073 Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 This change fixes the f