[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 15: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4494 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/4494/11/be/src/util/bit-packing-test.cc File

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 15: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4494 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-17 Thread Tim Armstrong (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4494 to look at the new patch set (#14). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#13). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These support

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#12). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These support

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/4494/11/be/src/util/bit-packing.inline.h File

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 11: (5 comments) http://gerrit.cloudera.org:8080/#/c/4494/11/be/src/util/bit-packing-test.cc File

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#11). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These support

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/4494/10/be/src/util/bit-packing-test.cc File

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#10). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These support

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 9: > (11 comments) It looks like you might have missed my comments on Base and PS7 in this group of comments. -- To

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 8: (11 comments) http://gerrit.cloudera.org:8080/#/c/4494/8//COMMIT_MSG Commit Message: PS8, Line 17: 64 > 32,

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#9). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These support

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 8: (14 comments) http://gerrit.cloudera.org:8080/#/c/4494/8//COMMIT_MSG Commit Message: PS8, Line 17: 64 32, now?

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These support

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 7: (10 comments) found with help of clang-tidy

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-07 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 7: (20 comments) Thanks for your patience

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These support

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 4: (15 comments) http://gerrit.cloudera.org:8080/#/c/4494/4/be/src/benchmarks/bit-packing-benchmark.cc File

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These support

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 2: (33 comments) http://gerrit.cloudera.org:8080/#/c/4494/2/be/src/benchmarks/bit-packing-benchmark.cc File

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These support

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 3: (34 comments) http://gerrit.cloudera.org:8080/#/c/4494/2/be/src/benchmarks/bit-packing-benchmark.cc File

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These support

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 2: (34 comments) First pass, didn't get to all of it yet but I thought you might want to see what was done