[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4163: Add sortby() query hint .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5051 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4163: Add sortby() query hint .. IMPALA-4163: Add sortby() query hint This change introduces the sortby() query plan hint for insert

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-16 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4163: Add sortby() query hint .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5051 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-16 Thread Lars Volker (Code Review)
Hello Marcel Kornacker, Internal Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5051 to look at the new patch set (#8). Change subject: IMPALA-4163: Add sortby() query hint

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4163: Add sortby() query hint .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4163: Add sortby() query hint .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5051 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4163: Add sortby() query hint .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-16 Thread Lars Volker (Code Review)
Hello Marcel Kornacker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5051 to look at the new patch set (#7). Change subject: IMPALA-4163: Add sortby() query hint ..

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4163: Add sortby() query hint .. Patch Set 6: Code-Review+2 Carry +2. -- To view, visit http://gerrit.cloudera.org:8080/5051 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-16 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4163: Add sortby() query hint .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5051 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4163: Add sortby() query hint .. Patch Set 4: (7 comments) Thanks for the review. Please see PS5.

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-16 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#5). Change subject: IMPALA-4163: Add sortby() query hint .. IMPALA-4163: Add sortby() query hint This change introduces the sortby() query plan hint for insert statements. When

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-16 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4163: Add sortby() query hint .. Patch Set 4: (8 comments)

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-15 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#4). Change subject: IMPALA-4163: Add sortby() query hint .. IMPALA-4163: Add sortby() query hint This change introduces the sortby() query plan hint for insert statements. When

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4163: Add sortby() query hint .. Patch Set 3: (18 comments) Thanks for the review. Please see PS4.

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-14 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4163: Add sortby() query hint .. Patch Set 3: (18 comments) http://gerrit.cloudera.org:8080/#/c/5051/3/fe/src/main/cup/sql-parser.cup File

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-11-30 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4163: Add sortby() query hint .. Patch Set 3: I moved the parsing code into the lexer and parser. This changed some of the error behavior, where errors

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-11-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4163: Add sortby() query hint .. Patch Set 1: (14 comments) Thank you for the review. Please see my comments and PS2.

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-11-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4163: Add sortby() query hint .. Patch Set 1: (15 comments) Add planner and end-to-end tests

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-11-11 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/5051 Change subject: IMPALA-4163: Add sortby() query hint .. IMPALA-4163: Add sortby() query hint This change introduces the sortby() query