[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. IMPALA-4309: Introduce Expr rewrite phase and supporting classes. Introduces a

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4746 To unsu

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-11-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 10: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/4746 To

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-11-03 Thread Alex Behm (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4746 to look at the new patch set (#10). Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-28 Thread Alex Behm (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4746 to look at the new patch set (#9). Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. ..

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-27 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4746 To un

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 7: (2 comments) Please take another look at the latest patch set. - Did some final

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-26 Thread Alex Behm (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4746 to look at the new patch set (#8). Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. ..

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-26 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 7: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/4746/7/fe/s

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/4746/6/fe/src/main/java/org/apac

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-25 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#7). Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. IMPALA-4309: Introduce Expr rewrite phase and supporting classes. Introduces a new phase for rewr

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-24 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/4746/6/fe/src/main/java/o

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4746/5/fe/src/test/java/org/apach

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-24 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#6). Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. IMPALA-4309: Introduce Expr rewrite phase and supporting classes. Introduces a new phase for rewr

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 5: (11 comments) http://gerrit.cloudera.org:8080/#/c/4746/5/fe/src/main/java/org/apa

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 5: (11 comments) http://gerrit.cloudera.org:8080/#/c/4746/5/fe/src/main/java/

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4746/4/fe/src/main/java/org/apach

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4746/4/fe/src/main/j

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4746/4/fe/src/main/java/org/apach

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-21 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#5). Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. IMPALA-4309: Introduce Expr rewrite phase and supporting classes. Introduces a new phase for rewr

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 4: (12 comments) http://gerrit.cloudera.org:8080/#/c/4746/4//COMMIT_MSG Commit Messa

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 4: (13 comments) Flushing out some comments. Haven't looked at tests yet

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#4). Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. IMPALA-4309: Introduce Expr rewrite phase and supporting classes. Introduces a new phase for rewr

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/4746/2/fe/src/main/java/org/apac

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/4746/2/fe/src/main/ja

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/4746/2/fe/src/main/java/org/apac

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#3). Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. IMPALA-4309: Introduce Expr rewrite phase and supporting classes. Introduces a new phase for rewr

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 2: (5 comments) The overall approach looks sane - had a few high-level questions

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-18 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. IMPALA-4309: Introduce Expr rewrite phase and supporting classes. Introduces a new phase for rewr