[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink

2016-10-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4335: Don't send 0-row batches to sink .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4787/3//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink

2016-10-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4335: Don't send 0-row batches to sink .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4787/2/be/src/exec/plan-root-sink.cc File be/src/

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink

2016-10-21 Thread Henry Robinson (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4787 to look at the new patch set (#3). Change subject: IMPALA-4335: Don't send 0-row batches to sink .. IM

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink

2016-10-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4335: Don't send 0-row batches to sink .. Patch Set 2: Code-Review+2 Thanks. I verified it fixed case w/ the KuduScanNode. -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink

2016-10-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4335: Don't send 0-row batches to sink .. Patch Set 2: Code-Review+1 (1 comment) I suspect that whatever test we add may become stale pretty easily. The empt

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink

2016-10-21 Thread Henry Robinson (Code Review)
Henry Robinson has restored this change. Change subject: IMPALA-4335: Don't send 0-row batches to sink .. Restored Let's try this again. -- To view, visit http://gerrit.cloudera.org:8080/4787 To unsubscribe, visit http://gerr

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink

2016-10-21 Thread Henry Robinson (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4787 to look at the new patch set (#2). Change subject: IMPALA-4335: Don't send 0-row batches to sink .. IMPALA-4335:

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink

2016-10-21 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-4335: Don't send 0-row batches to sink .. Abandoned Turns out that some sinks need 0-row batches, to manage their lifetime so we can't just drop them on the floo

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink

2016-10-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4335: Don't send 0-row batches to sink .. Patch Set 1: Code-Review+1 (1 comment) Thanks. Not sure why it doesn't repro for you, Michael Brown repro'd th

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink

2016-10-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4787 Change subject: IMPALA-4335: Don't send 0-row batches to sink .. IMPALA-4335: Don't send 0-row batches to sink This patchr restores som