[Impala-ASF-CR] IMPALA-4518: CopyStringVal() doesn't copy null string

2017-04-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4518: CopyStringVal() doesn't copy null string .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5198/3/be/src/exprs/aggregate-functions-ir.cc

[Impala-ASF-CR] IMPALA-4518: CopyStringVal() doesn't copy null string

2016-11-23 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4518: CopyStringVal() doesn't copy null string .. IMPALA-4518: CopyStringVal() doesn't copy null string Previously, CopyStringVal() mistakenly

[Impala-ASF-CR] IMPALA-4518: CopyStringVal() doesn't copy null string

2016-11-23 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4518: CopyStringVal() doesn't copy null string .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5198 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4518: CopyStringVal() doesn't copy null string

2016-11-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4518: CopyStringVal() doesn't copy null string .. Patch Set 2: Code-Review+2 Carry Tim's +2. -- To view, visit http://gerrit.cloudera.org:8080/5198 To unsu

[Impala-ASF-CR] IMPALA-4518: CopyStringVal() doesn't copy null string

2016-11-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4518: CopyStringVal() doesn't copy null string .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5198/1//COMMIT_MSG Commit Message: PS1, Lin

[Impala-ASF-CR] IMPALA-4518: CopyStringVal() doesn't copy null string

2016-11-23 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5198 to look at the new patch set (#2). Change subject: IMPALA-4518: CopyStringVal() doesn't copy null string .. IMPALA

[Impala-ASF-CR] IMPALA-4518: CopyStringVal() doesn't copy null string

2016-11-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4518: CopyStringVal() doesn't copy null string .. Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/5198/1//COMMIT_MSG Commit M

[Impala-ASF-CR] IMPALA-4518: CopyStringVal() doesn't copy null string

2016-11-22 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/5198 Change subject: IMPALA-4518: CopyStringVal() doesn't copy null string .. IMPALA-4518: CopyStringVal() doesn't copy null string Previously,