[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5493 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. IMPALA-4654: KuduScanner must return when ReachedLimit() Fixes a bug in the KuduScanner w

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5493 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 2: > Change looks good to me. > > As discussed, I think there is still one remaining bu

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5493/2/be/src/exec/kudu-s

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 2: Code-Review+1 Change looks good to me. As discussed, I think there is still one remaining b

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 2: BTW this passed a private jenkins run -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 2: (3 comments) Alex, per our conversation about other cases- are you OK with investigati

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5493/2/be/src/exec/kudu-scanner.cc File b

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5493/2/be/src/exec/kudu-scanner.cc File be

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-13 Thread Matthew Jacobs (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5493 to look at the new patch set (#2). Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. IMP

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5493/1/be/src/exec/kudu-scanner.h File

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5493/1/be/src/exec/kudu-s

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5493 Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. IMPALA-4654: KuduScanner must return when ReachedLimit() Fi