Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
IMPALA-4674: Part 1: remove old aggs and joins
This is intended to be merged at the same time
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 12: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7102
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 12: Code-Review+2
Rebase. Kicking off a merge ahead of the follow-on patches.
--
To view, visit htt
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 12:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/969/
--
To view, visi
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 11: Code-Review+2
Rebase
--
To view, visit http://gerrit.cloudera.org:8080/7102
To unsubscribe, vis
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7102
to look at the new patch set (#11).
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
IMPALA-4674: Par
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7102
To unsubscribe, visit http:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 9: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7102
To unsubscribe, visi
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 8: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7102
To unsubscribe, visi
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 7: Code-Review+2
Rebase
--
To view, visit http://gerrit.cloudera.org:8080/7102
To unsubscribe, visi
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7102
to look at the new patch set (#7).
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
IMPALA-4674: Part
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 6:
It seems like a good idea, just didn't want to do an ad-hoc solution. Filed
https://issues.apache
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 6: Code-Review+2
Okay, if we have precedence for "silently" deprecating, then that's fine.
--
To view,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 6:
We could probably use the GFlag validator mechanism:
https://gflags.github.io/gflags/#validate
-
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 6:
Sorry meant to respond to that one. We don't generally warn on deprecated
command-line flags. E.g
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 6:
What about this question:
> Maybe print something to the warning log if either flag is set to true?
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 5:
PS5 was a rebase, PS6 addressed the comment
--
To view, visit http://gerrit.cloudera.org:8080/71
Tim Armstrong has uploaded a new patch set (#6).
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
IMPALA-4674: Part 1: remove old aggs and joins
This is intended to be merged at the same time as Part 2 but is
se
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7102/4/be/src/exec/blocking-join-node.cc
File be
Tim Armstrong has uploaded a new patch set (#5).
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
IMPALA-4674: Part 1: remove old aggs and joins
This is intended to be merged at the same time as Part 2 but is
se
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 4:
(1 comment)
Looks good when the time is right.
Maybe print something to the warning log if either f
Tim Armstrong has uploaded a new patch set (#4).
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
IMPALA-4674: Part 1: remove old aggs and joins
This is intended to be merged at the same time as Part 2 but is
se
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
IMPALA-4674: Part 1: remove old aggs and joins
This is intended to be merged at the same time as Part 2 but is
se
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
IMPALA-4674: Part 1: remove old aggs and joins
This is intended to be merged at the same time as Part 2 but is
se
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7102
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
IMPALA-4674: Part 1: remove old aggs and joins
This is intended to be
25 matches
Mail list logo
