[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 40: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5801 To unsubscribe,

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 40: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/990/ -- To

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 40: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/988/

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 40: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/988/ -- To

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 40: Michael Brown and Matt Mulder have been helping me out with testing. So far this has held

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 40: Code-Review+2 Rebased. -- To view, visit http://gerrit.cloudera.org:8080/5801 To

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-08-04 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5801 to look at the new patch set (#40). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-08-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 39: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/5801 To

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-08-01 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5801 to look at the new patch set (#39). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-27 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5801 to look at the new patch set (#38). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 37: Code-Review+1 partial sort stuff looks good -- To view, visit

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 37: Code-Review+2 Rebase. Thomas, I rebased onto the partial sorter change - might be good to

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-25 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5801 to look at the new patch set (#37). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool ..

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-25 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5801 to look at the new patch set (#36). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool ..

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 35: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5801 To unsubscribe,

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 34: Code-Review+2 Updated test_explain with a minor change. -- To view, visit

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-19 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5801 to look at the new patch set (#34). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool ..

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 33: Code-Review+2 Fixed a bug in the PHJ debug string where it didn't handle a closed build

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-18 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5801 to look at the new patch set (#33). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool ..

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 26: (1 comment) http://gerrit.cloudera.org:8080/#/c/5801/26/be/src/runtime/query-state.cc File

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 32: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/5801 To

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-13 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5801 to look at the new patch set (#32). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool ..

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 31: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5801 To

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-13 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5801 to look at the new patch set (#31). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool ..

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 30: Code-Review+2 (4 comments) +2 assuming we do the addition flag in a separate change. Good

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 29: (24 comments)

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#30). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at startup using 80%

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 29: (26 comments)

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 28: (10 comments) http://gerrit.cloudera.org:8080/#/c/5801/26/be/src/runtime/query-state.cc

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#29). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at startup using 80%

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 26: (1 comment) http://gerrit.cloudera.org:8080/#/c/5801/26/be/src/runtime/query-state.cc File

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 28: (12 comments) LMK if i missed responding to anything.

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 26: (18 comments) Addressed most of the comments but had a couple of questions about query

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#28). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at startup using 80%

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 27: (18 comments) http://gerrit.cloudera.org:8080/#/c/5801/27/be/src/exec/exec-node.h File

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#27). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at startup using 80%

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 23: (2 comments) http://gerrit.cloudera.org:8080/#/c/5801/23/be/src/runtime/runtime-state.h File

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 23: (3 comments) http://gerrit.cloudera.org:8080/#/c/5801/23/be/src/exec/exec-node.cc File

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#26). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at startup using 80%

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 23: (4 comments) http://gerrit.cloudera.org:8080/#/c/5801/23/be/src/exec/exec-node.cc File

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#25). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at startup using 80%

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 23: (27 comments)

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 24: Rebased and fixed a bunch of tests. -- To view, visit

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 23: (27 comments) First batch of comments. Will continue but figure we can pipeline somewhat.

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#24). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at startup using 80%

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#23). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at startup using 80%

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#22). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at startup using 80%