[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-04-20 Thread Alex Behm (Code Review)
Alex Behm has abandoned this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Abandoned Fix was already checked in. -- To view, visit http://gerrit.cloudera.org:8080/5684 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-14 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/5662/6/fe/src/main/java/org/apache/impala/

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-12 Thread Anonymous Coward (Code Review)
zams...@cloudera.com has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 6: (2 comments) I realize this is already merged - simply learning how to use gerrit and I

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5662 To unsubscribe, visi

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. IMPALA-4739: ExprRewriter fails on HAVING clauses The bug was that expr rewrite rules such

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-11 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 5: Code-Review+2 > I don't fully understand the consequences of not analyzing these > exprs. B

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/168/ -- To view

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-11 Thread Marcel Kornacker (Code Review)
Hello Impala Public Jenkins, Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5662 to look at the new patch set (#5). Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-11 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new change for review. http://gerrit.cloudera.org:8080/5684 Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. IMPALA-4739: ExprRewriter fails on HAVING clauses The bug was th

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 4: I don't fully understand the consequences of not analyzing these exprs. Based on Jim's comment

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 4: org.apache.impala.common.AnalysisException at org.apache.impala.analysis.AnalysisContext.a

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 4: I changed the approach, please take another look. -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Marcel Kornacker (Code Review)
Hello Impala Public Jenkins, Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5662 to look at the new patch set (#4). Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Marcel Kornacker (Code Review)
Hello Impala Public Jenkins, Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5662 to look at the new patch set (#3). Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 2: Marcel just informed me that he will continue working on this patch. (I am no longer worki

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 2: I think this requires some additional test fixes, I am looking into it. -- To view, visit

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 2: Is this ready for a new pre-commit Jenkins test? -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 2: Code-Review+2 Test fixes look good to me -- To view, visit http://gerrit.cloudera.org:8080/56

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Marcel Kornacker (Code Review)
Hello Impala Public Jenkins, Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5662 to look at the new patch set (#2). Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses ...

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 1: Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/156/ -- To view,

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 1: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/157/ -

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/156/ -- To view

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/157/ -- To view

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-09 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5662/1/fe/src/main/java/org/apache/impala/a

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5662/1/fe/src/main/java/

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-09 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new change for review. http://gerrit.cloudera.org:8080/5662 Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. IMPALA-4739: ExprRewriter fails on HAVING clauses SelectStmt.rew