[Impala-ASF-CR] IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule.

2017-06-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. .. Patch Set 4: (3 comments) Final polish. http://gerrit.cloudera.org:8080/#/c/7015/4

[Impala-ASF-CR] IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule.

2017-06-08 Thread yu feng (Code Review)
yu feng has posted comments on this change. Change subject: IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. .. Patch Set 4: (35 comments) responded to comments by alex. http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule.

2017-06-08 Thread yu feng (Code Review)
yu feng has uploaded a new patch set (#4). Change subject: IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. .. IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. try to rewr

[Impala-ASF-CR] IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule.

2017-06-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. .. Patch Set 3: (4 comments) Last round of minor comments. This patch looks good. Nice

[Impala-ASF-CR] IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule.

2017-06-08 Thread yu feng (Code Review)
yu feng has uploaded a new patch set (#3). Change subject: IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. .. IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. try to rewr

[Impala-ASF-CR] IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule.

2017-06-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. .. Patch Set 2: (13 comments) The rewrite code looks very clean and concise! http://g

[Impala-ASF-CR] IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule.

2017-06-06 Thread yu feng (Code Review)
yu feng has uploaded a new patch set (#2). Change subject: IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. .. IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. try to rewr

[Impala-ASF-CR] IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule.

2017-05-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. .. Patch Set 1: (18 comments) Nice work! This approach looks much better. Still some w

[Impala-ASF-CR] IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule.

2017-05-30 Thread yu feng (Code Review)
yu feng has uploaded a new change for review. http://gerrit.cloudera.org:8080/7015 Change subject: IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. .. IMPALA-5016: Try to rewrite coalesce() functio