[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-06-01 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7000/3/be/src/exprs/expr-test.cc File be/src/exprs

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Patch Set 3: (2 comments) Looks good aside from a couple of minor things. http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-26 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#3). Change subject: IMPALA-5030: Adds support for NVL2() function .. IMPALA-5030: Adds support for NVL2() function This change adds value tests to expr-test.cc to ensure that NVL2() fu

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-26 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#2). Change subject: IMPALA-5030: Adds support for NVL2() function .. IMPALA-5030: Adds support for NVL2() function This change adds value and null tests to expr-test.cc for IMPALA-5030

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-26 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new change for review. http://gerrit.cloudera.org:8080/7000 Change subject: IMPALA-5030: Adds support for NVL2() function .. IMPALA-5030: Adds support for NVL2() function This change adds support t

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-25 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Patch Set 5: I can make that happen. Can I just push the patch again as normal? -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Patch Set 5: I'm late to the party but we need a test that confirms the expr gets written correctly - e.g. in e

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5030: Adds support for NVL2() function .. IMPALA-5030: Adds support for NVL2() function This change adds support to the function NVL2(exp

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6962 To unsubscribe, visit ht

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/637/ -- To view, vi

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6962 To unsubscribe, visit http://gerr

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-24 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#4). Change subject: IMPALA-5030: Adds support for NVL2() function .. IMPALA-5030: Adds support for NVL2() function This change adds support to the function NVL2(expr1, expr2, expr3). T

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-24 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6962/3/fe/src/main/java/org/apache/impala/analysis

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6962/3/fe/src/main/java/org/apache/impala/analysis/Fun

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6962/3/fe/src/main/java/org/apache/impala/analysis/F

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-24 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#3). Change subject: IMPALA-5030: Adds support for NVL2() function .. IMPALA-5030: Adds support for NVL2() function This change adds support to the function NVL2(expr1, expr2, expr3). T

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-24 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Patch Set 2: (16 comments) http://gerrit.cloudera.org:8080/#/c/6962/1//COMMIT_MSG Commit Message: Line 17 > Cle

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/6962/2//COMMIT_MSG Commit Message: Line 11: expr3. B

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-23 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#2). Change subject: IMPALA-5030: Adds support for NVL2() function .. IMPALA-5030: Adds support for NVL2() function This change adds support to the function NVL2(expr1, expr2, expr3). T

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-23 Thread Vincent Tran (Code Review)
Vincent Tran has abandoned this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6972 To unsubscribe, visit http://gerrit.cloudera.org:8080/se

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-23 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new change for review. http://gerrit.cloudera.org:8080/6972 Change subject: IMPALA-5030: Adds support for NVL2() function .. IMPALA-5030: Adds support for NVL2() function This change adds support t