[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. IMPALA-5513: Fix display message exception when using invalid KEYVAL Fu

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7187

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 8: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryr

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 8: Code-Review+2 Rebased and resubmitting GVO (failed due to a recently

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 7: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-v

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 7: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryr

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7187 To unsubs

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-16 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 7: Code-Review+1 Hi Bharath, I have merged the test case and carried your Code-Re

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-14 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 7: -Code-Review -- To view, visit http://gerrit.cloudera.org:8080/7187 To unsubs

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-14 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 7: Code-Review+1 Thank you for the suggestion that I have modified the code. --

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-14 Thread Donghui Xu (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7187 to look at the new patch set (#7). Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL ...

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 6: Code-Review+1 Didn't mean to -1, feel free to carry my +1 once you f

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 6: -Code-Review Sorry for holding this up, didn't realize it was waitin

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-11 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 6: Please review this code. Thanks a lot. -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-06 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 6: This is a abnormal test case which terminated immediately. This is different

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 6: Code-Review+1 (1 comment) LGTM. http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-05 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 6: (1 comment) I have modified comit message. http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-05 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new patch set (#6). Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. IMPALA-5513: Fix display message exception when using invalid KEYVAL Function print_to_stderr

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 5: (1 comment) Bharath, if you're OK with the test, then once my comment is addre

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-05 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 5: (4 comments) I have modified the code according to your opinion and added the

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-05 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new patch set (#5). Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. IMPALA-5513: Fix display message exception when using invalid KEYVAL Function print_to_stderr

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 4: (2 comments) Couple more minor comments in addition to Jim's review

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 4: (2 comments) > (2 comments) > > I have modified the code according to your

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-03 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 4: (2 comments) I have modified the code according to your opinion. I think your

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-03 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new patch set (#4). Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. IMPALA-5513: Fix display message exception when using invalid KEYVAL Function Print_to_stderr

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-03 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new patch set (#3). Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. IMPALA-5513: Fix display message exception when using invalid KEYVAL Function Print_to_stderr

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 2: (2 comments) Thank you for your patch. You might get faster reviews in the fu

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-03 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 2: Can anyone review this issue please? Thanks. -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-06-15 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new patch set (#2). Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. IMPALA-5513: Fix display message exception when using invalid KEYVAL Function Print_to_stderr

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-06-15 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new change for review. http://gerrit.cloudera.org:8080/7187 Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. IMPALA-5513: Fix display message exception when usi