[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. IMPALA-5650: Make sum_init_zero a SUM function The recent Parquet count(*) optimization (IMPAL

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7404 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/859/ -- To view, v

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7404 To unsubscribe, visit http://ge

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. IMPALA-5650: Make sum_init_zero a SUM function The recent Parquet count(*) optimization (IMPALA-5036) introdu

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-13 Thread Taras Bobrovytsky (Code Review)
Hello Lars Volker, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7404 to look at the new patch set (#4). Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. IMP

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7404/3/be/src/exec/partitioned-aggregation-n

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7404/3/be/src/exec/partitioned-aggregation-node.cc

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7404/3/be/src/exec/partitioned-aggregation-node.cc

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. Patch Set 3: It turns out that a change in PAGG node was required as Michael suggested. Can you take a loo

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. IMPALA-5650: Make sum_init_zero a SUM function The recent Parquet count(*) optimization (IMPALA-5036) introdu

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-12 Thread Taras Bobrovytsky (Code Review)
Hello Lars Volker, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7404 to look at the new patch set (#3). Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. IMP

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-12 Thread Taras Bobrovytsky (Code Review)
Hello Lars Volker, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7404 to look at the new patch set (#2). Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. IMP

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. IMPALA-5650: Make sum_init_zero a SUM function The recent Parquet count(*) optimization (IMPALA-5036) introdu

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7404/1//COMMIT_MSG Commit Message: PS1, Line

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. Patch Set 1: Code-Review+2 Please make sure you do some proper testing with the PAGG too as this actually affects

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/7404 Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. IMPALA-5650: Make sum_init_zero a SUM function The recent Parquet

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7404/1//COMMIT_MSG Commit Message: P