[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1185: fix some doc mistakes

sonarcloud[bot] commented on pull request #1185: URL: https://github.com/apache/incubator-iotdb/pull/1185#issuecomment-626485564 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1185=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1185: fix some doc mistakes

sonarcloud[bot] removed a comment on pull request #1185: URL: https://github.com/apache/incubator-iotdb/pull/1185#issuecomment-626263653 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1185=false=BUG)

[GitHub] [incubator-iotdb] HTHou commented on pull request #983: Online Upgrade Tool

HTHou commented on pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#issuecomment-626485419 > Imagine, when IoTDB evolves to 0.12, 0.13, or even higher version, such codes will either go to hell or grow fatter and fatter. What will you do to the classes like

[GitHub] [incubator-iotdb] FoxNo2 opened a new issue #1187: IoTDB的监控网页异常

FoxNo2 opened a new issue #1187: URL: https://github.com/apache/incubator-iotdb/issues/1187 使用IoTDB的 0.10.0-SNAPSHOT版本. IoTDB无数据时,访问IP:8181可以正常显示监控网页,当写入数据后,再次访问,网页报出500异常. java.lang.NullPointerException at

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #983: Online Upgrade Tool

qiaojialin commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422785770 ## File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java ## @@ -316,40 +377,93 @@ private

[GitHub] [incubator-iotdb] jt2594838 commented on pull request #983: Online Upgrade Tool

jt2594838 commented on pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#issuecomment-626464889 It may work, I think. But to be honest, I dislike the design that you put everything old just in-place with the newest code, and especially such code will only apply to

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #983: Online Upgrade Tool

jt2594838 commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422752029 ## File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java ## @@ -298,6 +319,46 @@ private void

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1186: [IOTDB-655] Update documents of new version TsFile

sonarcloud[bot] removed a comment on pull request #1186: URL: https://github.com/apache/incubator-iotdb/pull/1186#issuecomment-626434493 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1186=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1186: [IOTDB-655] Update documents of new version TsFile

sonarcloud[bot] commented on pull request #1186: URL: https://github.com/apache/incubator-iotdb/pull/1186#issuecomment-626446811 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1186=false=BUG)

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1186: [IOTDB-655] Update documents of new version TsFile

HTHou commented on a change in pull request #1186: URL: https://github.com/apache/incubator-iotdb/pull/1186#discussion_r422751361 ## File path: docs/zh/SystemDesign/1-TsFile/2-Format.md ## @@ -128,8 +127,8 @@ PageHeader 结构 | 该页最大值(max)| Type of the page

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster

sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-626437827 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster

sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-625613699 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1186: [IOTDB-655] Update documents of new version TsFile

sonarcloud[bot] removed a comment on pull request #1186: URL: https://github.com/apache/incubator-iotdb/pull/1186#issuecomment-626301028 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1186=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1186: [IOTDB-655] Update documents of new version TsFile

sonarcloud[bot] commented on pull request #1186: URL: https://github.com/apache/incubator-iotdb/pull/1186#issuecomment-626434493 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1186=false=BUG)

[GitHub] [incubator-iotdb] samperson1997 commented on pull request #1186: [IOTDB-655] Update documents of new version TsFile

samperson1997 commented on pull request #1186: URL: https://github.com/apache/incubator-iotdb/pull/1186#issuecomment-626433748 > Well down! Nice work.  > I just found two tables in doc, which are pageHeader and ChunkHeader need to be changed. Hi Haonan, Thanks for your help

[GitHub] [incubator-iotdb] samperson1997 commented on a change in pull request #1186: [IOTDB-655] Update documents of new version TsFile

samperson1997 commented on a change in pull request #1186: URL: https://github.com/apache/incubator-iotdb/pull/1186#discussion_r422742841 ## File path: docs/SystemDesign/1-TsFile/2-Format.md ## @@ -143,120 +143,126 @@ PageHeader Structure Review comment: Fixed

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1169: Premerge for the distributed version

sonarcloud[bot] commented on pull request #1169: URL: https://github.com/apache/incubator-iotdb/pull/1169#issuecomment-626422295 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1169=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1169: Premerge for the distributed version

sonarcloud[bot] removed a comment on pull request #1169: URL: https://github.com/apache/incubator-iotdb/pull/1169#issuecomment-626090472 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1169=false=BUG)

[GitHub] [incubator-iotdb] SilverNarcissus commented on a change in pull request #1174: Concurrently write time partition

SilverNarcissus commented on a change in pull request #1174: URL: https://github.com/apache/incubator-iotdb/pull/1174#discussion_r422730103 ## File path: server/src/main/java/org/apache/iotdb/db/conf/adapter/IoTDBConfigDynamicAdapter.java ## @@ -30,86 +30,70 @@ * This class

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #983: Online Upgrade Tool

sonarcloud[bot] commented on pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#issuecomment-626352731 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=983=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #983: Online Upgrade Tool

sonarcloud[bot] removed a comment on pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#issuecomment-626270747 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=983=false=BUG)

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422654899 ## File path: server/src/main/java/org/apache/iotdb/db/utils/UpgradeUtils.java ## @@ -76,9 +76,13 @@ public static boolean

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422659012 ## File path: server/src/main/java/org/apache/iotdb/db/tools/upgrade/TsfileOnlineUpgradeTool.java ## @@ -0,0 +1,624 @@ +/* + * Licensed to the

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422661924 ## File path: server/src/main/java/org/apache/iotdb/db/tools/upgrade/TsfileOnlineUpgradeTool.java ## @@ -0,0 +1,624 @@ +/* + * Licensed to the

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422661752 ## File path: server/src/main/java/org/apache/iotdb/db/tools/upgrade/TsfileOnlineUpgradeTool.java ## @@ -0,0 +1,624 @@ +/* + * Licensed to the

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422661202 ## File path: server/src/main/java/org/apache/iotdb/db/engine/upgrade/UpgradeTask.java ## @@ -40,30 +47,69 @@ public UpgradeTask(TsFileResource

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422660428 ## File path: server/src/main/java/org/apache/iotdb/db/engine/upgrade/UpgradeTask.java ## @@ -40,30 +47,69 @@ public UpgradeTask(TsFileResource

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422660143 ## File path: server/src/main/java/org/apache/iotdb/db/tools/upgrade/UpgradeTool.java ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422659513 ## File path: server/src/main/java/org/apache/iotdb/db/tools/upgrade/TsfileOnlineUpgradeTool.java ## @@ -0,0 +1,624 @@ +/* + * Licensed to the

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422659012 ## File path: server/src/main/java/org/apache/iotdb/db/tools/upgrade/TsfileOnlineUpgradeTool.java ## @@ -0,0 +1,624 @@ +/* + * Licensed to the

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422657675 ## File path: server/src/main/java/org/apache/iotdb/db/tools/upgrade/TsfileOnlineUpgradeTool.java ## @@ -0,0 +1,624 @@ +/* + * Licensed to the

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422657145 ## File path: server/src/main/java/org/apache/iotdb/db/tools/upgrade/TsfileOnlineUpgradeTool.java ## @@ -0,0 +1,624 @@ +/* + * Licensed to the

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422657145 ## File path: server/src/main/java/org/apache/iotdb/db/tools/upgrade/TsfileOnlineUpgradeTool.java ## @@ -0,0 +1,624 @@ +/* + * Licensed to the

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422656393 ## File path: server/src/main/java/org/apache/iotdb/db/tools/upgrade/TsfileOnlineUpgradeTool.java ## @@ -0,0 +1,624 @@ +/* + * Licensed to the

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422656173 ## File path: tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/TimeseriesMetadata.java ## @@ -114,10 +118,26 @@ public void

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422655075 ## File path: server/src/main/java/org/apache/iotdb/db/utils/UpgradeUtils.java ## @@ -76,9 +76,13 @@ public static boolean

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422654899 ## File path: server/src/main/java/org/apache/iotdb/db/utils/UpgradeUtils.java ## @@ -76,9 +76,13 @@ public static boolean

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422653603 ## File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java ## @@ -1313,12 +1450,12 @@ private void

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422653345 ## File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java ## @@ -1313,12 +1450,12 @@ private void

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422652916 ## File path: server/src/main/java/org/apache/iotdb/db/tools/upgrade/UpgradeTool.java ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #983: Online Upgrade Tool

HTHou commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422651713 ## File path: server/src/main/java/org/apache/iotdb/db/conf/IoTDBConfigCheck.java ## @@ -99,48 +101,103 @@ private void checkFile(String filepath) {

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1186: [IOTDB-655] Update documents of new version TsFile

HTHou commented on a change in pull request #1186: URL: https://github.com/apache/incubator-iotdb/pull/1186#discussion_r422649625 ## File path: docs/SystemDesign/1-TsFile/2-Format.md ## @@ -143,120 +143,126 @@ PageHeader Structure Review comment: In the table of

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1186: [IOTDB-655] Update documents of new version TsFile

sonarcloud[bot] commented on pull request #1186: URL: https://github.com/apache/incubator-iotdb/pull/1186#issuecomment-626301028 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1186=false=BUG)

[GitHub] [incubator-iotdb] samperson1997 opened a new pull request #1186: [IOTDB-655] Update documents of new version TsFile

samperson1997 opened a new pull request #1186: URL: https://github.com/apache/incubator-iotdb/pull/1186 Update documents of new version TsFile * Update `SystemDesign/1-TsFile/2-Format.md` and its figures. Add examples for the new structure `MetadataIndexNode` * Change the config name

[GitHub] [incubator-iotdb] samperson1997 commented on a change in pull request #983: Online Upgrade Tool

samperson1997 commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422616102 ## File path: server/src/main/java/org/apache/iotdb/db/metadata/MLogWriter.java ## @@ -124,7 +124,8 @@ public void changeOffset(String path,

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #983: Online Upgrade Tool

qiaojialin commented on a change in pull request #983: URL: https://github.com/apache/incubator-iotdb/pull/983#discussion_r422580421 ## File path: server/src/main/java/org/apache/iotdb/db/engine/version/SimpleFileVersionController.java ## @@ -54,6 +55,15 @@ public