neuyilan commented on a change in pull request #1339:
URL: https://github.com/apache/incubator-iotdb/pull/1339#discussion_r437896543
##
File path:
cluster/src/main/java/org/apache/iotdb/cluster/log/manage/RaftLogManager.java
##
@@ -50,6 +54,17 @@
private long commitIndex;
LebronAl commented on pull request #1339:
URL: https://github.com/apache/incubator-iotdb/pull/1339#issuecomment-641759183
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on
HTHou commented on pull request #1332:
URL: https://github.com/apache/incubator-iotdb/pull/1332#issuecomment-641740377
> How about adding some tests to ensure that the device strings are the same
object?
Thanks. Great idea! I'll add some tests soon.
---
sonarcloud[bot] removed a comment on pull request #1338:
URL: https://github.com/apache/incubator-iotdb/pull/1338#issuecomment-641281671
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1338&resolved=false&types=BUG)
[](htt
sonarcloud[bot] commented on pull request #1338:
URL: https://github.com/apache/incubator-iotdb/pull/1338#issuecomment-641724554
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1338&resolved=false&types=BUG)
[](https://son
jt2594838 edited a comment on pull request #1337:
URL: https://github.com/apache/incubator-iotdb/pull/1337#issuecomment-641709191
It is a bit weird to provide async methods without providing callbacks (even
only formally). It may work but is not a very general design.
jt2594838 commented on pull request #1337:
URL: https://github.com/apache/incubator-iotdb/pull/1337#issuecomment-641709191
It is a bit weird to provide async methods without providing callbacks. It
may work but is not a very general design.
jt2594838 commented on a change in pull request #1339:
URL: https://github.com/apache/incubator-iotdb/pull/1339#discussion_r437844557
##
File path:
cluster/src/main/java/org/apache/iotdb/cluster/log/manage/serializable/SyncLogDequeSerializer.java
##
@@ -79,6 +85,24 @@
// ve
LebronAl commented on pull request #1339:
URL: https://github.com/apache/incubator-iotdb/pull/1339#issuecomment-641671481
How about the raft logs in Memory(CommittedLogManager)?Is it better to make
them consistent after deleting old logs?
--
jixuan1989 merged pull request #1333:
URL: https://github.com/apache/incubator-iotdb/pull/1333
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
sonarcloud[bot] removed a comment on pull request #1336:
URL: https://github.com/apache/incubator-iotdb/pull/1336#issuecomment-641094264
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1336&resolved=false&types=BUG)
qiaojialin opened a new pull request #1330:
URL: https://github.com/apache/incubator-iotdb/pull/1330
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
qiaojialin merged pull request #1328:
URL: https://github.com/apache/incubator-iotdb/pull/1328
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
neuyilan opened a new pull request #1339:
URL: https://github.com/apache/incubator-iotdb/pull/1339
The main logic for deleting raft logs is as follows:
Each server periodically(3600 seconds) triggers the operation to check the
deletion of the log. If the distance between the last deletio
jixuan1989 opened a new pull request #1333:
URL: https://github.com/apache/incubator-iotdb/pull/1333
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
qiaojialin merged pull request #1336:
URL: https://github.com/apache/incubator-iotdb/pull/1336
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
JulianFeinauer commented on a change in pull request #1323:
URL: https://github.com/apache/incubator-iotdb/pull/1323#discussion_r436888435
##
File path:
server/src/main/java/org/apache/iotdb/db/metadata/mnode/LeafMNode.java
##
@@ -24,14 +24,9 @@
import org.apache.iotdb.tsfile
sonarcloud[bot] removed a comment on pull request #1323:
URL: https://github.com/apache/incubator-iotdb/pull/1323#issuecomment-640275553
This is an automated message from the Apache Git Service.
To respond to the message, plea
Alima777 commented on issue #1340:
URL:
https://github.com/apache/incubator-iotdb/issues/1340#issuecomment-641345352
We have solved this problem in 0.10 version. : )
This is an automated message from the Apache Git Service.
qiaojialin opened a new pull request #1331:
URL: https://github.com/apache/incubator-iotdb/pull/1331
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
sonarcloud[bot] commented on pull request #1332:
URL: https://github.com/apache/incubator-iotdb/pull/1332#issuecomment-641112814
This is an automated message from the Apache Git Service.
To respond to the message, please log o
HTHou opened a new pull request #1332:
URL: https://github.com/apache/incubator-iotdb/pull/1332
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
wshao08 opened a new pull request #1337:
URL: https://github.com/apache/incubator-iotdb/pull/1337
JIRA issue: https://issues.apache.org/jira/browse/IOTDB-746
This PR adds corresponding asynchronous insertion interfaces for Session and
SessionPool.
--
sonarcloud[bot] commented on pull request #1333:
URL: https://github.com/apache/incubator-iotdb/pull/1333#issuecomment-641043287
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1333&resolved=false&types=BUG)
[](http
puroc opened a new issue #1329:
URL: https://github.com/apache/incubator-iotdb/issues/1329
我的测试代码如下,连续执行两次,再执行select count(*) from root align by device,就会看到报错信息。
```java
package iotdb;
import java.sql.*;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
qiaojialin commented on a change in pull request #1337:
URL: https://github.com/apache/incubator-iotdb/pull/1337#discussion_r437479376
##
File path: session/src/main/java/org/apache/iotdb/session/pool/SessionPool.java
##
@@ -247,6 +262,16 @@ public void insertTablet(Tablet tabl
qiaojialin merged pull request #1323:
URL: https://github.com/apache/incubator-iotdb/pull/1323
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
sonarcloud[bot] commented on pull request #1335:
URL: https://github.com/apache/incubator-iotdb/pull/1335#issuecomment-641098113
This is an automated message from the Apache Git Service.
To respond to the message, please log o
jixuan1989 merged pull request #1305:
URL: https://github.com/apache/incubator-iotdb/pull/1305
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
JackieTien97 opened a new pull request #1328:
URL: https://github.com/apache/incubator-iotdb/pull/1328
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
sonarcloud[bot] removed a comment on pull request #1335:
URL: https://github.com/apache/incubator-iotdb/pull/1335#issuecomment-641098113
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1335&resolved=false&types=BUG)
sonarcloud[bot] commented on pull request #460:
URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-641012563
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=BUG)
[](https://sonarc
Alima777 closed issue #1340:
URL: https://github.com/apache/incubator-iotdb/issues/1340
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
puroc opened a new issue #1327:
URL: https://github.com/apache/incubator-iotdb/issues/1327
我的测试代码如下:
`
package iotdb;
import java.sql.*;
import java.text.ParseException;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Date;
import java.
jixuan1989 commented on pull request #1328:
URL: https://github.com/apache/incubator-iotdb/pull/1328#issuecomment-640689623
> Hi, should this PR be merged into `rel/0.10` ?
Ok.
By the way, pay attention to the code smell (use log.isWarnEnable() before
calling log.warn() beca
JackieTien97 opened a new pull request #1335:
URL: https://github.com/apache/incubator-iotdb/pull/1335
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
qiaojialin merged pull request #1335:
URL: https://github.com/apache/incubator-iotdb/pull/1335
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
JulianFeinauer commented on pull request #1323:
URL: https://github.com/apache/incubator-iotdb/pull/1323#issuecomment-640784724
Thanks all reviewers so far, especially the suggestion to change LeafMNode
name and to clarify intent (Add Measurements BELOW a Measurement(s), NOT add
device bel
JackieTien97 opened a new pull request #1336:
URL: https://github.com/apache/incubator-iotdb/pull/1336
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
sonarcloud[bot] commented on pull request #1323:
URL: https://github.com/apache/incubator-iotdb/pull/1323#issuecomment-640790037
This is an automated message from the Apache Git Service.
To respond to the message, please log o
samperson1997 commented on pull request #1328:
URL: https://github.com/apache/incubator-iotdb/pull/1328#issuecomment-640665353
Hi, should this PR be merged into `rel/0.10` ?
This is an automated message from the Apache Git Se
jt2594838 opened a new pull request #1338:
URL: https://github.com/apache/incubator-iotdb/pull/1338
1. Merge tasks can be aborted through a JMX interface. (needed by
distributed data removal)
2. Merge task status can be viewed via a JMX interface or using the "SHOW
MERGE STATUS" command
sonarcloud[bot] removed a comment on pull request #1305:
URL: https://github.com/apache/incubator-iotdb/pull/1305#issuecomment-640516218
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1305&resolved=false&types=BUG)
Alima777 opened a new issue #1340:
URL: https://github.com/apache/incubator-iotdb/issues/1340
Limit and Offset statement doesn't work in Session in 0.9.x version.
This is an automated message from the Apache Git Service.
qiaojialin merged pull request #1331:
URL: https://github.com/apache/incubator-iotdb/pull/1331
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
sonarcloud[bot] commented on pull request #1331:
URL: https://github.com/apache/incubator-iotdb/pull/1331#issuecomment-641004225
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1331&resolved=false&types=BUG)
[](http
qiaojialin closed issue #1329:
URL: https://github.com/apache/incubator-iotdb/issues/1329
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
sonarcloud[bot] commented on pull request #1338:
URL: https://github.com/apache/incubator-iotdb/pull/1338#issuecomment-641281671
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1338&resolved=false&types=BUG)
[](https://son
Ring-k opened a new issue #1334:
URL: https://github.com/apache/incubator-iotdb/issues/1334
**The Problem**
After compilation, double clicking the "start-server.bat" results in
quitting unexpectedly.
**Possible solution**
- Windows fails to execute when the path of "lib
sonarcloud[bot] commented on pull request #1336:
URL: https://github.com/apache/incubator-iotdb/pull/1336#issuecomment-641094264
This is an automated message from the Apache Git Service.
To respond to the message, please log o
sonarcloud[bot] removed a comment on pull request #460:
URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-640506082
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=BUG)
[](https:
sonarcloud[bot] removed a comment on pull request #1332:
URL: https://github.com/apache/incubator-iotdb/pull/1332#issuecomment-641112814
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1332&resolved=false&types=BUG)
JackieTien97 commented on issue #1329:
URL:
https://github.com/apache/incubator-iotdb/issues/1329#issuecomment-641058555
Thanks for your feedback.
The align by syntax will change the real series's type to the type of
aggregation, i.e. the FLOAT type is transferred to Long type in th
sonarcloud[bot] commented on pull request #1305:
URL: https://github.com/apache/incubator-iotdb/pull/1305#issuecomment-640534746
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1305&resolved=false&types=BUG)
[](http
sonarcloud[bot] commented on pull request #1328:
URL: https://github.com/apache/incubator-iotdb/pull/1328#issuecomment-640594767
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1328&resolved=false&types=BUG)
[](https://son
qiaojialin closed pull request #1330:
URL: https://github.com/apache/incubator-iotdb/pull/1330
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
jixuan1989 commented on pull request #1303:
URL: https://github.com/apache/incubator-iotdb/pull/1303#issuecomment-641168499
some suggestions:
1. use `latency` rather than `duration`;
2. use InsertPlan to write data rather than use SQL;
3. I think it is better to keep the
57 matches
Mail list logo