jixuan1989 commented on a change in pull request #1189:
URL: https://github.com/apache/incubator-iotdb/pull/1189#discussion_r444000793
##
File path: docs/UserGuide/9-Comparison/TSDB-Comparison.md
##
@@ -0,0 +1,400 @@
+
+
+## Known Time Series Database
+
+As the time series data
jixuan1989 commented on a change in pull request #1189:
URL: https://github.com/apache/incubator-iotdb/pull/1189#discussion_r443999277
##
File path: docs/UserGuide/9-Comparison/TSDB-Comparison.md
##
@@ -0,0 +1,400 @@
+
+
+## Known Time Series Database
+
+As the time series data
qiaojialin merged pull request #1402:
URL: https://github.com/apache/incubator-iotdb/pull/1402
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
jixuan1989 commented on a change in pull request #1189:
URL: https://github.com/apache/incubator-iotdb/pull/1189#discussion_r443993886
##
File path: docs/UserGuide/9-Comparison/TSDB-Comparison.md
##
@@ -0,0 +1,400 @@
+
+
+## Known Time Series Database
+
+As the time series data
JackieTien97 commented on a change in pull request #1401:
URL: https://github.com/apache/incubator-iotdb/pull/1401#discussion_r443965046
##
File path:
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##
@@ -1944,11 +1991,9 @@ private int
sonarcloud[bot] commented on pull request #1409:
URL: https://github.com/apache/incubator-iotdb/pull/1409#issuecomment-647901412
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1409&resolved=false&types=BUG)
[](http
jixuan1989 commented on issue #1327:
URL:
https://github.com/apache/incubator-iotdb/issues/1327#issuecomment-647899249
JDBC implementation is not thread-safe.
JDBC的实现不是线程安全的。
要做成连接池来测试。
This is an automated message
jt2594838 opened a new pull request #1409:
URL: https://github.com/apache/incubator-iotdb/pull/1409
Partitions can be removed with the following statement:
`DELETE PARTITION root.sg1 0,1,2,3,4` which deletes the first five
partitions of storage group root.sg1.
-
jixuan1989 commented on issue #1334:
URL:
https://github.com/apache/incubator-iotdb/issues/1334#issuecomment-647896925
#1377 has fixed the too long path issue for WinOS
This is an automated message from the Apache Git Servi
jixuan1989 closed issue #1334:
URL: https://github.com/apache/incubator-iotdb/issues/1334
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jixuan1989 commented on issue #1372:
URL:
https://github.com/apache/incubator-iotdb/issues/1372#issuecomment-647896531
1. Support paging.
you can define the fetch_size for query (avoid to use offset.. it is not
efficient)
支持分页，在查询时设置fetch_size就行。
另外，offset虽然能用于从第n行返回，但是性能并不是没
jixuan1989 merged pull request #1407:
URL: https://github.com/apache/incubator-iotdb/pull/1407
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
sonarcloud[bot] commented on pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#issuecomment-647891127
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1387&resolved=false&types=BUG)
[](http
mychaow opened a new pull request #1408:
URL: https://github.com/apache/incubator-iotdb/pull/1408
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
sonarcloud[bot] removed a comment on pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#issuecomment-647877532
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1387&resolved=false&types=BUG)
qiaojialin merged pull request #1384:
URL: https://github.com/apache/incubator-iotdb/pull/1384
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
sonarcloud[bot] removed a comment on pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#issuecomment-647852422
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1387&resolved=false&types=BUG)
sonarcloud[bot] commented on pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#issuecomment-647877532
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1387&resolved=false&types=BUG)
[](http
Ring-k commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r443933514
##
File path:
cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java
##
@@ -1520,12 +1534,31 @@ private TSStatus proces
sonarcloud[bot] removed a comment on pull request #460:
URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-647400573
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=BUG)
[](https:
sonarcloud[bot] commented on pull request #460:
URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-647874511
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=BUG)
[](https://sonarc
jt2594838 merged pull request #1405:
URL: https://github.com/apache/incubator-iotdb/pull/1405
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Alima777 commented on a change in pull request #1399:
URL: https://github.com/apache/incubator-iotdb/pull/1399#discussion_r443922053
##
File path:
server/src/main/java/org/apache/iotdb/db/qp/strategy/LogicalGenerator.java
##
@@ -223,6 +226,20 @@ public void enterFlush(FlushCon
jt2594838 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r443916570
##
File path:
cluster/src/main/java/org/apache/iotdb/cluster/server/member/DataGroupMember.java
##
@@ -1073,7 +1072,12 @@ public void pullTimeS
sonarcloud[bot] removed a comment on pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#issuecomment-647631179
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1387&resolved=false&types=BUG)
sonarcloud[bot] commented on pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#issuecomment-647852422
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1387&resolved=false&types=BUG)
[](http
Ring-k edited a comment on pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#issuecomment-647634978
> Good job. But I have a question: if you enable AutoCreation, the receiver
of the Insertion plan will create schemas locally and the sender will not sense
a schem
Ring-k commented on pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#issuecomment-647634978
> Good job. But I have a question: if you enable AutoCreation, the receiver
of the Insertion plan will create schemas locally and the sender will not sense
a schema missi
sonarcloud[bot] commented on pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#issuecomment-647631179
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1387&resolved=false&types=BUG)
[](http
sonarcloud[bot] removed a comment on pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#issuecomment-647603362
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1387&resolved=false&types=BUG)
Ring-k commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r443680766
##
File path: service-rpc/src/main/thrift/cluster.thrift
##
@@ -350,6 +350,8 @@ service TSDataService extends RaftService {
list getAggrResult
Ring-k commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r443679064
##
File path:
cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java
##
@@ -1520,12 +1534,31 @@ private TSStatus proces
Ring-k commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r443679383
##
File path:
cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java
##
@@ -1569,6 +1616,70 @@ TSStatus forwardPlan(Map
Ring-k commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r443676776
##
File path:
cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java
##
@@ -1569,6 +1616,70 @@ TSStatus forwardPlan(Map
sonarcloud[bot] commented on pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#issuecomment-647603362
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1387&resolved=false&types=BUG)
[](http
sonarcloud[bot] removed a comment on pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#issuecomment-645916156
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1387&resolved=false&types=BUG)
[](htt
Alima777 commented on a change in pull request #1399:
URL: https://github.com/apache/incubator-iotdb/pull/1399#discussion_r443637619
##
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##
@@ -524,10 +546,30 @@ public TSExecuteStatementResp
execute
sonarcloud[bot] commented on pull request #1407:
URL: https://github.com/apache/incubator-iotdb/pull/1407#issuecomment-647505030
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1407&resolved=false&types=BUG)
[](http
Alima777 commented on a change in pull request #1399:
URL: https://github.com/apache/incubator-iotdb/pull/1399#discussion_r443539139
##
File path:
server/src/main/java/org/apache/iotdb/db/query/reader/series/SeriesReader.java
##
@@ -251,6 +257,13 @@ private void
unpackAllOver
Alima777 commented on a change in pull request #1399:
URL: https://github.com/apache/incubator-iotdb/pull/1399#discussion_r443535053
##
File path: server/src/main/java/org/apache/iotdb/db/conf/IoTDBConfigCheck.java
##
@@ -125,24 +138,23 @@ private IoTDBConfigCheck() {
syst
Alima777 commented on a change in pull request #1399:
URL: https://github.com/apache/incubator-iotdb/pull/1399#discussion_r443534809
##
File path: server/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java
##
@@ -185,6 +184,11 @@
*/
private String syncDir = "data" +
jixuan1989 opened a new pull request #1407:
URL: https://github.com/apache/incubator-iotdb/pull/1407
ISSUE #1386 reports an issue that python client example can not connect to
iotdb instance.
It is because that the cluster module change the Server's thrift rpc from
BufferedTranspor
jixuan1989 commented on issue #1386:
URL:
https://github.com/apache/incubator-iotdb/issues/1386#issuecomment-647493709
Hi, current `pip install apche-iotdb` only support 0.9.x, so you can not use
it to connect to iotdb 0.10.x and the master branch.
By the way, the python client exam
qiaojialin commented on a change in pull request #1399:
URL: https://github.com/apache/incubator-iotdb/pull/1399#discussion_r443442334
##
File path:
server/src/main/java/org/apache/iotdb/db/qp/strategy/LogicalGenerator.java
##
@@ -223,6 +226,20 @@ public void enterFlush(FlushC
samperson1997 commented on pull request #1384:
URL: https://github.com/apache/incubator-iotdb/pull/1384#issuecomment-647405111
> Really good job! :)
> I'm not sure if it is necessary to add some tests.
Hi @HTHou , thanks! I will add a function for users to create snapshot
manually
HTHou commented on pull request #1384:
URL: https://github.com/apache/incubator-iotdb/pull/1384#issuecomment-647402548
Really good job! :)
I'm not sure if it is necessary to add some tests.
This is an automated message fr
sonarcloud[bot] commented on pull request #460:
URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-647400573
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=BUG)
[](https://sonarc
Alima777 opened a new pull request #1406:
URL: https://github.com/apache/incubator-iotdb/pull/1406
After PR#1335[1], the logic of align by device is changed a little.
And I think the explanation before is just describing by words, which is too
abstract to understand, especially in Ph
sonarcloud[bot] removed a comment on pull request #460:
URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-647300394
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=BUG)
[](https:
sonarcloud[bot] commented on pull request #1384:
URL: https://github.com/apache/incubator-iotdb/pull/1384#issuecomment-647373065
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1384&resolved=false&types=BUG)
[](http
sonarcloud[bot] removed a comment on pull request #1384:
URL: https://github.com/apache/incubator-iotdb/pull/1384#issuecomment-647346903
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1384&resolved=false&types=BUG)
SilverNarcissus commented on a change in pull request #1401:
URL: https://github.com/apache/incubator-iotdb/pull/1401#discussion_r443349363
##
File path:
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##
@@ -497,6 +509,34 @@ else if (up
qiaojialin merged pull request #1403:
URL: https://github.com/apache/incubator-iotdb/pull/1403
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
qiaojialin merged pull request #1404:
URL: https://github.com/apache/incubator-iotdb/pull/1404
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
neuyilan opened a new pull request #1405:
URL: https://github.com/apache/incubator-iotdb/pull/1405
Now, the distributed version do not support ALTER tag or attributes, this
PR[1] is used to add these functions.
I haved tested those ALTER statements[2] in the usergide and all executed
s
Alima777 commented on pull request #1399:
URL: https://github.com/apache/incubator-iotdb/pull/1399#issuecomment-647349562
> Great work!
> Just one suggestion. It would be better to add some doc of this new
feature. :)
Thank you~ I will add it later. :D
--
HTHou commented on pull request #1399:
URL: https://github.com/apache/incubator-iotdb/pull/1399#issuecomment-647348966
Great work!
Just one suggestion. It would be better to add some doc of this new feature.
:)
This is an
sonarcloud[bot] removed a comment on pull request #1384:
URL: https://github.com/apache/incubator-iotdb/pull/1384#issuecomment-647295595
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1384&resolved=false&types=BUG)
sonarcloud[bot] commented on pull request #1384:
URL: https://github.com/apache/incubator-iotdb/pull/1384#issuecomment-647346903
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1384&resolved=false&types=BUG)
[](http
samperson1997 commented on a change in pull request #1384:
URL: https://github.com/apache/incubator-iotdb/pull/1384#discussion_r443370490
##
File path: server/src/main/java/org/apache/iotdb/db/metadata/MTree.java
##
@@ -72,27 +80,34 @@
public class MTree implements Serializabl
samperson1997 commented on a change in pull request #1384:
URL: https://github.com/apache/incubator-iotdb/pull/1384#discussion_r443369289
##
File path: server/src/main/java/org/apache/iotdb/db/metadata/MTree.java
##
@@ -899,6 +918,69 @@ private void findNodes(MNode node, String
samperson1997 commented on a change in pull request #1384:
URL: https://github.com/apache/incubator-iotdb/pull/1384#discussion_r443367568
##
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##
@@ -1702,4 +1766,31 @@ public void cacheSchema(String path,
samperson1997 commented on a change in pull request #1384:
URL: https://github.com/apache/incubator-iotdb/pull/1384#discussion_r443366958
##
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##
@@ -1702,4 +1766,31 @@ public void cacheSchema(String path,
samperson1997 commented on a change in pull request #1384:
URL: https://github.com/apache/incubator-iotdb/pull/1384#discussion_r443366318
##
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##
@@ -1702,4 +1766,31 @@ public void cacheSchema(String path,
samperson1997 commented on a change in pull request #1384:
URL: https://github.com/apache/incubator-iotdb/pull/1384#discussion_r443363086
##
File path: server/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java
##
@@ -568,11 +568,21 @@
private int primitiveArraySize = 64
samperson1997 commented on a change in pull request #1384:
URL: https://github.com/apache/incubator-iotdb/pull/1384#discussion_r443362901
##
File path: docs/SystemDesign/SchemaManager/SchemaManager.md
##
@@ -175,6 +175,16 @@ The root node exists by default. Creating storage gro
66 matches
Mail list logo
