[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2016: fix grafana bug

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2016: URL: https://github.com/apache/iotdb/pull/2016#issuecomment-729504765 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2016&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] w169q169 commented on a change in pull request #2016: fix grafana bug

2020-11-17 Thread GitBox
w169q169 commented on a change in pull request #2016: URL: https://github.com/apache/iotdb/pull/2016#discussion_r525870202 ## File path: grafana/src/main/java/org/apache/iotdb/web/grafana/dao/impl/BasicDaoImpl.java ## @@ -133,31 +133,44 @@ public static void setTimestampRadioX

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2063: Refactor LastQueryExecutor to separate the execution into multiple stages

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2063: URL: https://github.com/apache/iotdb/pull/2063#issuecomment-729488420 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2063&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #2063: Refactor LastQueryExecutor to separate the execution into multiple stages

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #2063: URL: https://github.com/apache/iotdb/pull/2063#issuecomment-729484393 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2063&resolved=false&types=BUG) [](https://sonar

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2068: change TsFile size threshold

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2068: URL: https://github.com/apache/iotdb/pull/2068#issuecomment-729487030 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2068&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #2068: change TsFile size threshold

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #2068: URL: https://github.com/apache/iotdb/pull/2068#issuecomment-729471521 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2068&resolved=false&types=BUG) [](https:

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #2065: fix transport not close

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #2065: URL: https://github.com/apache/iotdb/pull/2065#issuecomment-729376371 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2065&resolved=false&types=BUG) [](https:

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2065: fix transport not close

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2065: URL: https://github.com/apache/iotdb/pull/2065#issuecomment-729486767 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2065&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2063: Refactor LastQueryExecutor to separate the execution into multiple stages

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2063: URL: https://github.com/apache/iotdb/pull/2063#issuecomment-729484393 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2063&resolved=false&types=BUG) [](https://sonarcloud.io

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #2063: Refactor LastQueryExecutor to separate the execution into multiple stages

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #2063: URL: https://github.com/apache/iotdb/pull/2063#issuecomment-729479199 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2063&resolved=false&types=BUG) [](https://sonar

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2063: Refactor LastQueryExecutor to separate the execution into multiple stages

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2063: URL: https://github.com/apache/iotdb/pull/2063#issuecomment-729479199 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2063&resolved=false&types=BUG) [](https://sonarcloud.io

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #2063: Refactor LastQueryExecutor to separate the execution into multiple stages

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #2063: URL: https://github.com/apache/iotdb/pull/2063#issuecomment-729455835 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2063&resolved=false&types=BUG) [](https:

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1968: Fix the risk of deadlock by WeakReference

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #1968: URL: https://github.com/apache/iotdb/pull/1968#issuecomment-729476586 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1968&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2048: Fix resource leak in TsFileOutputFormat

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2048: URL: https://github.com/apache/iotdb/pull/2048#issuecomment-729474889 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2048&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2068: change TsFile size threshold

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2068: URL: https://github.com/apache/iotdb/pull/2068#issuecomment-729471521 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2068&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1721: [IOTDB-868] fix comma bug for mlog

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #1721: URL: https://github.com/apache/iotdb/pull/1721#issuecomment-729467946 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1721&resolved=false&types=BUG) [](https://sonarcloud.io

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2067: Fix level compaction recover file not exist bug

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2067: URL: https://github.com/apache/iotdb/pull/2067#issuecomment-729467451 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2067&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] Genius-pig commented on pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
Genius-pig commented on pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#issuecomment-729464023 > Please add more tests for: > > 1. exporting aggregation query results > 2. importing/exporting query date sets with special characters added. ---

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2066: [To rel/0.11] change default TsFile size threshold

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2066: URL: https://github.com/apache/iotdb/pull/2066#issuecomment-729462655 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2066&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] HTHou opened a new pull request #2068: change TsFile size threshold

2020-11-17 Thread GitBox
HTHou opened a new pull request #2068: URL: https://github.com/apache/iotdb/pull/2068 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#issuecomment-729331696 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1914&resolved=false&types=BUG) [](https:

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#issuecomment-729458704 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1914&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] zhanglingzhe0820 opened a new pull request #2067: Fix level compaction recover file not exist bug

2020-11-17 Thread GitBox
zhanglingzhe0820 opened a new pull request #2067: URL: https://github.com/apache/iotdb/pull/2067 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2063: Refactor LastQueryExecutor to separate the execution into multiple stages

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2063: URL: https://github.com/apache/iotdb/pull/2063#issuecomment-729455835 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2063&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #2063: Refactor LastQueryExecutor to separate the execution into multiple stages

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #2063: URL: https://github.com/apache/iotdb/pull/2063#issuecomment-729334009 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2063&resolved=false&types=BUG) [](https:

[GitHub] [iotdb] HTHou opened a new pull request #2066: [To rel/0.11] change default TsFile size threshold

2020-11-17 Thread GitBox
HTHou opened a new pull request #2066: URL: https://github.com/apache/iotdb/pull/2066 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [iotdb] qiaojialin merged pull request #2027: Fix thread safety issues in SyncServerManager

2020-11-17 Thread GitBox
qiaojialin merged pull request #2027: URL: https://github.com/apache/iotdb/pull/2027 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [iotdb] qiaojialin commented on pull request #2047: Use SHA-256 instead of MD5 for less hash collision and more safety

2020-11-17 Thread GitBox
qiaojialin commented on pull request #2047: URL: https://github.com/apache/iotdb/pull/2047#issuecomment-729404601 @asdf2014 Hi, using digest is better! and please merge the master branch, the ci is fixed~ This is an automa

[GitHub] [iotdb] qiaojialin commented on pull request #2048: Fix resource leak in TsFileOutputFormat

2020-11-17 Thread GitBox
qiaojialin commented on pull request #2048: URL: https://github.com/apache/iotdb/pull/2048#issuecomment-729404329 Hi, please merge the master branch, the ci is fixed~ This is an automated message from the Apache Git Service.

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #2064: [Distributed]fix sonar code smells

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #2064: URL: https://github.com/apache/iotdb/pull/2064#issuecomment-729354761 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2064&resolved=false&types=BUG) [](https:

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2064: [Distributed]fix sonar code smells

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2064: URL: https://github.com/apache/iotdb/pull/2064#issuecomment-729396155 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2064&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2065: fix transport not close

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2065: URL: https://github.com/apache/iotdb/pull/2065#issuecomment-729376371 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2065&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] mychaow opened a new pull request #2065: fix transport not close

2020-11-17 Thread GitBox
mychaow opened a new pull request #2065: URL: https://github.com/apache/iotdb/pull/2065 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #2064: [Distributed]fix sonar code smells

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #2064: URL: https://github.com/apache/iotdb/pull/2064#issuecomment-729348786 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2064&resolved=false&types=BUG) [](https:

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2064: [Distributed]fix sonar code smells

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2064: URL: https://github.com/apache/iotdb/pull/2064#issuecomment-729354761 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2064&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2064: [Distributed]fix sonar code smells

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2064: URL: https://github.com/apache/iotdb/pull/2064#issuecomment-729348786 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2064&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #2064: [Distributed]fix sonar code smells

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #2064: URL: https://github.com/apache/iotdb/pull/2064#issuecomment-728901667 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2064&resolved=false&types=BUG) [](https:

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2063: Refactor LastQueryExecutor to separate the execution into multiple stages

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2063: URL: https://github.com/apache/iotdb/pull/2063#issuecomment-729334009 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2063&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #2063: Refactor LastQueryExecutor to separate the execution into multiple stages

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #2063: URL: https://github.com/apache/iotdb/pull/2063#issuecomment-728922706 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2063&resolved=false&types=BUG) [](https:

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#issuecomment-729329643 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1914&resolved=false&types=BUG) [](https:

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#issuecomment-729331696 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1914&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] kr11 merged pull request #2024: [IoTDB-804] Index framework: from SQL to PhysicalPlan

2020-11-17 Thread GitBox
kr11 merged pull request #2024: URL: https://github.com/apache/iotdb/pull/2024 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [iotdb] kr11 removed a comment on pull request #2024: [IoTDB-804] Index framework: from SQL to PhysicalPlan

2020-11-17 Thread GitBox
kr11 removed a comment on pull request #2024: URL: https://github.com/apache/iotdb/pull/2024#issuecomment-729330326 [IoTDB-804] Index framework: from SQL to PhysicalPlan #2024 This is an automated message from the Apache Git

[GitHub] [iotdb] kr11 commented on pull request #2024: [IoTDB-804] Index framework: from SQL to PhysicalPlan

2020-11-17 Thread GitBox
kr11 commented on pull request #2024: URL: https://github.com/apache/iotdb/pull/2024#issuecomment-729330326 [IoTDB-804] Index framework: from SQL to PhysicalPlan #2024 This is an automated message from the Apache Git Service.

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#issuecomment-729328740 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1914&resolved=false&types=BUG) [](https:

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#issuecomment-729329643 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1914&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] Genius-pig commented on a change in pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
Genius-pig commented on a change in pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#discussion_r525648414 ## File path: cli/src/test/java/org/apache/iotdb/tool/CsvLineSplitTest.java ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [iotdb] Genius-pig commented on a change in pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
Genius-pig commented on a change in pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#discussion_r525648378 ## File path: README_ZH.md ## @@ -347,16 +347,19 @@ CREATE TIMESERIES root.fit.d2.s1 WITH DATATYPE=INT32,ENCODING=RLE; CREATE TIMESERIES root.fit.d2.s3

[GitHub] [iotdb] Genius-pig commented on a change in pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
Genius-pig commented on a change in pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#discussion_r525648306 ## File path: README.md ## @@ -347,14 +348,17 @@ CREATE TIMESERIES root.fit.d2.s3 WITH DATATYPE=INT32,ENCODING=RLE; CREATE TIMESERIES root.fit.p.s1 WIT

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#issuecomment-727774422 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1914&resolved=false&types=BUG) [](https:

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#issuecomment-729328740 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1914&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #2024: [IoTDB-804] Index framework: from SQL to PhysicalPlan

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #2024: URL: https://github.com/apache/iotdb/pull/2024#issuecomment-728654643 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2024&resolved=false&types=BUG) [](https:

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2024: [IoTDB-804] Index framework: from SQL to PhysicalPlan

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2024: URL: https://github.com/apache/iotdb/pull/2024#issuecomment-729323784 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2024&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] SteveYurongSu commented on pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
SteveYurongSu commented on pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#issuecomment-729011195 Please add more tests for: 1. exporting aggregation query results 2. importing / exporting query date sets with special characters

[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
SteveYurongSu commented on a change in pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#discussion_r525236947 ## File path: cli/src/main/java/org/apache/iotdb/tool/ImportCsv.java ## @@ -119,296 +88,78 @@ private static Options createOptions() { /** * Da

[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
SteveYurongSu commented on a change in pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#discussion_r525205205 ## File path: cli/src/main/java/org/apache/iotdb/tool/ExportCsv.java ## @@ -263,112 +228,104 @@ private static void dumpResult(String sql, int index)

[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
SteveYurongSu commented on a change in pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#discussion_r525217212 ## File path: cli/src/test/java/org/apache/iotdb/tool/CsvLineSplitTest.java ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
SteveYurongSu commented on a change in pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#discussion_r525205205 ## File path: cli/src/main/java/org/apache/iotdb/tool/ExportCsv.java ## @@ -263,112 +228,104 @@ private static void dumpResult(String sql, int index)

[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
SteveYurongSu commented on a change in pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#discussion_r525164730 ## File path: README.md ## @@ -347,14 +348,17 @@ CREATE TIMESERIES root.fit.d2.s3 WITH DATATYPE=INT32,ENCODING=RLE; CREATE TIMESERIES root.fit.p.s1

[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
SteveYurongSu commented on a change in pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#discussion_r525170999 ## File path: README_ZH.md ## @@ -347,16 +347,19 @@ CREATE TIMESERIES root.fit.d2.s1 WITH DATATYPE=INT32,ENCODING=RLE; CREATE TIMESERIES root.fit.d2

[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
SteveYurongSu commented on a change in pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#discussion_r525164730 ## File path: README.md ## @@ -347,14 +348,17 @@ CREATE TIMESERIES root.fit.d2.s3 WITH DATATYPE=INT32,ENCODING=RLE; CREATE TIMESERIES root.fit.p.s1

[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
SteveYurongSu commented on a change in pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#discussion_r525165134 ## File path: README_ZH.md ## @@ -347,16 +347,19 @@ CREATE TIMESERIES root.fit.d2.s1 WITH DATATYPE=INT32,ENCODING=RLE; CREATE TIMESERIES root.fit.d2

[GitHub] [iotdb] jt2594838 commented on a change in pull request #2063: Refactor LastQueryExecutor to separate the execution into multiple stages

2020-11-17 Thread GitBox
jt2594838 commented on a change in pull request #2063: URL: https://github.com/apache/iotdb/pull/2063#discussion_r525158766 ## File path: server/src/main/java/org/apache/iotdb/db/query/executor/QueryRouter.java ## @@ -225,12 +225,8 @@ public QueryDataSet groupByFill(GroupByTim

[GitHub] [iotdb] qiaojialin commented on a change in pull request #2063: Refactor LastQueryExecutor to separate the execution into multiple stages

2020-11-17 Thread GitBox
qiaojialin commented on a change in pull request #2063: URL: https://github.com/apache/iotdb/pull/2063#discussion_r525154948 ## File path: server/src/main/java/org/apache/iotdb/db/query/executor/QueryRouter.java ## @@ -225,12 +225,8 @@ public QueryDataSet groupByFill(GroupByTi

[GitHub] [iotdb] qiaojialin commented on a change in pull request #2063: Refactor LastQueryExecutor to separate the execution into multiple stages

2020-11-17 Thread GitBox
qiaojialin commented on a change in pull request #2063: URL: https://github.com/apache/iotdb/pull/2063#discussion_r525154948 ## File path: server/src/main/java/org/apache/iotdb/db/query/executor/QueryRouter.java ## @@ -225,12 +225,8 @@ public QueryDataSet groupByFill(GroupByTi

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2063: Refactor LastQueryExecutor to separate the execution into multiple stages

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2063: URL: https://github.com/apache/iotdb/pull/2063#issuecomment-728922706 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2063&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #2063: Refactor LastQueryExecutor to separate the execution into multiple stages

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #2063: URL: https://github.com/apache/iotdb/pull/2063#issuecomment-728876334 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2063&resolved=false&types=BUG) [](https:

[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #1914: [IOTDB-937] change jdbc into session and don't need to create metadata

2020-11-17 Thread GitBox
SteveYurongSu commented on a change in pull request #1914: URL: https://github.com/apache/iotdb/pull/1914#discussion_r525135730 ## File path: README.md ## @@ -347,14 +348,17 @@ CREATE TIMESERIES root.fit.d2.s3 WITH DATATYPE=INT32,ENCODING=RLE; CREATE TIMESERIES root.fit.p.s1

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #2064: [Distributed]fix sonar code smells

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #2064: URL: https://github.com/apache/iotdb/pull/2064#issuecomment-728889460 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2064&resolved=false&types=BUG) [](https:

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2064: [Distributed]fix sonar code smells

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2064: URL: https://github.com/apache/iotdb/pull/2064#issuecomment-728901667 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2064&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/iotdb/pull/460#issuecomment-728898651 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=BUG) [](https://sonarclou

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/iotdb/pull/460#issuecomment-728687880 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=BUG) [](https://s

[GitHub] [iotdb] jt2594838 merged pull request #2059: [Distributed] Fix the checking applied log thread abnormal exits bug

2020-11-17 Thread GitBox
jt2594838 merged pull request #2059: URL: https://github.com/apache/iotdb/pull/2059 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2064: [Distributed]fix sonar code smells

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2064: URL: https://github.com/apache/iotdb/pull/2064#issuecomment-728889460 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2064&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] neuyilan opened a new pull request #2064: [Distributed]fix sonar code smells

2020-11-17 Thread GitBox
neuyilan opened a new pull request #2064: URL: https://github.com/apache/iotdb/pull/2064 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2057: Add Comment on cluster_new branch

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2057: URL: https://github.com/apache/iotdb/pull/2057#issuecomment-728882813 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2057&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2029: [IOTDB-825] aggregation by natural month

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2029: URL: https://github.com/apache/iotdb/pull/2029#issuecomment-728882859 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2029&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #2029: [IOTDB-825] aggregation by natural month

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #2029: URL: https://github.com/apache/iotdb/pull/2029#issuecomment-728770545 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2029&resolved=false&types=BUG) [](https:

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #2057: Add Comment on cluster_new branch

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #2057: URL: https://github.com/apache/iotdb/pull/2057#issuecomment-728752966 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2057&resolved=false&types=BUG) [](https:

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2063: Refactor LastQueryExecutor to separate the execution into multiple stages

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2063: URL: https://github.com/apache/iotdb/pull/2063#issuecomment-728876334 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2063&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] wshao08 opened a new pull request #2063: Refactor LastQueryExecutor to separate the execution into multiple stages

2020-11-17 Thread GitBox
wshao08 opened a new pull request #2063: URL: https://github.com/apache/iotdb/pull/2063 A merge lock has already been added locking the whole Last query procedure, however, this procedure may take a long time. This PR refactor the Last query execution process, separating it into multip

[GitHub] [iotdb] qiaojialin merged pull request #2054: change some mem control default parameters: flush proportion and block time

2020-11-17 Thread GitBox
qiaojialin merged pull request #2054: URL: https://github.com/apache/iotdb/pull/2054 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [iotdb] qiaojialin merged pull request #2053: [To rel/0.11] change some mem control default parameters: flush proportion and block time

2020-11-17 Thread GitBox
qiaojialin merged pull request #2053: URL: https://github.com/apache/iotdb/pull/2053 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [iotdb] qiaojialin merged pull request #2045: [IOTDB-990] cli parameter maxPRC shouldn't to be set zero

2020-11-17 Thread GitBox
qiaojialin merged pull request #2045: URL: https://github.com/apache/iotdb/pull/2045 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [iotdb] qiaojialin merged pull request #2055: [IOTDB-990] [To rel/0.11] cli parameter maxPRC shouldn't to be set zero

2020-11-17 Thread GitBox
qiaojialin merged pull request #2055: URL: https://github.com/apache/iotdb/pull/2055 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [iotdb] qiaojialin merged pull request #2061: Fix level compaction file not exist bug

2020-11-17 Thread GitBox
qiaojialin merged pull request #2061: URL: https://github.com/apache/iotdb/pull/2061 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2062: [IOTDB-1012] Remove unfriendly query process error for users

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2062: URL: https://github.com/apache/iotdb/pull/2062#issuecomment-728820610 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2062&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] samperson1997 opened a new pull request #2062: [IOTDB-1012] Remove unfriendly query process error for users

2020-11-17 Thread GitBox
samperson1997 opened a new pull request #2062: URL: https://github.com/apache/iotdb/pull/2062 When selecting non-exist timeseries, an error message will be logged: ``` "411: Meet error in query process: org.apache.iotdb.db.exception.metadata.PathNotExistException: Path [root]

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #2029: [IOTDB-825] aggregation by natural month

2020-11-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #2029: URL: https://github.com/apache/iotdb/pull/2029#issuecomment-728720418 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2029&resolved=false&types=BUG) [](https:

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2029: [IOTDB-825] aggregation by natural month

2020-11-17 Thread GitBox
sonarcloud[bot] commented on pull request #2029: URL: https://github.com/apache/iotdb/pull/2029#issuecomment-728770545 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2029&resolved=false&types=BUG) [](https://sonarc

[GitHub] [iotdb] haimeiguo commented on a change in pull request #2029: [IOTDB-825] aggregation by natural month

2020-11-17 Thread GitBox
haimeiguo commented on a change in pull request #2029: URL: https://github.com/apache/iotdb/pull/2029#discussion_r524961880 ## File path: server/src/main/java/org/apache/iotdb/db/query/dataset/groupby/GroupByEngineDataSet.java ## @@ -70,36 +77,69 @@ public GroupByEngineDataSet