[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8619: [IOTDB-5291] Add TiFile to Tag Model, support disk flush and query

2023-01-01 Thread GitBox
MarcosZyk commented on code in PR #8619: URL: https://github.com/apache/iotdb/pull/8619#discussion_r1059817762 ## schema-engine-tag/src/main/java/org/apache/iotdb/db/metadata/tagSchemaRegion/tagIndex/flush/MemChunkGroupFlush.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apac

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8619: [IOTDB-5291] Add TiFile to Tag Model, support disk flush and query

2023-01-01 Thread GitBox
MarcosZyk commented on code in PR #8619: URL: https://github.com/apache/iotdb/pull/8619#discussion_r1059865519 ## schema-engine-tag/src/main/java/org/apache/iotdb/lsm/sstable/fileIO/FileOutput.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8671: [lemming-5303] Refine IT: Make cluster properties mutable from outside file and developer coding easily

2023-01-01 Thread GitBox
sonarcloud[bot] commented on PR #8671: URL: https://github.com/apache/iotdb/pull/8671#issuecomment-1368705903 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] Cpaulyz opened a new pull request, #8697: [To rel/0.13][IOTDB-5133] Add log for export schema tool

2023-01-01 Thread GitBox
Cpaulyz opened a new pull request, #8697: URL: https://github.com/apache/iotdb/pull/8697 ## Description Add log for export schema tool -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [iotdb] MarcosZyk merged pull request #8696: [To rel/0.13][IOTDB-5133] Move export schame tool docs to Maintenance-Tools

2023-01-01 Thread GitBox
MarcosZyk merged PR #8696: URL: https://github.com/apache/iotdb/pull/8696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] Cpaulyz opened a new pull request, #8696: [To rel/0.13][IOTDB-5133] Move export schame tool docs to Maintenance-Tools

2023-01-01 Thread GitBox
Cpaulyz opened a new pull request, #8696: URL: https://github.com/apache/iotdb/pull/8696 ## Description Move export schame tool docs to Maintenance-Tools -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [iotdb] Cpaulyz opened a new pull request, #8695: [IOTDB-5133] Add 0.13 Export-Schema document to website config

2023-01-01 Thread GitBox
Cpaulyz opened a new pull request, #8695: URL: https://github.com/apache/iotdb/pull/8695 ### Description Add 0.13 Export-Schema document to website config -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #8661: [IOTDB-5253] Fix chunkMetadata mem metric

2023-01-01 Thread GitBox
SpriCoder commented on code in PR #8661: URL: https://github.com/apache/iotdb/pull/8661#discussion_r1059843775 ## server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessorInfoMetrics.java: ## @@ -64,11 +65,12 @@ public boolean equals(Object o) { if (this

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #8663: [To rel/0.13][IOTDB-5253] Fix chunkMetadata mem metric

2023-01-01 Thread GitBox
SpriCoder commented on code in PR #8663: URL: https://github.com/apache/iotdb/pull/8663#discussion_r1059843745 ## server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessorInfoMetrics.java: ## @@ -65,11 +66,12 @@ public boolean equals(Object o) { if (this

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #8662: [To rel/1.0][IOTDB-5253] Fix chunkMetadata mem metric

2023-01-01 Thread GitBox
SpriCoder commented on code in PR #8662: URL: https://github.com/apache/iotdb/pull/8662#discussion_r1059843691 ## server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessorInfoMetrics.java: ## @@ -64,11 +65,12 @@ public boolean equals(Object o) { if (this

[GitHub] [iotdb] jun0315 commented on a diff in pull request #8619: [IOTDB-5291] Add TiFile to Tag Model, support disk flush and query

2023-01-01 Thread GitBox
jun0315 commented on code in PR #8619: URL: https://github.com/apache/iotdb/pull/8619#discussion_r1059839564 ## schema-engine-tag/src/main/java/org/apache/iotdb/db/metadata/tagSchemaRegion/tagIndex/flush/MemTableFlush.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Soft

[GitHub] [iotdb] jun0315 commented on a diff in pull request #8619: [IOTDB-5291] Add TiFile to Tag Model, support disk flush and query

2023-01-01 Thread GitBox
jun0315 commented on code in PR #8619: URL: https://github.com/apache/iotdb/pull/8619#discussion_r1059839564 ## schema-engine-tag/src/main/java/org/apache/iotdb/db/metadata/tagSchemaRegion/tagIndex/flush/MemTableFlush.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Soft

[GitHub] [iotdb] jun0315 commented on a diff in pull request #8619: [IOTDB-5291] Add TiFile to Tag Model, support disk flush and query

2023-01-01 Thread GitBox
jun0315 commented on code in PR #8619: URL: https://github.com/apache/iotdb/pull/8619#discussion_r1059839564 ## schema-engine-tag/src/main/java/org/apache/iotdb/db/metadata/tagSchemaRegion/tagIndex/flush/MemTableFlush.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Soft

[GitHub] [iotdb] xingtanzjr merged pull request #8694: Fix conflicts in compaction test

2023-01-01 Thread GitBox
xingtanzjr merged PR #8694: URL: https://github.com/apache/iotdb/pull/8694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] xingtanzjr commented on pull request #8694: Fix conflicts in compaction test

2023-01-01 Thread GitBox
xingtanzjr commented on PR #8694: URL: https://github.com/apache/iotdb/pull/8694#issuecomment-1368654562 ![image](https://user-images.githubusercontent.com/18027703/210195811-fda33009-e16f-4d70-ac0d-93ab799572c5.png) Tests passed -- This is an automated message from the Apache Git

[GitHub] [iotdb] xingtanzjr commented on pull request #8694: Fix conflicts in compaction test

2023-01-01 Thread GitBox
xingtanzjr commented on PR #8694: URL: https://github.com/apache/iotdb/pull/8694#issuecomment-1368652228 ![image](https://user-images.githubusercontent.com/18027703/210195343-9cd5316b-8c87-4da1-ac6a-cae3a0244f17.png) Local compile passed. -- This is an automated message from the Ap

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8656: [IOTDB-5284] Fix some code smells

2023-01-01 Thread GitBox
OneSizeFitsQuorum merged PR #8656: URL: https://github.com/apache/iotdb/pull/8656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8647: [IOTDB-5284] Fix some code smells

2023-01-01 Thread GitBox
OneSizeFitsQuorum merged PR #8647: URL: https://github.com/apache/iotdb/pull/8647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8693: [To rel/1.0][IOTDB-5327] Move Apache IoTDB Dashboard and update doc

2023-01-01 Thread GitBox
OneSizeFitsQuorum merged PR #8693: URL: https://github.com/apache/iotdb/pull/8693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8692: [IOTDB-5327] Move Apache IoTDB Dashboard and update doc

2023-01-01 Thread GitBox
OneSizeFitsQuorum merged PR #8692: URL: https://github.com/apache/iotdb/pull/8692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #8662: [To rel/1.0][IOTDB-5253] Fix chunkMetadata mem metric

2023-01-01 Thread GitBox
OneSizeFitsQuorum commented on code in PR #8662: URL: https://github.com/apache/iotdb/pull/8662#discussion_r1059828077 ## server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessorInfoMetrics.java: ## @@ -64,11 +65,12 @@ public boolean equals(Object o) { i

[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #8663: [To rel/0.13][IOTDB-5253] Fix chunkMetadata mem metric

2023-01-01 Thread GitBox
OneSizeFitsQuorum commented on code in PR #8663: URL: https://github.com/apache/iotdb/pull/8663#discussion_r1059828031 ## server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessorInfoMetrics.java: ## @@ -65,11 +66,12 @@ public boolean equals(Object o) { i

[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #8661: [IOTDB-5253] Fix chunkMetadata mem metric

2023-01-01 Thread GitBox
OneSizeFitsQuorum commented on code in PR #8661: URL: https://github.com/apache/iotdb/pull/8661#discussion_r1059827965 ## server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessorInfoMetrics.java: ## @@ -64,11 +65,12 @@ public boolean equals(Object o) { i

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8619: [IOTDB-5291] Add TiFile to Tag Model, support disk flush and query

2023-01-01 Thread GitBox
MarcosZyk commented on code in PR #8619: URL: https://github.com/apache/iotdb/pull/8619#discussion_r1059818026 ## schema-engine-tag/src/main/java/org/apache/iotdb/db/metadata/tagSchemaRegion/tagIndex/flush/MemChunkGroupFlush.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apac

[GitHub] [iotdb] THUMarkLau merged pull request #8615: [IOTDB-5286]Fix target files should not be select to participate in other compaction task

2023-01-01 Thread GitBox
THUMarkLau merged PR #8615: URL: https://github.com/apache/iotdb/pull/8615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] THUMarkLau merged pull request #8637: [To rel/1.0][IOTDB-5286]Fix target files should not be select to participate in other compaction task

2023-01-01 Thread GitBox
THUMarkLau merged PR #8637: URL: https://github.com/apache/iotdb/pull/8637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] THUMarkLau merged pull request #8668: [IOTDB-5311]Fix RunTimeException and NoSuchFile Exception when selecting files causing compaction scheduled thread to get stuck

2023-01-01 Thread GitBox
THUMarkLau merged PR #8668: URL: https://github.com/apache/iotdb/pull/8668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] THUMarkLau merged pull request #8669: [To rel/1.0][IOTDB-5311]Fix RunTimeException and NoSuchFile Exception when selecting files causing compaction scheduled thread to get stuck

2023-01-01 Thread GitBox
THUMarkLau merged PR #8669: URL: https://github.com/apache/iotdb/pull/8669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] SpriCoder opened a new pull request, #8693: [To rel/1.0][IOTDB-5327] Move Apache IoTDB Dashboard and update doc

2023-01-01 Thread GitBox
SpriCoder opened a new pull request, #8693: URL: https://github.com/apache/iotdb/pull/8693 https://issues.apache.org/jira/browse/IOTDB-5327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [iotdb] SpriCoder opened a new pull request, #8692: [IOTDB-5327] Move Apache IoTDB Dashboard and update doc

2023-01-01 Thread GitBox
SpriCoder opened a new pull request, #8692: URL: https://github.com/apache/iotdb/pull/8692 https://issues.apache.org/jira/browse/IOTDB-5327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [iotdb] lancelly commented on a diff in pull request #8683: Fix bug in last query

2023-01-01 Thread GitBox
lancelly commented on code in PR #8683: URL: https://github.com/apache/iotdb/pull/8683#discussion_r1059731095 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/distribution/SourceRewriter.java: ## @@ -525,13 +528,46 @@ public List visitLastQuery(LastQueryNode node, D

[GitHub] [iotdb] lancelly commented on a diff in pull request #8683: Fix bug in last query

2023-01-01 Thread GitBox
lancelly commented on code in PR #8683: URL: https://github.com/apache/iotdb/pull/8683#discussion_r1059731038 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/distribution/SourceRewriter.java: ## @@ -525,13 +528,46 @@ public List visitLastQuery(LastQueryNode node, D

[GitHub] [iotdb] HTHou merged pull request #8691: [To rel/1.0] Optimize write redirection logic (#8687)

2023-01-01 Thread GitBox
HTHou merged PR #8691: URL: https://github.com/apache/iotdb/pull/8691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] lancelly commented on a diff in pull request #8683: Fix bug in last query

2023-01-01 Thread GitBox
lancelly commented on code in PR #8683: URL: https://github.com/apache/iotdb/pull/8683#discussion_r1059728166 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/distribution/SourceRewriter.java: ## @@ -525,13 +528,46 @@ public List visitLastQuery(LastQueryNode node, D

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8691: [To rel/1.0] Optimize write redirection logic (#8687)

2023-01-01 Thread GitBox
sonarcloud[bot] commented on PR #8691: URL: https://github.com/apache/iotdb/pull/8691#issuecomment-1368389306 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] qiaojialin opened a new pull request, #8691: [To rel/1.0] Optimize write redirection logic (#8687)

2023-01-01 Thread GitBox
qiaojialin opened a new pull request, #8691: URL: https://github.com/apache/iotdb/pull/8691 cherry pick from https://github.com/apache/iotdb/pull/8687 redirect writing only if the redirectEndPoint is not the current node when statusCode == TSStatusCode.SUCCESS_STATUS, a 'no detailed

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8671: [lemming-5303] Refine IT: Make cluster properties mutable from outside file and developer coding easily

2023-01-01 Thread GitBox
sonarcloud[bot] commented on PR #8671: URL: https://github.com/apache/iotdb/pull/8671#issuecomment-1368384508 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] SpriCoder commented on pull request #8529: [IOTDB-5171] Add query metrics

2023-01-01 Thread GitBox
SpriCoder commented on PR #8529: URL: https://github.com/apache/iotdb/pull/8529#issuecomment-1368382288 Please update the metric doc at the same time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go