[GitHub] [iotdb] yschengzi commented on issue #8618: 关于0.13版本的TsFile 同步方式bug

2023-01-03 Thread GitBox
yschengzi commented on issue #8618: URL: https://github.com/apache/iotdb/issues/8618#issuecomment-1370589054 不好意思,漏了一些步骤,请按下面的步骤重新让发送端接收端保持一致 1.关闭发送端的同步脚本 2.删除发送端IOTDB_HOME/data/data下所有sync开头的文件夹(一般是sync-sender) 3.删除发送端IOTDB_HOME/data/system/sync文件夹 4.重启接收端 5.重启发送端同步脚本 注意让发送

[GitHub] [iotdb] BUAAserein opened a new pull request, #8738: [IOTDB-5284] Fix some code smells

2023-01-03 Thread GitBox
BUAAserein opened a new pull request, #8738: URL: https://github.com/apache/iotdb/pull/8738 ## Description ### Fix some code smells in server [iotdb-server], please see in [JIRA5284](https://issues.apache.org/jira/browse/IOTDB-5284) -- This is an automated message from the Apac

[GitHub] [iotdb] HTHou commented on issue #8602: [Bug] 使用SessionPool连接集群,insertAlignedTablets接口报错:获取session超时

2023-01-03 Thread GitBox
HTHou commented on issue #8602: URL: https://github.com/apache/iotdb/issues/8602#issuecomment-1370575697 Cannot reproduce in v0.13 and v1.0... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [iotdb] neuyilan merged pull request #8673: fix the wal comment

2023-01-03 Thread GitBox
neuyilan merged PR #8673: URL: https://github.com/apache/iotdb/pull/8673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apach

[GitHub] [iotdb] choubenson opened a new pull request, #8737: [IOTDB-5206] Set empty target resource to DELETED and then delete it after compaction

2023-01-03 Thread GitBox
choubenson opened a new pull request, #8737: URL: https://github.com/apache/iotdb/pull/8737 **Description** After compaction, if the target file is empty, its corresponding disk file will be deleted. If an exception or system interruption occurs, there will be problems in restart recover

[GitHub] [iotdb] choubenson opened a new pull request, #8736: [IOTDB-5206] Set empty target resource to DELETED and then delete it after compaction

2023-01-03 Thread GitBox
choubenson opened a new pull request, #8736: URL: https://github.com/apache/iotdb/pull/8736 **Description** After compaction, if the target file is empty, its corresponding disk file will be deleted. If an exception or system interruption occurs, there will be problems in restart recover

[GitHub] [iotdb] Beyyes merged pull request #8727: Add cluster_name related logs

2023-01-03 Thread GitBox
Beyyes merged PR #8727: URL: https://github.com/apache/iotdb/pull/8727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.

[GitHub] [iotdb] HTHou closed issue #7385: 使用maven编译v0.13.2分支,报错

2023-01-03 Thread GitBox
HTHou closed issue #7385: 使用maven编译v0.13.2分支,报错 URL: https://github.com/apache/iotdb/issues/7385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews

[GitHub] [iotdb] HTHou commented on issue #7748: 0.14版本程序执行报错IoTDBConnectionException: Fail to reconnect to server,但是数据能正常写入

2023-01-03 Thread GitBox
HTHou commented on issue #7748: URL: https://github.com/apache/iotdb/issues/7748#issuecomment-1370546192 Need to set EnableRedirection to false in sessionPool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [iotdb] HTHou closed issue #7748: 0.14版本程序执行报错IoTDBConnectionException: Fail to reconnect to server,但是数据能正常写入

2023-01-03 Thread GitBox
HTHou closed issue #7748: 0.14版本程序执行报错IoTDBConnectionException: Fail to reconnect to server,但是数据能正常写入 URL: https://github.com/apache/iotdb/issues/7748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [iotdb] zhengshubin opened a new issue, #8735: [Bug] iotdb 1.0 regionReplicaSet is invalid: null

2023-01-03 Thread GitBox
zhengshubin opened a new issue, #8735: URL: https://github.com/apache/iotdb/issues/8735 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/iotdb/issues) and found nothing similar. ### Version centos 7.4 iotdb 1.0 ### Describe t

[GitHub] [iotdb] HTHou commented on issue #7572: 数据存活时间(TTL) 没有起作用 ?

2023-01-03 Thread GitBox
HTHou commented on issue #7572: URL: https://github.com/apache/iotdb/issues/7572#issuecomment-1370544739 https://github.com/apache/iotdb/pull/7580 Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [iotdb] HTHou closed issue #7572: 数据存活时间(TTL) 没有起作用 ?

2023-01-03 Thread GitBox
HTHou closed issue #7572: 数据存活时间(TTL) 没有起作用 ? URL: https://github.com/apache/iotdb/issues/7572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-u

[GitHub] [iotdb] HTHou closed issue #7630: 时间戳只能使用毫秒

2023-01-03 Thread GitBox
HTHou closed issue #7630: 时间戳只能使用毫秒 URL: https://github.com/apache/iotdb/issues/7630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...

[GitHub] [iotdb] HTHou closed issue #7950: 使用maven编译rel-0.13版本时报错

2023-01-03 Thread GitBox
HTHou closed issue #7950: 使用maven编译rel-0.13版本时报错 URL: https://github.com/apache/iotdb/issues/7950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: review

[GitHub] [iotdb] HTHou closed issue #7773: 0.14 Preview2升级到Preview3出错

2023-01-03 Thread GitBox
HTHou closed issue #7773: 0.14 Preview2升级到Preview3出错 URL: https://github.com/apache/iotdb/issues/7773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: re

[GitHub] [iotdb] HTHou commented on issue #7773: 0.14 Preview2升级到Preview3出错

2023-01-03 Thread GitBox
HTHou commented on issue #7773: URL: https://github.com/apache/iotdb/issues/7773#issuecomment-1370539370 1.0正式版本已经发布了,可以通过load-tsfile工具将preview版本的数据升级到正式版里。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [iotdb] HTHou closed issue #8421: [Bug] REST-API exception on "downsampling aggregate query" when time range with no data is selected

2023-01-03 Thread GitBox
HTHou closed issue #8421: [Bug] REST-API exception on "downsampling aggregate query" when time range with no data is selected URL: https://github.com/apache/iotdb/issues/8421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [iotdb] JackieTien97 closed issue #8577: [Bug] status 301 null if use ** pattren to select

2023-01-03 Thread GitBox
JackieTien97 closed issue #8577: [Bug] status 301 null if use ** pattren to select URL: https://github.com/apache/iotdb/issues/8577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [iotdb] JackieTien97 commented on issue #8577: [Bug] status 301 null if use ** pattren to select

2023-01-03 Thread GitBox
JackieTien97 commented on issue #8577: URL: https://github.com/apache/iotdb/issues/8577#issuecomment-1370535426 https://github.com/apache/iotdb/pull/8683 https://github.com/apache/iotdb/pull/8716 -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [iotdb] JackieTien97 closed issue #8682: [Bug] V1.0.0多设备使用last语法查询报错:301 EXECUTE_STATEMENT_ERROR

2023-01-03 Thread GitBox
JackieTien97 closed issue #8682: [Bug] V1.0.0多设备使用last语法查询报错:301 EXECUTE_STATEMENT_ERROR URL: https://github.com/apache/iotdb/issues/8682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [iotdb] JackieTien97 commented on issue #8682: [Bug] V1.0.0多设备使用last语法查询报错:301 EXECUTE_STATEMENT_ERROR

2023-01-03 Thread GitBox
JackieTien97 commented on issue #8682: URL: https://github.com/apache/iotdb/issues/8682#issuecomment-1370535352 https://github.com/apache/iotdb/pull/8683 https://github.com/apache/iotdb/pull/8716 -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8734: Make subprocesses' exit under control in IT cases

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8734: URL: https://github.com/apache/iotdb/pull/8734#issuecomment-1370531988 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] MarcosZyk merged pull request #8697: [To rel/0.13][IOTDB-5133] Add log and directory checker for export schema tool

2023-01-03 Thread GitBox
MarcosZyk merged PR #8697: URL: https://github.com/apache/iotdb/pull/8697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] CRZbulabula opened a new pull request, #8732: [IOTDB-4497] Improve NodeStatus definition

2023-01-03 Thread GitBox
CRZbulabula opened a new pull request, #8732: URL: https://github.com/apache/iotdb/pull/8732 Add more detailed NodeStatus definition on user docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8671: [IOTDB-5303] Refine IT: Make cluster properties mutable from outside file and developer coding easily

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8671: URL: https://github.com/apache/iotdb/pull/8671#issuecomment-1370479622 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8729: [To rel/1.0][IOTDB-5346] Fix log error in MemtableFlushTask when recovering

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8729: URL: https://github.com/apache/iotdb/pull/8729#issuecomment-1370479217 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] BUAAserein opened a new pull request, #8731: [IOTDB-5284] Fix some code smells

2023-01-03 Thread GitBox
BUAAserein opened a new pull request, #8731: URL: https://github.com/apache/iotdb/pull/8731 ## Description ### Fix some code smells in node-commons, please see in [JIRA5284](https://issues.apache.org/jira/browse/IOTDB-5284) -- This is an automated message from the Apache Git Se

[GitHub] [iotdb] BUAAserein opened a new pull request, #8730: [IOTDB-5284] Fix some code smells

2023-01-03 Thread GitBox
BUAAserein opened a new pull request, #8730: URL: https://github.com/apache/iotdb/pull/8730 ## Description ### Fix some code smells in node-commons, please see in [JIRA5284](https://issues.apache.org/jira/browse/IOTDB-5284) -- This is an automated message from the Apache Git Se

[GitHub] [iotdb] HTHou merged pull request #8729: [To rel/1.0][IOTDB-5346] Fix log error in MemtableFlushTask when recovering

2023-01-03 Thread GitBox
HTHou merged PR #8729: URL: https://github.com/apache/iotdb/pull/8729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] HTHou opened a new pull request, #8729: [To rel/1.0][IOTDB-5346] Fix log error in MemtableFlushTask when recovering (#8724)

2023-01-03 Thread GitBox
HTHou opened a new pull request, #8729: URL: https://github.com/apache/iotdb/pull/8729 ## Description cherry pick (#8724) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [iotdb] qiaojialin merged pull request #8725: [To rel/0.13][IOTDB-5346] Fix log error in MemtableFlushTask when recovering

2023-01-03 Thread GitBox
qiaojialin merged PR #8725: URL: https://github.com/apache/iotdb/pull/8725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] qiaojialin merged pull request #8724: [IOTDB-5346] Fix log error in MemtableFlushTask when recovering

2023-01-03 Thread GitBox
qiaojialin merged PR #8724: URL: https://github.com/apache/iotdb/pull/8724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #8644: [IOTDB-4674] Reimplement settle by compaction

2023-01-03 Thread GitBox
xingtanzjr commented on code in PR #8644: URL: https://github.com/apache/iotdb/pull/8644#discussion_r1061107066 ## server/src/main/java/org/apache/iotdb/db/engine/settle/SettleRequestHandler.java: ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #8644: [IOTDB-4674] Reimplement settle by compaction

2023-01-03 Thread GitBox
xingtanzjr commented on code in PR #8644: URL: https://github.com/apache/iotdb/pull/8644#discussion_r1061106008 ## server/src/main/java/org/apache/iotdb/db/engine/settle/SettleRequestHandler.java: ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8726: Separate SYNC_CONNECTION_ERROR and DISPATCH_ERROR

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8726: URL: https://github.com/apache/iotdb/pull/8726#issuecomment-1370440175 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #8644: [IOTDB-4674] Reimplement settle by compaction

2023-01-03 Thread GitBox
xingtanzjr commented on code in PR #8644: URL: https://github.com/apache/iotdb/pull/8644#discussion_r1061105028 ## server/src/main/java/org/apache/iotdb/db/engine/settle/SettleRequestHandler.java: ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #8644: [IOTDB-4674] Reimplement settle by compaction

2023-01-03 Thread GitBox
xingtanzjr commented on code in PR #8644: URL: https://github.com/apache/iotdb/pull/8644#discussion_r1061104857 ## server/src/main/java/org/apache/iotdb/db/engine/settle/SettleRequestHandler.java: ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #8644: [IOTDB-4674] Reimplement settle by compaction

2023-01-03 Thread GitBox
xingtanzjr commented on code in PR #8644: URL: https://github.com/apache/iotdb/pull/8644#discussion_r1061104604 ## server/src/main/java/org/apache/iotdb/db/engine/settle/SettleRequestHandler.java: ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #8644: [IOTDB-4674] Reimplement settle by compaction

2023-01-03 Thread GitBox
xingtanzjr commented on code in PR #8644: URL: https://github.com/apache/iotdb/pull/8644#discussion_r1061104334 ## server/src/main/java/org/apache/iotdb/db/engine/settle/SettleRequestHandler.java: ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8725: [To rel/0.13][IOTDB-5346] Fix log error in MemtableFlushTask when recovering

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8725: URL: https://github.com/apache/iotdb/pull/8725#issuecomment-1370438860 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #8644: [IOTDB-4674] Reimplement settle by compaction

2023-01-03 Thread GitBox
xingtanzjr commented on code in PR #8644: URL: https://github.com/apache/iotdb/pull/8644#discussion_r1061103968 ## server/src/main/java/org/apache/iotdb/db/engine/settle/SettleRequestHandler.java: ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #8644: [IOTDB-4674] Reimplement settle by compaction

2023-01-03 Thread GitBox
xingtanzjr commented on code in PR #8644: URL: https://github.com/apache/iotdb/pull/8644#discussion_r1061102649 ## server/src/main/java/org/apache/iotdb/db/engine/settle/SettleRequestHandler.java: ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #8644: [IOTDB-4674] Reimplement settle by compaction

2023-01-03 Thread GitBox
xingtanzjr commented on code in PR #8644: URL: https://github.com/apache/iotdb/pull/8644#discussion_r1061101432 ## server/src/main/java/org/apache/iotdb/db/engine/settle/SettleRequestHandler.java: ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #8644: [IOTDB-4674] Reimplement settle by compaction

2023-01-03 Thread GitBox
xingtanzjr commented on code in PR #8644: URL: https://github.com/apache/iotdb/pull/8644#discussion_r1061101196 ## server/src/main/java/org/apache/iotdb/db/engine/settle/SettleRequestHandler.java: ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #8644: [IOTDB-4674] Reimplement settle by compaction

2023-01-03 Thread GitBox
xingtanzjr commented on code in PR #8644: URL: https://github.com/apache/iotdb/pull/8644#discussion_r1061100536 ## server/src/main/java/org/apache/iotdb/db/engine/settle/SettleRequestHandler.java: ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8671: [IOTDB-5303] Refine IT: Make cluster properties mutable from outside file and developer coding easily

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8671: URL: https://github.com/apache/iotdb/pull/8671#issuecomment-1370431591 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] MarcosZyk opened a new pull request, #8728: [IOTDB-5347] Implement iterating query for devices and timeseries schema query

2023-01-03 Thread GitBox
MarcosZyk opened a new pull request, #8728: URL: https://github.com/apache/iotdb/pull/8728 ## Description ### Content1 ... ### Content2 ... ### Content3 ... This PR has: - [ ] been self-reviewed. - [ ] concu

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #8644: [IOTDB-4674] Reimplement settle by compaction

2023-01-03 Thread GitBox
xingtanzjr commented on code in PR #8644: URL: https://github.com/apache/iotdb/pull/8644#discussion_r1061098062 ## server/src/main/java/org/apache/iotdb/db/tools/settle/TsFileSettleByCompactionTool.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8726: Change SYNC_CONNECTION_ERROR code to 306 and fix docs

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8726: URL: https://github.com/apache/iotdb/pull/8726#issuecomment-1370427342 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] Beyyes closed pull request #8723: Change Variables to Variable

2023-01-03 Thread GitBox
Beyyes closed pull request #8723: Change Variables to Variable URL: https://github.com/apache/iotdb/pull/8723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [iotdb] ericpai merged pull request #8717: [IOTDB-5285] Modifying system properties before the initial startup causes the datanode to fail to start

2023-01-03 Thread GitBox
ericpai merged PR #8717: URL: https://github.com/apache/iotdb/pull/8717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache

[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #8723: Change Variables to Variable

2023-01-03 Thread GitBox
CRZbulabula commented on code in PR #8723: URL: https://github.com/apache/iotdb/pull/8723#discussion_r1061089360 ## server/src/main/java/org/apache/iotdb/db/mpp/common/header/ColumnHeaderConstant.java: ## @@ -58,7 +58,7 @@ public class ColumnHeaderConstant { public static fin

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8726: Change SYNC_CONNECTION_ERROR code to 306 and fix docs

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8726: URL: https://github.com/apache/iotdb/pull/8726#issuecomment-1370411215 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] HTHou merged pull request #8689: Bump reload4j from 1.2.22 to 1.2.24

2023-01-03 Thread GitBox
HTHou merged PR #8689: URL: https://github.com/apache/iotdb/pull/8689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8673: fix the wal comment

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8673: URL: https://github.com/apache/iotdb/pull/8673#issuecomment-1370402164 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] HTHou opened a new pull request, #8726: Change SYNC_CONNECTION_ERROR code to 306 and fix docs

2023-01-03 Thread GitBox
HTHou opened a new pull request, #8726: URL: https://github.com/apache/iotdb/pull/8726 ## Description SYNC_CONNECTION_ERROR is General Error, therefore the code should be 3XX. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [iotdb] neuyilan commented on a diff in pull request #8673: fix the wal comment

2023-01-03 Thread GitBox
neuyilan commented on code in PR #8673: URL: https://github.com/apache/iotdb/pull/8673#discussion_r1061081221 ## server/src/main/java/org/apache/iotdb/db/wal/utils/WALFileUtils.java: ## @@ -105,15 +105,15 @@ public static void ascSortByVersionId(File[] walFiles) { /** *

[GitHub] [iotdb] HTHou opened a new pull request, #8725: [To rel/0.13][IOTDB-5346] Fix log error in MemtableFlushTask when recovering

2023-01-03 Thread GitBox
HTHou opened a new pull request, #8725: URL: https://github.com/apache/iotdb/pull/8725 ## Description See IOTDB-5346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8724: [IOTDB-5346] Fix log error in MemtableFlushTask when recovering

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8724: URL: https://github.com/apache/iotdb/pull/8724#issuecomment-1370393375 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] HTHou opened a new pull request, #8724: [IOTDB-5346] Fix log error in MemtableFlushTask when recovering

2023-01-03 Thread GitBox
HTHou opened a new pull request, #8724: URL: https://github.com/apache/iotdb/pull/8724 ## Description ![52241672732815_ pic](https://user-images.githubusercontent.com/25913899/210467279-626d4987-bcc7-417d-b099-a9e8f475f9e0.jpg) -- This is an automated message from the Apache Gi

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8721: [IOTDB-5342] Separate filtering and business logic in AbstractTreeVisitor

2023-01-03 Thread GitBox
MarcosZyk commented on code in PR #8721: URL: https://github.com/apache/iotdb/pull/8721#discussion_r1061057693 ## node-commons/src/main/java/org/apache/iotdb/commons/schema/tree/AbstractTreeVisitor.java: ## @@ -189,17 +195,26 @@ protected void getNext() throws Exception {

[GitHub] [iotdb] ZhanGHanG9991 commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-03 Thread GitBox
ZhanGHanG9991 commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1060804526 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/window/EventWindow.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [iotdb] ZhanGHanG9991 commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-03 Thread GitBox
ZhanGHanG9991 commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1060803930 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/window/WindowParameter.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8650: [IOTDB-5308] Limit the output tsblock's size of each operator[Part1]

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8650: URL: https://github.com/apache/iotdb/pull/8650#issuecomment-1370015059 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] ZhanGHanG9991 commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-03 Thread GitBox
ZhanGHanG9991 commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1060770627 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/window/WindowManagerFactory.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8723: Change Variables to Variable

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8723: URL: https://github.com/apache/iotdb/pull/8723#issuecomment-1369947020 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8711: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-03 Thread GitBox
OneSizeFitsQuorum merged PR #8711: URL: https://github.com/apache/iotdb/pull/8711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] Alima777 merged pull request #8706: [To rel/1.0] [IOTDB-5309] Wrong calculation for retained size of tsblock calculate

2023-01-03 Thread GitBox
Alima777 merged PR #8706: URL: https://github.com/apache/iotdb/pull/8706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apach

[GitHub] [iotdb] Beyyes merged pull request #8708: [IOTDB-5326] Add cluster_name parameter

2023-01-03 Thread GitBox
Beyyes merged PR #8708: URL: https://github.com/apache/iotdb/pull/8708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.

[GitHub] [iotdb] ycycse commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-03 Thread GitBox
ycycse commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1056021652 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/window/EqualEventBooleanWindowManager.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8712: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-03 Thread GitBox
OneSizeFitsQuorum merged PR #8712: URL: https://github.com/apache/iotdb/pull/8712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8714: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-03 Thread GitBox
OneSizeFitsQuorum merged PR #8714: URL: https://github.com/apache/iotdb/pull/8714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8710: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-03 Thread GitBox
OneSizeFitsQuorum merged PR #8710: URL: https://github.com/apache/iotdb/pull/8710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8709: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-03 Thread GitBox
OneSizeFitsQuorum merged PR #8709: URL: https://github.com/apache/iotdb/pull/8709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] Cpaulyz opened a new pull request, #8721: [IOTDB-5342] Separate filtering and business logic in AbstractTreeVisitor

2023-01-03 Thread GitBox
Cpaulyz opened a new pull request, #8721: URL: https://github.com/apache/iotdb/pull/8721 ## Description 1. Separate filtering and business logic in AbstractTreeVisitor. ``` /** * Internal-match means the node matches an internal node name of the given path pattern. root.

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8650: [IOTDB-5308] Limit the output tsblock's size of each operator[Part1]

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8650: URL: https://github.com/apache/iotdb/pull/8650#issuecomment-1369728582 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] JackieTien97 merged pull request #8719: [To rel/1.0][IOTDB-5316] fix bug that Session.setFetchSize is not used in the following fetch requests

2023-01-03 Thread GitBox
JackieTien97 merged PR #8719: URL: https://github.com/apache/iotdb/pull/8719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.a

[GitHub] [iotdb] Beyyes merged pull request #8718: Fix testGetSlots IT bug

2023-01-03 Thread GitBox
Beyyes merged PR #8718: URL: https://github.com/apache/iotdb/pull/8718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.

[GitHub] [iotdb] Beyyes merged pull request #8715: Rename SQL show cluster parameters to show variables

2023-01-03 Thread GitBox
Beyyes merged PR #8715: URL: https://github.com/apache/iotdb/pull/8715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8650: [IOTDB-5308] Limit the output tsblock's size of each operator[Part1]

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8650: URL: https://github.com/apache/iotdb/pull/8650#issuecomment-1369639661 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] choubenson opened a new pull request, #8720: [IOTDB-5207] Reconstruct compaction package

2023-01-03 Thread GitBox
choubenson opened a new pull request, #8720: URL: https://github.com/apache/iotdb/pull/8720 ![image](https://user-images.githubusercontent.com/45144903/210340986-7b7d8803-efcb-49f6-b5af-16c72eeaec81.png) -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8671: [IOTDB-5303] Refine IT: Make cluster properties mutable from outside file and developer coding easily

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8671: URL: https://github.com/apache/iotdb/pull/8671#issuecomment-1369582095 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8650: [IOTDB-5308] Limit the output tsblock's size of each operator[Part1]

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8650: URL: https://github.com/apache/iotdb/pull/8650#issuecomment-1369564220 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] MarcosZyk merged pull request #8677: [IOTDB-3063] Set up SchemaReader and apply them in show devices and show timeseries

2023-01-03 Thread GitBox
MarcosZyk merged PR #8677: URL: https://github.com/apache/iotdb/pull/8677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] CRZbulabula opened a new pull request, #8718: Fix testGetSlots IT bug

2023-01-03 Thread GitBox
CRZbulabula opened a new pull request, #8718: URL: https://github.com/apache/iotdb/pull/8718 Modify a test configuration to avoid local test bug. Since our local computers always have sufficient CPUs, this IT will create DataRegionGroups for each StorageGroups that more than expected(leastD

[GitHub] [iotdb] HeimingZ opened a new pull request, #8717: [IOTDB-5285] Modifying system properties before the initial startup causes the datanode to fail to start

2023-01-03 Thread GitBox
HeimingZ opened a new pull request, #8717: URL: https://github.com/apache/iotdb/pull/8717 The system writes system.properties before pulling config from the confignode, which causes error when the first startup. So, I overwrite the system.properties when the first startup. -- This is an

[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #8708: [IOTDB-5326] Add cluster_name parameter

2023-01-03 Thread GitBox
CRZbulabula commented on code in PR #8708: URL: https://github.com/apache/iotdb/pull/8708#discussion_r1060371307 ## server/src/assembly/resources/conf/iotdb-datanode.properties: ## @@ -17,6 +17,14 @@ # under the License. # + +### Cluster Configuration +##

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8650: [IOTDB-5308] Limit the output tsblock's size of each operator[Part1]

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8650: URL: https://github.com/apache/iotdb/pull/8650#issuecomment-1369510780 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] liuminghui233 merged pull request #8684: Fix typo in query metric

2023-01-03 Thread GitBox
liuminghui233 merged PR #8684: URL: https://github.com/apache/iotdb/pull/8684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.