Re: [PR] Thrift zero-copy optimization for TElasticFramedTransport [iotdb]

2024-03-14 Thread via GitHub
OneSizeFitsQuorum commented on code in PR #12050: URL: https://github.com/apache/iotdb/pull/12050#discussion_r1525809114 ## iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcTransportFactory.java: ## @@ -19,105 +19,28 @@ package org.apache.iotdb.rpc; -import or

Re: [PR] Fix wal delete sort method [iotdb]

2024-03-14 Thread via GitHub
HTHou merged PR #12176: URL: https://github.com/apache/iotdb/pull/12176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache

Re: [PR] Fix Concurrent bug between NodeSupplier.close() and its run() [iotdb]

2024-03-14 Thread via GitHub
JackieTien97 merged PR #12175: URL: https://github.com/apache/iotdb/pull/12175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb

Re: [PR] Subscription: Subscription Management [iotdb]

2024-03-14 Thread via GitHub
Caideyipi commented on code in PR #12149: URL: https://github.com/apache/iotdb/pull/12149#discussion_r1521318542 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/ConfigPhysicalPlan.java: ## @@ -431,6 +437,23 @@ public static ConfigPhysicalPlan

Re: [PR] Subscription: Subscription Management [iotdb]

2024-03-14 Thread via GitHub
Caideyipi commented on code in PR #12149: URL: https://github.com/apache/iotdb/pull/12149#discussion_r1521318542 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/ConfigPhysicalPlan.java: ## @@ -431,6 +437,23 @@ public static ConfigPhysicalPlan

[PR] Replace string device id with interface IDeviceID [iotdb]

2024-03-14 Thread via GitHub
shuwenwei opened a new pull request, #12177: URL: https://github.com/apache/iotdb/pull/12177 ## Description Replace string device id with interface IDeviceID in these modules: compaction, writing, tsfile. Code of other modules are also modified temporarily because some method parameters

Re: [PR] Integration test cluster stop faster [iotdb]

2024-03-14 Thread via GitHub
OneSizeFitsQuorum merged PR #12110: URL: https://github.com/apache/iotdb/pull/12110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

[PR] Fix wal delete sort method [iotdb]

2024-03-14 Thread via GitHub
HeimingZ opened a new pull request, #12176: URL: https://github.com/apache/iotdb/pull/12176 Because the disk usage of wal nodes may change when comparing their delete priority, which violates comparison method's general contract. So, I cache the disk usage in a map and use the values in th

Re: [PR] Fix Concurrent bug between NodeSupplier.close() and its run() [iotdb]

2024-03-14 Thread via GitHub
sonarcloud[bot] commented on PR #12175: URL: https://github.com/apache/iotdb/pull/12175#issuecomment-1998860733 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

[PR] Fix Concurrent bug between NodeSupplier.close() and its run() [iotdb]

2024-03-14 Thread via GitHub
JackieTien97 opened a new pull request, #12175: URL: https://github.com/apache/iotdb/pull/12175 More details about this bug can be seen in https://jira.infra.timecho.com:8443/browse/TIMECHODB-607. The reason for this bug is that we call the SessionPool.close() method and in this meth

Re: [PR] Optimize the result of EXPLAIN ANALYZE [iotdb]

2024-03-14 Thread via GitHub
JackieTien97 merged PR #12161: URL: https://github.com/apache/iotdb/pull/12161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb

Re: [PR] Add null guards for TsFileExecutor constructor [iotdb]

2024-03-14 Thread via GitHub
pingpingy1 closed pull request #12013: Add null guards for TsFileExecutor constructor URL: https://github.com/apache/iotdb/pull/12013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Add null guards for TsFileExecutor constructor [iotdb]

2024-03-14 Thread via GitHub
pingpingy1 commented on PR #12013: URL: https://github.com/apache/iotdb/pull/12013#issuecomment-1997725686 Oh, sure! Let me close this PR for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] Optimize Count/Delete Timeseries root.** or root.db.** [iotdb]

2024-03-14 Thread via GitHub
Cpaulyz opened a new pull request, #12174: URL: https://github.com/apache/iotdb/pull/12174 ## Experiment * Environment ``` LOOP=1 BATCH_SIZE_PER_WRITE=1 DEVICE_NAME_PREFIX=d_ DEVICE_NUMBER=1 SENSOR_NUMBER=166 ``` * Before https://github.com/apache

[PR] Fixed simple consensus recover problem [iotdb]

2024-03-14 Thread via GitHub
Caideyipi opened a new pull request, #12173: URL: https://github.com/apache/iotdb/pull/12173 ## Description Previously, the simple consensus may write to the statemachine in parrallel, which may cause correctness problem and make the operations in log not be in the same order of executi

Re: [PR] Add more query metrics for estimated memory and max overlapped page [iotdb]

2024-03-14 Thread via GitHub
sonarcloud[bot] commented on PR #12172: URL: https://github.com/apache/iotdb/pull/12172#issuecomment-1997156841 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

[PR] Add more query metrics for estimated memory and max overlapped page [iotdb]

2024-03-14 Thread via GitHub
Beyyes opened a new pull request, #12172: URL: https://github.com/apache/iotdb/pull/12172 ## Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Pipe: Fixed create logical view idempotency problem & some IT check coverage missing [iotdb]

2024-03-14 Thread via GitHub
SteveYurongSu merged PR #12170: URL: https://github.com/apache/iotdb/pull/12170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

Re: [PR] Subscription: Subscription Management [iotdb]

2024-03-14 Thread via GitHub
DanielWang2035 commented on code in PR #12149: URL: https://github.com/apache/iotdb/pull/12149#discussion_r1524537601 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/response/subscription/SubscriptionTableResp.java: ## @@ -0,0 +1,78 @@ +/* + * Licens

Re: [PR] UDF: add an udf function for envelope demodulation analysis [iotdb]

2024-03-14 Thread via GitHub
SteveYurongSu merged PR #12146: URL: https://github.com/apache/iotdb/pull/12146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

Re: [PR] Pipe: implemented sdt-sampling-processor & refactored down-sampling-processor [iotdb]

2024-03-14 Thread via GitHub
SteveYurongSu merged PR #12114: URL: https://github.com/apache/iotdb/pull/12114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

Re: [PR] Support schema region snapshot parser. [iotdb]

2024-03-14 Thread via GitHub
SteveYurongSu merged PR #12145: URL: https://github.com/apache/iotdb/pull/12145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

Re: [PR] Fix deadlock when flush an empty TsFile and query concurrently [iotdb]

2024-03-14 Thread via GitHub
sonarcloud[bot] commented on PR #12171: URL: https://github.com/apache/iotdb/pull/12171#issuecomment-1996942991 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

[PR] Fix deadlock when flush an empty TsFile and query concurrently [iotdb]

2024-03-14 Thread via GitHub
HTHou opened a new pull request, #12171: URL: https://github.com/apache/iotdb/pull/12171 ## Description https://apache-iotdb.feishu.cn/docx/RrBrdXHPgoJTcxxoPxMc8eNXndd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] Pipe: Fixed create logical view idempotency problem & some IT check coverage missing [iotdb]

2024-03-14 Thread via GitHub
Caideyipi opened a new pull request, #12170: URL: https://github.com/apache/iotdb/pull/12170 ## Description As the title said. This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [

Re: [PR] Pipe: Cancelled useless flush at historical extractor & enable gracefully dropping pipe and avoid pre-mature report & fixed potential lose point bug caused by cancelled flush by historical ex

2024-03-14 Thread via GitHub
SteveYurongSu closed pull request #11974: Pipe: Cancelled useless flush at historical extractor & enable gracefully dropping pipe and avoid pre-mature report & fixed potential lose point bug caused by cancelled flush by historical extractor URL: https://github.com/apache/iotdb/pull/11974 --

Re: [PR] UDF: add an udf function for envelope demodulation analysis [iotdb]

2024-03-14 Thread via GitHub
SteveYurongSu commented on code in PR #12146: URL: https://github.com/apache/iotdb/pull/12146#discussion_r1524387888 ## library-udf/src/main/java/org/apache/iotdb/library/frequency/UDFEnvelopeAnalysis.java: ## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Pipe: implemented sdt-sampling-processor & refactored down-sampling-processor [iotdb]

2024-03-14 Thread via GitHub
xuanronaldo commented on PR #12114: URL: https://github.com/apache/iotdb/pull/12114#issuecomment-1996761092 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr