OneSizeFitsQuorum commented on code in PR #12050:
URL: https://github.com/apache/iotdb/pull/12050#discussion_r1525809114
##
iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcTransportFactory.java:
##
@@ -19,105 +19,28 @@
package org.apache.iotdb.rpc;
-import or
HTHou merged PR #12176:
URL: https://github.com/apache/iotdb/pull/12176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache
JackieTien97 merged PR #12175:
URL: https://github.com/apache/iotdb/pull/12175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb
Caideyipi commented on code in PR #12149:
URL: https://github.com/apache/iotdb/pull/12149#discussion_r1521318542
##
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/ConfigPhysicalPlan.java:
##
@@ -431,6 +437,23 @@ public static ConfigPhysicalPlan
Caideyipi commented on code in PR #12149:
URL: https://github.com/apache/iotdb/pull/12149#discussion_r1521318542
##
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/ConfigPhysicalPlan.java:
##
@@ -431,6 +437,23 @@ public static ConfigPhysicalPlan
shuwenwei opened a new pull request, #12177:
URL: https://github.com/apache/iotdb/pull/12177
## Description
Replace string device id with interface IDeviceID in these modules:
compaction, writing, tsfile. Code of other modules are also modified
temporarily because some method parameters
OneSizeFitsQuorum merged PR #12110:
URL: https://github.com/apache/iotdb/pull/12110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@
HeimingZ opened a new pull request, #12176:
URL: https://github.com/apache/iotdb/pull/12176
Because the disk usage of wal nodes may change when comparing their delete
priority, which violates comparison method's general contract. So, I cache the
disk usage in a map and use the values in th
sonarcloud[bot] commented on PR #12175:
URL: https://github.com/apache/iotdb/pull/12175#issuecomment-1998860733
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
Passed')](https://sonarclo
JackieTien97 opened a new pull request, #12175:
URL: https://github.com/apache/iotdb/pull/12175
More details about this bug can be seen in
https://jira.infra.timecho.com:8443/browse/TIMECHODB-607.
The reason for this bug is that we call the SessionPool.close() method and
in this meth
JackieTien97 merged PR #12161:
URL: https://github.com/apache/iotdb/pull/12161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb
pingpingy1 closed pull request #12013: Add null guards for TsFileExecutor
constructor
URL: https://github.com/apache/iotdb/pull/12013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
pingpingy1 commented on PR #12013:
URL: https://github.com/apache/iotdb/pull/12013#issuecomment-1997725686
Oh, sure!
Let me close this PR for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Cpaulyz opened a new pull request, #12174:
URL: https://github.com/apache/iotdb/pull/12174
## Experiment
* Environment
```
LOOP=1
BATCH_SIZE_PER_WRITE=1
DEVICE_NAME_PREFIX=d_
DEVICE_NUMBER=1
SENSOR_NUMBER=166
```
* Before
https://github.com/apache
Caideyipi opened a new pull request, #12173:
URL: https://github.com/apache/iotdb/pull/12173
## Description
Previously, the simple consensus may write to the statemachine in parrallel,
which may cause correctness problem and make the operations in log not be in
the same order of executi
sonarcloud[bot] commented on PR #12172:
URL: https://github.com/apache/iotdb/pull/12172#issuecomment-1997156841
## [![Quality Gate
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
'Quality Gate
Failed')](https://sonarclo
Beyyes opened a new pull request, #12172:
URL: https://github.com/apache/iotdb/pull/12172
## Description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
SteveYurongSu merged PR #12170:
URL: https://github.com/apache/iotdb/pull/12170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotd
DanielWang2035 commented on code in PR #12149:
URL: https://github.com/apache/iotdb/pull/12149#discussion_r1524537601
##
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/response/subscription/SubscriptionTableResp.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licens
SteveYurongSu merged PR #12146:
URL: https://github.com/apache/iotdb/pull/12146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotd
SteveYurongSu merged PR #12114:
URL: https://github.com/apache/iotdb/pull/12114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotd
SteveYurongSu merged PR #12145:
URL: https://github.com/apache/iotdb/pull/12145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotd
sonarcloud[bot] commented on PR #12171:
URL: https://github.com/apache/iotdb/pull/12171#issuecomment-1996942991
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
Passed')](https://sonarclo
HTHou opened a new pull request, #12171:
URL: https://github.com/apache/iotdb/pull/12171
## Description
https://apache-iotdb.feishu.cn/docx/RrBrdXHPgoJTcxxoPxMc8eNXndd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Caideyipi opened a new pull request, #12170:
URL: https://github.com/apache/iotdb/pull/12170
## Description
As the title said.
This PR has:
- [ ] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [
SteveYurongSu closed pull request #11974: Pipe: Cancelled useless flush at
historical extractor & enable gracefully dropping pipe and avoid pre-mature
report & fixed potential lose point bug caused by cancelled flush by historical
extractor
URL: https://github.com/apache/iotdb/pull/11974
--
SteveYurongSu commented on code in PR #12146:
URL: https://github.com/apache/iotdb/pull/12146#discussion_r1524387888
##
library-udf/src/main/java/org/apache/iotdb/library/frequency/UDFEnvelopeAnalysis.java:
##
@@ -0,0 +1,248 @@
+/*
+ * Licensed to the Apache Software Foundation
xuanronaldo commented on PR #12114:
URL: https://github.com/apache/iotdb/pull/12114#issuecomment-1996761092
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
28 matches
Mail list logo