Re: [PR] Some region migration related work [iotdb]

2024-04-18 Thread via GitHub
OneSizeFitsQuorum commented on code in PR #12376: URL: https://github.com/apache/iotdb/pull/12376#discussion_r1571861284 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RegionMaintainHandler.java: ## @@ -661,50 +660,48 @@ public void removeDataNo

Re: [PR] Optimize the input parameters for LeaderBalancer [iotdb]

2024-04-18 Thread via GitHub
OneSizeFitsQuorum merged PR #12374: URL: https://github.com/apache/iotdb/pull/12374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

Re: [PR] Subscription: Push consumer & Async commit [iotdb]

2024-04-18 Thread via GitHub
SteveYurongSu merged PR #12294: URL: https://github.com/apache/iotdb/pull/12294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

[PR] Some region migration related work [iotdb]

2024-04-18 Thread via GitHub
liyuheng5 opened a new pull request, #12376: URL: https://github.com/apache/iotdb/pull/12376 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [I] [Bug] insertTablet http api is lost data event return SUCCESS_STATUS [iotdb]

2024-04-18 Thread via GitHub
github-actions[bot] commented on issue #12375: URL: https://github.com/apache/iotdb/issues/12375#issuecomment-2065739086 Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community! -- This is an automated message from the Apache Git Service. To re

[I] [Bug] insertTablet http api is lost data event return SUCCESS_STATUS [iotdb]

2024-04-18 Thread via GitHub
zhongwencool opened a new issue, #12375: URL: https://github.com/apache/iotdb/issues/12375 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/iotdb/issues) and found nothing similar. ### Version Using this syntax, data can be inserted

Re: [PR] Optimize the input parameters for LeaderBalancer [iotdb]

2024-04-18 Thread via GitHub
sonarcloud[bot] commented on PR #12374: URL: https://github.com/apache/iotdb/pull/12374#issuecomment-2065701644 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] Optimize fast compaction memory [iotdb]

2024-04-18 Thread via GitHub
OneSizeFitsQuorum merged PR #12340: URL: https://github.com/apache/iotdb/pull/12340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

Re: [PR] Implementation of device TTL [iotdb]

2024-04-18 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1571684329 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/schedule/CompactionScheduler.java: ## @@ -100,11 +102,19 @@ public stati

Re: [PR] Optimize the input parameters for LeaderBalancer [iotdb]

2024-04-18 Thread via GitHub
sonarcloud[bot] commented on PR #12374: URL: https://github.com/apache/iotdb/pull/12374#issuecomment-2064449370 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] Optimize the input parameters for LeaderBalancer [iotdb]

2024-04-18 Thread via GitHub
codecov[bot] commented on PR #12374: URL: https://github.com/apache/iotdb/pull/12374#issuecomment-2064182813 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12374?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

Re: [PR] Optimize the input parameters for LeaderBalancer [iotdb]

2024-04-18 Thread via GitHub
sonarcloud[bot] commented on PR #12374: URL: https://github.com/apache/iotdb/pull/12374#issuecomment-2064007012 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] Feature/move stuff to the extras repository [iotdb]

2024-04-18 Thread via GitHub
chrisdutz closed pull request #12343: Feature/move stuff to the extras repository URL: https://github.com/apache/iotdb/pull/12343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[PR] Feature/move stuff to the extras repository take 2 [iotdb]

2024-04-18 Thread via GitHub
chrisdutz opened a new pull request, #12373: URL: https://github.com/apache/iotdb/pull/12373 Moved all content from examples and connectors to the new iotdb-extras repository. Split up the distribution into the parts that bundle the core of iotdb and moved the distributions of the connec

Re: [PR] Pipe: clear reference count for events in retry queue & detect re-increasing reference count for other connectors [iotdb]

2024-04-18 Thread via GitHub
SteveYurongSu merged PR #12344: URL: https://github.com/apache/iotdb/pull/12344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

Re: [PR] Fix IoTConsensus LogDispatcherThread Stop Using Futrue Cancel [iotdb]

2024-04-18 Thread via GitHub
OneSizeFitsQuorum merged PR #12370: URL: https://github.com/apache/iotdb/pull/12370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

Re: [PR] Optimize region migration log && change region status to removing before transferring leader [iotdb]

2024-04-18 Thread via GitHub
OneSizeFitsQuorum merged PR #12368: URL: https://github.com/apache/iotdb/pull/12368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

Re: [PR] Pipe: Two stage aggregate counter [iotdb]

2024-04-18 Thread via GitHub
sonarcloud[bot] commented on PR #12328: URL: https://github.com/apache/iotdb/pull/12328#issuecomment-2063582403 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

[PR] Fix compaction ut dead lock [iotdb]

2024-04-18 Thread via GitHub
shuwenwei opened a new pull request, #12372: URL: https://github.com/apache/iotdb/pull/12372 ## Description Fix compaction ut dead lock https://github.com/apache/iotdb/actions/runs/8731450531/job/23956879130 -- This is an automated message from the Apache Git Service. To respond to t

[PR] fix(jdbc): when parameter is string ,append "\"" [iotdb]

2024-04-18 Thread via GitHub
CritasWang opened a new pull request, #12371: URL: https://github.com/apache/iotdb/pull/12371 ![image](https://github.com/apache/iotdb/assets/19721744/c6f4ff5a-e1ca-4e12-8db4-c25e66bb081a) -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Pipe: Two stage aggregate counter [iotdb]

2024-04-18 Thread via GitHub
sonarcloud[bot] commented on PR #12328: URL: https://github.com/apache/iotdb/pull/12328#issuecomment-2063483088 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

[PR] Fix IoTConsensus LogDispatcherThread Stop Using Futrue Cancel [iotdb]

2024-04-18 Thread via GitHub
BUAAserein opened a new pull request, #12370: URL: https://github.com/apache/iotdb/pull/12370 ## Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Optimize region migration log [iotdb]

2024-04-18 Thread via GitHub
liyuheng5 commented on code in PR #12368: URL: https://github.com/apache/iotdb/pull/12368#discussion_r1570355689 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/region/AddRegionPeerProcedure.java: ## @@ -132,31 +143,39 @@ protected Flow exec

[PR] [TableModel] using StringArrayDeviceId for writing [iotdb]

2024-04-18 Thread via GitHub
HTHou opened a new pull request, #12369: URL: https://github.com/apache/iotdb/pull/12369 ## Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Optimize region migration log [iotdb]

2024-04-18 Thread via GitHub
HTHou commented on code in PR #12368: URL: https://github.com/apache/iotdb/pull/12368#discussion_r1570310335 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/region/AddRegionPeerProcedure.java: ## @@ -132,31 +143,39 @@ protected Flow executeFromS

Re: [PR] Pipe: clear reference count for events in retry queue & detect re-increasing reference count for other connectors [iotdb]

2024-04-18 Thread via GitHub
SteveYurongSu commented on code in PR #12344: URL: https://github.com/apache/iotdb/pull/12344#discussion_r1570306547 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/sync/IoTDBDataRegionSyncConnector.java: ## @@ -182,6 +224,8 @@ private voi

Re: [PR] Pipe: clear reference count for events in retry queue & detect re-increasing reference count for other connectors [iotdb]

2024-04-18 Thread via GitHub
VGalaxies commented on code in PR #12344: URL: https://github.com/apache/iotdb/pull/12344#discussion_r1570235803 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/connector/PipeReceiverStatusHandler.java: ## @@ -133,12 +133,14 @@ public void handle(TSStatus

Re: [PR] Pipe: clear reference count for events in retry queue & detect re-increasing reference count for other connectors [iotdb]

2024-04-18 Thread via GitHub
VGalaxies commented on code in PR #12344: URL: https://github.com/apache/iotdb/pull/12344#discussion_r1570236190 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/sync/IoTDBDataRegionSyncConnector.java: ## @@ -182,6 +224,8 @@ private void do

Re: [PR] Pipe: clear reference count for events in retry queue & detect re-increasing reference count for other connectors [iotdb]

2024-04-18 Thread via GitHub
VGalaxies commented on code in PR #12344: URL: https://github.com/apache/iotdb/pull/12344#discussion_r1570233321 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/event/EnrichedEvent.java: ## @@ -148,6 +152,9 @@ public boolean decreaseReferenceCount(String h

Re: [PR] Pipe: clear reference count for events in retry queue & detect re-increasing reference count for other connectors [iotdb]

2024-04-18 Thread via GitHub
Caideyipi commented on code in PR #12344: URL: https://github.com/apache/iotdb/pull/12344#discussion_r1570208783 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/event/EnrichedEvent.java: ## @@ -148,6 +152,9 @@ public boolean decreaseReferenceCount(String h

Re: [PR] Pipe: Make the PipeParameters return sorted entries string when "toString" is called [iotdb]

2024-04-18 Thread via GitHub
SteveYurongSu merged PR #12329: URL: https://github.com/apache/iotdb/pull/12329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

Re: [PR] Pipe: Added debug logger after schema/config event is successfully transferred [iotdb]

2024-04-18 Thread via GitHub
SteveYurongSu merged PR #12362: URL: https://github.com/apache/iotdb/pull/12362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd