Re: [PR] Log InsertRowsNode in WAL [iotdb]

2024-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #12271: URL: https://github.com/apache/iotdb/pull/12271#issuecomment-2078739530 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] Pipe: Support InsertRows in PipeInsertNodeTabletInsertionEvent [iotdb]

2024-04-25 Thread via GitHub
SteveYurongSu merged PR #12286: URL: https://github.com/apache/iotdb/pull/12286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

Re: [I] [Bug] 应该不算是一个bug [iotdb]

2024-04-25 Thread via GitHub
github-actions[bot] commented on issue #12424: URL: https://github.com/apache/iotdb/issues/12424#issuecomment-2078627992 Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community! -- This is an automated message from the Apache Git Service. To re

[I] [Bug] 应该不算是一个bug [iotdb]

2024-04-25 Thread via GitHub
imx7 opened a new issue, #12424: URL: https://github.com/apache/iotdb/issues/12424 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/iotdb/issues) and found nothing similar. ### Version 1.3.1 ### Describe the bug and provide t

Re: [PR] Pipe: Support InsertRows in PipeInsertNodeTabletInsertionEvent [iotdb]

2024-04-25 Thread via GitHub
SteveYurongSu commented on PR #12286: URL: https://github.com/apache/iotdb/pull/12286#issuecomment-2078609862 @HTHou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Implementation of device TTL [iotdb]

2024-04-25 Thread via GitHub
jt2594838 commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1580446812 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/task/SettleCompactionTask.java: ## @@ -0,0 +1,389 @@ +/* + * Lice

Re: [PR] Normalize LoadCache interfaces [iotdb]

2024-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #12421: URL: https://github.com/apache/iotdb/pull/12421#issuecomment-2078574150 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] Implementation of device TTL [iotdb]

2024-04-25 Thread via GitHub
jt2594838 commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1580436509 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java: ## @@ -516,6 +516,24 @@ public class IoTDBConfig { /** The interval of compaction t

Re: [PR] Implementation of device TTL [iotdb]

2024-04-25 Thread via GitHub
jt2594838 commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1580434946 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms # default_ttl_in_ms=-1

Re: [PR] Implementation of device TTL [iotdb]

2024-04-25 Thread via GitHub
jt2594838 commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1580434946 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms # default_ttl_in_ms=-1

[PR] add the new UDF doc [iotdb-docs]

2024-04-25 Thread via GitHub
wanghui42 opened a new pull request, #226: URL: https://github.com/apache/iotdb-docs/pull/226 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] pipe return createuser raw plan. [iotdb]

2024-04-25 Thread via GitHub
SteveYurongSu closed pull request #12418: pipe return createuser raw plan. URL: https://github.com/apache/iotdb/pull/12418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Pipe: Support "CreateUserWithRawPassword" in pipe module [iotdb]

2024-04-25 Thread via GitHub
Caideyipi closed pull request #12422: Pipe: Support "CreateUserWithRawPassword" in pipe module URL: https://github.com/apache/iotdb/pull/12422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] fix snapshot parser null point. [iotdb]

2024-04-25 Thread via GitHub
JackieTien97 merged PR #12423: URL: https://github.com/apache/iotdb/pull/12423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb

[PR] fix snapshot parser null point. [iotdb]

2024-04-25 Thread via GitHub
shuolinl opened a new pull request, #12423: URL: https://github.com/apache/iotdb/pull/12423 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[PR] Pipe: Support "CreateUserWithRawPassword" in pipe module [iotdb]

2024-04-25 Thread via GitHub
Caideyipi opened a new pull request, #12422: URL: https://github.com/apache/iotdb/pull/12422 ## Description As the title said. This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [

Re: [PR] Normalize LoadCache interfaces [iotdb]

2024-04-25 Thread via GitHub
codecov[bot] commented on PR #12421: URL: https://github.com/apache/iotdb/pull/12421#issuecomment-2077274305 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12421?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

Re: [PR] Normalize LoadCache interfaces [iotdb]

2024-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #12421: URL: https://github.com/apache/iotdb/pull/12421#issuecomment-2077174154 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] Copy tsfile, its resources, and mods to the same directory when using multiple data directories [iotdb]

2024-04-25 Thread via GitHub
OneSizeFitsQuorum merged PR #12420: URL: https://github.com/apache/iotdb/pull/12420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

Re: [PR] Pipe: Reduce exception messages to avoid excess rpc payload and show pipe response [iotdb]

2024-04-25 Thread via GitHub
SteveYurongSu merged PR #12415: URL: https://github.com/apache/iotdb/pull/12415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

Re: [PR] [RatisConsensus] update ratis snapshot version [iotdb]

2024-04-25 Thread via GitHub
OneSizeFitsQuorum merged PR #12419: URL: https://github.com/apache/iotdb/pull/12419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

Re: [PR] Randomly choosing coordinator of add region [iotdb]

2024-04-25 Thread via GitHub
OneSizeFitsQuorum merged PR #12416: URL: https://github.com/apache/iotdb/pull/12416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

Re: [PR] Revert `-XX:GuaranteedSafepointInterval=0` JVM option [iotdb]

2024-04-25 Thread via GitHub
OneSizeFitsQuorum merged PR #12417: URL: https://github.com/apache/iotdb/pull/12417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

[PR] [RatisConsensus] update ratis snapshot version [iotdb]

2024-04-25 Thread via GitHub
SzyWilliam opened a new pull request, #12419: URL: https://github.com/apache/iotdb/pull/12419 diff patch https://github.com/apache/ratis/pull/1069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] pipe return createuser raw plan. [iotdb]

2024-04-25 Thread via GitHub
shuolinl opened a new pull request, #12418: URL: https://github.com/apache/iotdb/pull/12418 In this pr: confignode parser will return raw password authplan. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[PR] Revert `-XX:GuaranteedSafepointInterval=0` JVM option [iotdb]

2024-04-25 Thread via GitHub
Pengzna opened a new pull request, #12417: URL: https://github.com/apache/iotdb/pull/12417 According to https://bugs.openjdk.org/browse/JDK-8304316 and https://bugs.openjdk.org/browse/JDK-8305994, when `-XX:GuaranteedSafepointInterval=0` and certain versions of JDK 15 ~ JDK 17 are used, th

Re: [PR] Pipe: Added check for wal disable and ratis consensus when enabling data region processing [iotdb]

2024-04-25 Thread via GitHub
SteveYurongSu merged PR #12407: URL: https://github.com/apache/iotdb/pull/12407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

Re: [PR] Refactor MultiTsFileDeviceIterator.MeasurementIterator [iotdb]

2024-04-25 Thread via GitHub
shuwenwei commented on code in PR #12221: URL: https://github.com/apache/iotdb/pull/12221#discussion_r1579113574 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/utils/MultiTsFileDeviceIteratorTest.java: ## @@ -82,6 +90,70 @@ public vo

Re: [PR] update Export/ImportDataTestIT [iotdb]

2024-04-25 Thread via GitHub
CloudWise-Lukemiao merged PR #12399: URL: https://github.com/apache/iotdb/pull/12399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...

Re: [PR] Fix Concurrency Instability When IoTConsensus LogDispatcher Exits [iotdb]

2024-04-25 Thread via GitHub
OneSizeFitsQuorum merged PR #12411: URL: https://github.com/apache/iotdb/pull/12411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

Re: [PR] Implementation of device TTL [iotdb]

2024-04-25 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1579025404 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/TTLManager.java: ## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Refactor MultiTsFileDeviceIterator.MeasurementIterator [iotdb]

2024-04-25 Thread via GitHub
choubenson commented on code in PR #12221: URL: https://github.com/apache/iotdb/pull/12221#discussion_r1579018001 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/utils/MultiTsFileDeviceIteratorTest.java: ## @@ -82,6 +90,70 @@ public v

Re: [PR] Pipe: handle OUT_OF_TTL status code when data syncing [iotdb]

2024-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #12414: URL: https://github.com/apache/iotdb/pull/12414#issuecomment-2076556906 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] Pipe: handle OUT_OF_TTL status code when data syncing [iotdb]

2024-04-25 Thread via GitHub
SteveYurongSu merged PR #12414: URL: https://github.com/apache/iotdb/pull/12414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

[PR] Pipe: Reduce exception messages to avoid excess rpc payload and show pipe response [iotdb]

2024-04-25 Thread via GitHub
Caideyipi opened a new pull request, #12415: URL: https://github.com/apache/iotdb/pull/12415 ## Description ### Content1 ... ### Content2 ... ### Content3 ... This PR has: - [ ] been self-reviewed. - [ ] con

[PR] Pipe: handle OUT_OF_TTL status code when date syncing [iotdb]

2024-04-25 Thread via GitHub
SteveYurongSu opened a new pull request, #12414: URL: https://github.com/apache/iotdb/pull/12414 As title. ``` create pipe test11 with source ('source.path'='root.**', 'inclusion'='data,schema' ,'source.realtime.mode'='stream','source.realtime.enable'='true','source.forwarding-pip