Re: [PR] Bump golang.org/x/net from 0.17.0 to 0.23.0 in /iotdb-connector/grafana-plugin [iotdb]

2024-04-29 Thread via GitHub
HTHou merged PR #12379: URL: https://github.com/apache/iotdb/pull/12379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache

Re: [PR] [rel/1.3] Fixed rest insertTablet http api lost data event [iotdb]

2024-04-29 Thread via GitHub
HTHou closed pull request #12386: [rel/1.3] Fixed rest insertTablet http api lost data event URL: https://github.com/apache/iotdb/pull/12386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Fix compaction selector ut [iotdb]

2024-04-29 Thread via GitHub
OneSizeFitsQuorum merged PR #12442: URL: https://github.com/apache/iotdb/pull/12442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

Re: [PR] Modify initConfigManager() [iotdb]

2024-04-29 Thread via GitHub
OneSizeFitsQuorum merged PR #12452: URL: https://github.com/apache/iotdb/pull/12452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

Re: [PR] Normalize LoadCache interfaces [iotdb]

2024-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #12441: URL: https://github.com/apache/iotdb/pull/12441#issuecomment-2084468995 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] Normalize LoadCache interfaces [iotdb]

2024-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #12441: URL: https://github.com/apache/iotdb/pull/12441#issuecomment-2084413805 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

[PR] Fixed backup path detection and optimized output log file names [iotdb]

2024-04-29 Thread via GitHub
CloudWise-Lukemiao opened a new pull request, #12454: URL: https://github.com/apache/iotdb/pull/12454 Fixed backup path detection and optimized output log file names -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] 突然停电后,iotdb重启失败 [iotdb]

2024-04-29 Thread via GitHub
github-actions[bot] commented on issue #12453: URL: https://github.com/apache/iotdb/issues/12453#issuecomment-2084398081 Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community! -- This is an automated message from the Apache Git Service. To re

[I] 突然停电后,iotdb重启失败 [iotdb]

2024-04-29 Thread via GitHub
ClancyLv opened a new issue, #12453: URL: https://github.com/apache/iotdb/issues/12453 使用iotdb版本号:1.2.2 服务器版本:Linux lyc-uos 4.19.0-91.82.152.uelc20.x86_64 #1 SMP Fri May 12 22:38:01 CST 2023 x86_64 x86_64 x86_64 GNU/Linux 突然停电后来电,其他mysql、redis正常开机启动,iotdb无法正常开机启动,iotdb已配置开机自启,后来手动执行启动脚本s

Re: [I] [Bug] 在Rocky Linux无法启动 [iotdb]

2024-04-29 Thread via GitHub
github-actions[bot] commented on issue #12451: URL: https://github.com/apache/iotdb/issues/12451#issuecomment-2084302695 Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community! -- This is an automated message from the Apache Git Service. To re

[I] [Bug] 在Rocky Linux无法启动 [iotdb]

2024-04-29 Thread via GitHub
Clownsw opened a new issue, #12451: URL: https://github.com/apache/iotdb/issues/12451 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/iotdb/issues) and found nothing similar. ### Version 1.1.0-standalone ### Describe the bug

Re: [PR] Lift the storage limit for tag and attribute management [iotdb]

2024-04-29 Thread via GitHub
JackieTien97 commented on code in PR #12447: URL: https://github.com/apache/iotdb/pull/12447#discussion_r1584008968 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/tag/TagLogFile.java: ## @@ -95,22 +102,85 @@ public synchronized void copyTo(Fil

Re: [PR] Lift the storage limit for tag and attribute management [iotdb]

2024-04-29 Thread via GitHub
JackieTien97 commented on code in PR #12447: URL: https://github.com/apache/iotdb/pull/12447#discussion_r1584008968 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/tag/TagLogFile.java: ## @@ -95,22 +102,85 @@ public synchronized void copyTo(Fil

Re: [PR] Enable macos CI [iotdb-client-csharp]

2024-04-29 Thread via GitHub
HTHou merged PR #5: URL: https://github.com/apache/iotdb-client-csharp/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.

Re: [PR] Ensuring IoTconsensus data consistency during region migration [iotdb]

2024-04-29 Thread via GitHub
OneSizeFitsQuorum merged PR #12448: URL: https://github.com/apache/iotdb/pull/12448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

[PR] Fix health_chech bug [iotdb]

2024-04-29 Thread via GitHub
CloudWise-Lukemiao opened a new pull request, #12450: URL: https://github.com/apache/iotdb/pull/12450 Fix the issue of obtaining Windows directory permissions,and the issue of allocating IoTDB memory for configuration, and add the -- help command -- This is an automated message from the A

Re: [PR] Ensuring IoTconsensus data consistency during region migration [iotdb]

2024-04-29 Thread via GitHub
codecov[bot] commented on PR #12448: URL: https://github.com/apache/iotdb/pull/12448#issuecomment-2082518827 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12448?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

Re: [PR] update spotless version [iotdb]

2024-04-29 Thread via GitHub
chrisdutz commented on PR #12345: URL: https://github.com/apache/iotdb/pull/12345#issuecomment-2082461974 That was the magic PR number 😉 12345 😉 the next one is going to be quite a bit of time 123456 Von: Haonan ***@***.***> Datum: Montag, 29. April 2024 um 12:56 An: apache/iotd

Re: [PR] add blame [iotdb]

2024-04-29 Thread via GitHub
HTHou merged PR #12449: URL: https://github.com/apache/iotdb/pull/12449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache

Re: [PR] Ensuring IoTconsensus data consistency during region migration [iotdb]

2024-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #12448: URL: https://github.com/apache/iotdb/pull/12448#issuecomment-2082448569 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] update spotless version [iotdb]

2024-04-29 Thread via GitHub
HTHou merged PR #12345: URL: https://github.com/apache/iotdb/pull/12345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache

Re: [PR] pref(bat): support space in path [iotdb]

2024-04-29 Thread via GitHub
HTHou merged PR #12435: URL: https://github.com/apache/iotdb/pull/12435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache

Re: [PR] [IOTDB-1667] Speed up the deletion of database by avoiding flush [iotdb]

2024-04-29 Thread via GitHub
OneSizeFitsQuorum merged PR #12445: URL: https://github.com/apache/iotdb/pull/12445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

Re: [PR] Allowing create statement from bad connection [iotdb]

2024-04-29 Thread via GitHub
OneSizeFitsQuorum merged PR #12444: URL: https://github.com/apache/iotdb/pull/12444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

[PR] Lift the storage limit for tag and attribute management [iotdb]

2024-04-29 Thread via GitHub
linxt20 opened a new pull request, #12447: URL: https://github.com/apache/iotdb/pull/12447 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] Implementation of device TTL [iotdb]

2024-04-29 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582708491 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/schedule/CompactionScheduleSummary.java: ## @@ -20,12 +20,21 @@ package

Re: [PR] Implementation of device TTL [iotdb]

2024-04-29 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582708244 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/task/SettleCompactionTask.java: ## @@ -0,0 +1,389 @@ +/* + * Lic

Re: [PR] [IOTDB-1667] Speed up the deletion of database by avoiding flush [iotdb]

2024-04-29 Thread via GitHub
codecov[bot] commented on PR #12445: URL: https://github.com/apache/iotdb/pull/12445#issuecomment-2082119331 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12445?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

Re: [PR] Implementation of device TTL [iotdb]

2024-04-29 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r158267 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java: ## @@ -516,6 +516,24 @@ public class IoTDBConfig { /** The interval of compaction

Re: [PR] Implementation of device TTL [iotdb]

2024-04-29 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582681168 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms # default_ttl_in_ms=-1

Re: [PR] Implementation of device TTL [iotdb]

2024-04-29 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582678724 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms # default_ttl_in_ms=-1

Re: [PR] Implementation of device TTL [iotdb]

2024-04-29 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582677960 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms # default_ttl_in_ms=-1

Re: [PR] Implementation of device TTL [iotdb]

2024-04-29 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582676924 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/settle/SettleCompactionRecoverTest.java: ## @@ -0,0 +1,1137 @@ +/* + * L

Re: [PR] Implementation of device TTL [iotdb]

2024-04-29 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582667045 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/schema/source/DeviceSchemaSource.java: ## @@ -98,6 +100,8 @@ public void tran

Re: [PR] Implementation of device TTL [iotdb]

2024-04-29 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582658723 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms # default_ttl_in_ms=-1

Re: [PR] Implementation of device TTL [iotdb]

2024-04-29 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582657290 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/conf/CommonConfig.java: ## @@ -119,6 +119,9 @@ public class CommonConfig { */ private long[]

Re: [PR] Implementation of device TTL [iotdb]

2024-04-29 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582651501 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,335 @@ +/* + * Lice

Re: [PR] [IOTDB-1667] Speed up the deletion of database by avoiding flush [iotdb]

2024-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #12445: URL: https://github.com/apache/iotdb/pull/12445#issuecomment-2082057042 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

[PR] [IOTDB-1667] Speed up the deletion of database by avoiding flush [iotdb]

2024-04-29 Thread via GitHub
HTHou opened a new pull request, #12445: URL: https://github.com/apache/iotdb/pull/12445 ## Description https://issues.apache.org/jira/browse/IOTDB-1667 ## How to test Add a UT in DataRegionTest. Before this PR, syncDeleteDataFiles costs `101ms ~ 1121ms`. After this