Re: [I] [Bug] NPE when deleting timeseries via Java API [iotdb]

2024-05-06 Thread via GitHub
bossenti commented on issue #12473: URL: https://github.com/apache/iotdb/issues/12473#issuecomment-2097497917 My bad  Please apologize, thank you for your help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [Bug] NPE when deleting timeseries via Java API [iotdb]

2024-05-06 Thread via GitHub
bossenti closed issue #12473: [Bug] NPE when deleting timeseries via Java API URL: https://github.com/apache/iotdb/issues/12473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Normalize LoadCache interfaces [iotdb]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #12441: URL: https://github.com/apache/iotdb/pull/12441#issuecomment-2097411662 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [I] iotdb支持ambari组件 [iotdb]

2024-05-06 Thread via GitHub
github-actions[bot] commented on issue #12475: URL: https://github.com/apache/iotdb/issues/12475#issuecomment-2097361070 Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community! -- This is an automated message from the Apache Git Service. To

[I] iotdb支持ambari组件 [iotdb]

2024-05-06 Thread via GitHub
smileyboy2019 opened a new issue, #12475: URL: https://github.com/apache/iotdb/issues/12475 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/iotdb/issues) and found nothing similar. ### Motivation iotdb 是否可以支持ambari插件,是否可以匹配插件服务

Re: [PR] Fix region migration code [iotdb]

2024-05-06 Thread via GitHub
OneSizeFitsQuorum merged PR #12472: URL: https://github.com/apache/iotdb/pull/12472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Limit direct buffer memory cost when create consensus region [iotdb]

2024-05-06 Thread via GitHub
OneSizeFitsQuorum merged PR #12431: URL: https://github.com/apache/iotdb/pull/12431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Load: Avoid NPE when load task ends after clean task's execution [iotdb]

2024-05-06 Thread via GitHub
SteveYurongSu merged PR #12474: URL: https://github.com/apache/iotdb/pull/12474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Bug] NPE when deleting timeseries via Java API [iotdb]

2024-05-06 Thread via GitHub
HTHou commented on issue #12473: URL: https://github.com/apache/iotdb/issues/12473#issuecomment-2097237807 Hi @bossenti , `executeQueryStatement` is for query statement only. You should use `executeNonQueryStatement` for delete statement. -- This is an automated message from the Apache

Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #12398: URL: https://github.com/apache/iotdb/pull/12398#issuecomment-2096426862 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #12398: URL: https://github.com/apache/iotdb/pull/12398#issuecomment-2096245511 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Load: Avoid NPE when load task ends after clean task's execution [iotdb]

2024-05-06 Thread via GitHub
codecov[bot] commented on PR #12474: URL: https://github.com/apache/iotdb/pull/12474#issuecomment-2096072565 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12474?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Load: Avoid NPE when load task ends after clean task's execution [iotdb]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #12474: URL: https://github.com/apache/iotdb/pull/12474#issuecomment-2095992260 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [I] [Bug] NPE when deleting timeseries via Java API [iotdb]

2024-05-06 Thread via GitHub
github-actions[bot] commented on issue #12473: URL: https://github.com/apache/iotdb/issues/12473#issuecomment-2095975803 Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community! -- This is an automated message from the Apache Git Service. To

[I] [Bug] NPE when deleting timeseries via Java API [iotdb]

2024-05-06 Thread via GitHub
bossenti opened a new issue, #12473: URL: https://github.com/apache/iotdb/issues/12473 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/iotdb/issues) and found nothing similar. ### Version 1.3.0 (Java API) ### Describe the

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-06 Thread via GitHub
JackieTien97 commented on code in PR #12393: URL: https://github.com/apache/iotdb/pull/12393#discussion_r1590950784 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/last/LastQueryOperator.java: ## @@ -173,4 +178,15 @@ public long

Re: [PR] Subscription: randomly generate consumer group id and consumer id if not exist & validate topic config ahead on DN [iotdb]

2024-05-06 Thread via GitHub
SteveYurongSu merged PR #12467: URL: https://github.com/apache/iotdb/pull/12467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Pipe IT: Return directly when SQL retry failed in IT to avoid potential fake failure interference [iotdb]

2024-05-06 Thread via GitHub
SteveYurongSu merged PR #12468: URL: https://github.com/apache/iotdb/pull/12468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Pipe: Fixed connector subtask manager to allow restarted DataRegions to reuse connectors from other not restarted DataRegions [iotdb]

2024-05-06 Thread via GitHub
SteveYurongSu merged PR #12470: URL: https://github.com/apache/iotdb/pull/12470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Load: Add WritePointRateLimiter to control load writing point rate [iotdb]

2024-05-06 Thread via GitHub
Caideyipi commented on code in PR #12356: URL: https://github.com/apache/iotdb/pull/12356#discussion_r1590868276 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/load/LoadTsFileRateLimiter.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache

Re: [PR] Load: Add WritePointRateLimiter to control load writing point rate [iotdb]

2024-05-06 Thread via GitHub
Caideyipi commented on code in PR #12356: URL: https://github.com/apache/iotdb/pull/12356#discussion_r1590841482 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/load/LoadTsFileRateLimiter.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache

Re: [PR] Limit direct buffer memory cost when create consensus region [iotdb]

2024-05-06 Thread via GitHub
OneSizeFitsQuorum commented on code in PR #12431: URL: https://github.com/apache/iotdb/pull/12431#discussion_r1590800057 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java: ## @@ -3456,12 +3460,37 @@ public void markDeleted() {

Re: [PR] Modify the strategy of compaction schedule [iotdb]

2024-05-06 Thread via GitHub
OneSizeFitsQuorum commented on code in PR #12469: URL: https://github.com/apache/iotdb/pull/12469#discussion_r1590787458 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/task/InnerSpaceCompactionTask.java: ## @@ -510,6 +511,13

Re: [PR] remove connector it [iotdb]

2024-05-06 Thread via GitHub
HTHou merged PR #12471: URL: https://github.com/apache/iotdb/pull/12471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Fix]. add alter view statement in snapshot parser. [iotdb]

2024-05-06 Thread via GitHub
JackieTien97 merged PR #12460: URL: https://github.com/apache/iotdb/pull/12460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] remove connector it [iotdb]

2024-05-06 Thread via GitHub
CritasWang opened a new pull request, #12471: URL: https://github.com/apache/iotdb/pull/12471 based on https://github.com/apache/iotdb/pull/12373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] Pipe: Fixed connector lifeCycle to allow restarted DataRegions to reuse connectors from other not restarted DataRegions [iotdb]

2024-05-06 Thread via GitHub
Caideyipi opened a new pull request, #12470: URL: https://github.com/apache/iotdb/pull/12470 ## Description As the title said. This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [

[PR] Modify the strategy of compaction schedule [iotdb]

2024-05-06 Thread via GitHub
shuwenwei opened a new pull request, #12469: URL: https://github.com/apache/iotdb/pull/12469 ## Description Modify the strategy of compaction schedule. 1. Skip compaction selection if the queue is full. 2. Skip high level inner compaction when there are zero level inner

[PR] Pipe: Return directly when SQL retry failed in IT to avoid potential fake failure interference [iotdb]

2024-05-06 Thread via GitHub
Caideyipi opened a new pull request, #12468: URL: https://github.com/apache/iotdb/pull/12468 ## Description As the title said. This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [

[PR] Subscription: randomly generate consumer group id and consumer id if not exist & validate topic config ahead on DN [iotdb]

2024-05-06 Thread via GitHub
VGalaxies opened a new pull request, #12467: URL: https://github.com/apache/iotdb/pull/12467 As title. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #12393: URL: https://github.com/apache/iotdb/pull/12393#issuecomment-2095302936 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #12393: URL: https://github.com/apache/iotdb/pull/12393#issuecomment-2095272672 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-06 Thread via GitHub
lancelly commented on code in PR #12393: URL: https://github.com/apache/iotdb/pull/12393#discussion_r1590580947 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/PlanNodeType.java: ## @@ -209,6 +209,8 @@ public enum PlanNodeType {

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-06 Thread via GitHub
lancelly commented on code in PR #12393: URL: https://github.com/apache/iotdb/pull/12393#discussion_r1590580899 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/PlanNodeType.java: ## @@ -209,6 +209,8 @@ public enum PlanNodeType {

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-06 Thread via GitHub
lancelly commented on code in PR #12393: URL: https://github.com/apache/iotdb/pull/12393#discussion_r1590580783 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/PlanNodeType.java: ## @@ -209,6 +209,8 @@ public enum PlanNodeType {

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #12393: URL: https://github.com/apache/iotdb/pull/12393#issuecomment-2095261780 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate