sunjincheng121 commented on issue #739: [hotfix] Simplify the setting of Locale 
defaults for String.format().
URL: https://github.com/apache/incubator-iotdb/pull/739#issuecomment-574533265
 
 
   Thanks for your review @JulianFeinauer !
   
   At the beginning I really wanted to restore the locale in the tearDown () 
method,  but in that way, we should keep the original `Locale` info which is 
make the change a little bit complex, furthermore, currently, we always need 
`Locale.ENGLISH` in all of testCase, so, I think the change is fine. 
   
   But I am fine, if you really want to do it, which make the code looks pretty 
complete.
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to