Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

SteveYurongSu merged PR #13016: URL: https://github.com/apache/iotdb/pull/13016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

SteveYurongSu commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1806826438 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/pipeconsensus/PipeConsensusSyncConnector.java: ## @@ -221,6 +221,74 @@ private vo

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

OneSizeFitsQuorum commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1806292750 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/runtime/PipeDataNodeRuntimeAgent.java: ## @@ -168,7 +168,7 @@ public RecoverProgressIndex

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1806036378 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/consensus/deletion/recover/DeletionReader.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Caideyipi commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1797630291 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/consensus/deletion/recover/DeletionReader.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Soft

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1797625208 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/historical/PipeHistoricalDataRegionTsFileAndDeletionExtractor.java: ## @@ -651,6 +721

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1797623193 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/consensus/DeletionResourceTest.java: ## @@ -0,0 +1,203 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1797620098 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/consensus/DeletionResourceTest.java: ## @@ -0,0 +1,203 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1797620045 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/consensus/DeletionResourceTest.java: ## @@ -0,0 +1,203 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1797619870 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/consensus/DeletionResourceTest.java: ## @@ -0,0 +1,203 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1797619840 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/consensus/DeletionRecoverTest.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1797619677 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/historical/PipeHistoricalDataRegionTsFileAndDeletionExtractor.java: ## @@ -251,7 +258

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Caideyipi commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1796867893 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/historical/PipeHistoricalDataRegionTsFileAndDeletionExtractor.java: ## @@ -651,6 +7

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Caideyipi commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1796841786 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/consensus/DeletionResourceTest.java: ## @@ -0,0 +1,203 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Caideyipi commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1796699681 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/consensus/DeletionRecoverTest.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1796646399 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/historical/PipeHistoricalDataRegionTsFileAndDeletionExtractor.java: ## @@ -573,6 +611

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Caideyipi commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1792973709 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/historical/PipeHistoricalDataRegionTsFileAndDeletionExtractor.java: ## @@ -251,7 +2

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Caideyipi commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1792962546 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/historical/PipeHistoricalDataRegionTsFileAndDeletionExtractor.java: ## @@ -573,6 +6

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

OneSizeFitsQuorum commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1776647658 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/pipeconsensus/PipeConsensusAsyncConnector.java: ## @@ -400,13 +401,16 @@ publ

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1767900545 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/consensus/deletion/DeletionResourceManager.java: ## @@ -0,0 +1,323 @@ +/* + * Licensed to the Apache Softw

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1767896475 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/consensus/deletion/DeletionResourceManager.java: ## @@ -0,0 +1,323 @@ +/* + * Licensed to the Apache Softw

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1767056155 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/realtime/listener/PipeInsertionDataNodeListener.java: ## @@ -141,9 +145,14 @@ public

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1766906092 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/schema/PipeSchemaRegionWritePlanEvent.java: ## @@ -58,6 +60,26 @@ public PlanNode getPlanNode

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1766281551 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/consensus/DeletionResourceTest.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1766281137 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/consensus/DeletionResourceTest.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1766279273 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/consensus/deletion/DeletionResource.java: ## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1764595383 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/schema/PipeSchemaRegionWritePlanEvent.java: ## @@ -58,6 +60,26 @@ public PlanNode getPlanNode

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1759689799 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/historical/PipeHistoricalDataRegionTsFileAndDeletionExtractor.java: ## @@ -382,113 +5

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1759688295 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/realtime/PipeRealtimeEventFactory.java: ## @@ -61,9 +61,11 @@ public static PipeRealtimeEvent create

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Pengzna commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1759687716 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/pipeconsensus/PipeConsensusSyncConnector.java: ## @@ -221,6 +220,73 @@ private void doT

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Caideyipi commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1759647846 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/consensus/DeletionResourceTest.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Caideyipi commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1759647554 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/consensus/DeletionResourceTest.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Caideyipi commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1759655760 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/consensus/deletion/DeletionResourceManager.java: ## @@ -0,0 +1,323 @@ +/* + * Licensed to the Apache Sof

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Caideyipi commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1759642727 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/consensus/DeletionResourceTest.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Caideyipi commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1759641118 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/consensus/deletion/DeletionResource.java: ## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Software F

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Caideyipi commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1758627789 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/realtime/listener/PipeInsertionDataNodeListener.java: ## @@ -141,9 +145,14 @@ publi

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Caideyipi commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1758529328 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/historical/PipeHistoricalDataRegionTsFileAndDeletionExtractor.java: ## @@ -382,113

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

Caideyipi commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1758444766 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/realtime/PipeRealtimeEventFactory.java: ## @@ -61,9 +61,11 @@ public static PipeRealtimeEvent crea