[kudu-CR] Add release notes for tablet history GC

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add release notes for tablet history GC .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2912/ -- To view, visit

[kudu-CR] Add release notes for tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3988 to review the following change. Change subject: Add release notes for tablet history GC .. Add release notes for

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Another pass on 0.10.0 release notes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3979/1/docs/release_notes.adoc File docs/release_notes.adoc:

[kudu-CR] KUDU-236 (part 2). Create randomized tablet history GC itest

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236 (part 2). Create randomized tablet history GC itest .. Patch Set 7: I ran 3000 loops of this with 3000 rounds each and they all passed (in RELEASE mode).

[kudu-CR] Support downgrade to version that has LocalConsensus

2016-08-15 Thread Mike Percy (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3985 to review the following change. Change subject: Support downgrade to version that has LocalConsensus ..

[kudu-CR] Update some comments in Tablet impl and rename a method

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Update some comments in Tablet impl and rename a method .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2906/ -- To view, visit

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3983 to review the following change. Change subject: KUDU-236 (part 3). Enable tablet history GC by default .. KUDU-236

[kudu-CR] Various comment / doc improvements

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Various comment / doc improvements .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2908/ -- To view, visit

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 3). Enable tablet history GC by default .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2910/ -- To view, visit

[kudu-CR] MergeIterator: don't stop iterating on an empty block

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: MergeIterator: don't stop iterating on an empty block .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2909/ -- To view, visit

[kudu-CR] KUDU-236 (part 2). Create randomized tablet history GC itest

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3975 to look at the new patch set (#7). Change subject: KUDU-236 (part 2). Create randomized tablet history GC itest

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#14). Change subject: KUDU-236 (part 1). Implement tablet history GC ..

[kudu-CR] KUDU-236 (part 2). Create randomized tablet history GC itest

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 2). Create randomized tablet history GC itest .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2904/ -- To view, visit

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 13: > Could you also add a GCing thread to mt-tablet-test? It's a good > way to test interactions

[kudu-CR] MergeIterator: don't stop iterating on an empty block

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: MergeIterator: don't stop iterating on an empty block .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-236 (part 2). Create randomized tablet history GC itest

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3975 to look at the new patch set (#6). Change subject: KUDU-236 (part 2). Create randomized tablet history GC itest

[kudu-CR] Various comment / doc improvements

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Various comment / doc improvements .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2902/ -- To view, visit

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2900/ -- To view, visit

[kudu-CR] Various comment / doc improvements

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3977 to look at the new patch set (#2). Change subject: Various comment / doc improvements .. Various

[kudu-CR] Update some comments in Tablet impl and rename a method

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3981 to review the following change. Change subject: Update some comments in Tablet impl and rename a method .. Update

[kudu-CR] Update some comments in Tablet impl and rename a method

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Update some comments in Tablet impl and rename a method .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2903/ -- To view, visit

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 13: Build Started http://104.196.14.100/job/kudu-gerrit/2901/ -- To view, visit

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#13). Change subject: KUDU-236 (part 1). Implement tablet history GC ..

[kudu-CR] KUDU-1522 Fix AlterTable Timestamp col with default value

2016-08-15 Thread Ram Mettu (Code Review)
Ram Mettu has posted comments on this change. Change subject: KUDU-1522 Fix AlterTable Timestamp col with default value .. Patch Set 1: @Todd I fixed your comments, it created a new gerrit code review - may be something wrong

[kudu-CR] KUDU-1522 Fix AlterTable Timestamp col with default value

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1522 Fix AlterTable Timestamp col with default value .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2898/ -- To view, visit

[kudu-CR] KUDU-1522 Fix AlterTable Timestamp col with default value

2016-08-15 Thread Ram Mettu (Code Review)
Ram Mettu has uploaded a new change for review. http://gerrit.cloudera.org:8080/3980 Change subject: KUDU-1522 Fix AlterTable Timestamp col with default value .. KUDU-1522 Fix AlterTable Timestamp col with default value

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Another pass on 0.10.0 release notes .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2897/ -- To view, visit

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3979 to review the following change. Change subject: Another pass on 0.10.0 release notes ..

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-15 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#5). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2896/ -- To view, visit

[kudu-CR] [util/env posix.cc] fixed build on MacOS X

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [util/env_posix.cc] fixed build on MacOS X .. [util/env_posix.cc] fixed build on MacOS X Fixed a tiny typo which broke build on MacOS X. This is a

[kudu-CR] [util/env posix.cc] fixed build on MacOS X

2016-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util/env_posix.cc] fixed build on MacOS X .. Patch Set 1: > oops, my bad! np, and thank you for the instant review! -- To view, visit

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-526: use on-disk cmeta when loading existing master state .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2895/ -- To view, visit

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-526: use on-disk cmeta when loading existing master state .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3786 To

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3786 to look at the new patch set (#7). Change subject: KUDU-526: use on-disk cmeta when loading existing master state

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-526: use on-disk cmeta when loading existing master state .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2894/ -- To view, visit

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3786 to look at the new patch set (#6). Change subject: KUDU-526: use on-disk cmeta when loading existing master state

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 15: Build Started http://104.196.14.100/job/kudu-gerrit/2892/ -- To view, visit

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2891/ -- To view, visit

[kudu-CR] Memory tracking for result tracker

2016-08-15 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3627 to look at the new patch set (#21). Change subject: Memory tracking for result tracker .. Memory tracking

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3961 to look at the new patch set (#3). Change subject: Start a background thread to run ResultTracker GC .. Start a

[kudu-CR] Memory tracking for result tracker

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 21: Build Started http://104.196.14.100/job/kudu-gerrit/2893/ -- To view, visit

[kudu-CR] [util/env posix.cc] fixed build on MacOS X

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [util/env_posix.cc] fixed build on MacOS X .. Patch Set 1: Code-Review+2 oops, my bad! -- To view, visit http://gerrit.cloudera.org:8080/3978 To unsubscribe,

[kudu-CR] [util/env posix.cc] fixed build on MacOS X

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [util/env_posix.cc] fixed build on MacOS X .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2890/ -- To view, visit

[kudu-CR] Memory tracking for result tracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 20: (3 comments) http://gerrit.cloudera.org:8080/#/c/3627/19/src/kudu/rpc/result_tracker.cc File

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-526: use on-disk cmeta when loading existing master state .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2889/ -- To view, visit

[kudu-CR] Replace gscoped ptr with unique ptr for ConsensusMetadata

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: Replace gscoped_ptr with unique_ptr for ConsensusMetadata .. Replace gscoped_ptr with unique_ptr for ConsensusMetadata Change-Id:

<    1   2