[kudu-CR] [security] moved x509 check host under ca sub-dir

2017-01-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: [security] moved x509_check_host under ca sub-dir .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/5777 To unsubscribe, visit

[kudu-CR] [security] moved x509 check host under ca sub-dir

2017-01-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] moved x509_check_host under ca sub-dir .. Patch Set 1: > hm, what's the logic here? 'ca' sounds like it should be code used > by a certificate

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-23 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-23 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 2: > (1 comment) > > Jun, what motivated you to make this change

[kudu-CR] Control mutex stack walking in DEBUG mode with a gflag

2017-01-23 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5741 to look at the new patch set (#7). Change subject: Control mutex stack walking in DEBUG mode with a gflag ..

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-23 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#22). Change subject: Add Google Breakpad support to Kudu .. Add Google Breakpad

[kudu-CR] [security] moved x509 check host under ca sub-dir

2017-01-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] moved x509_check_host under ca sub-dir .. Patch Set 1: hm, what's the logic here? 'ca' sounds like it should be code used by a certificate authority,

[kudu-CR] Use Traits to avoid duplicate code in SSL wrappers

2017-01-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: Use Traits to avoid duplicate code in SSL wrappers .. Use Traits to avoid duplicate code in SSL wrappers cert_management.cc contained some duplicate

[kudu-CR] [security] moved x509 check host under ca sub-dir

2017-01-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5777 Change subject: [security] moved x509_check_host under ca sub-dir .. [security] moved x509_check_host under ca sub-dir There are no

[kudu-CR] WIP: KUDU-1713: add a client Partitioner API

2017-01-23 Thread Todd Lipcon (Code Review)
Hello Matthew Jacobs, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5775 to review the following change. Change subject: WIP: KUDU-1713: add a client Partitioner API .. WIP: KUDU-1713:

[kudu-CR] security: generate certs on the tserver, sign them on the master

2017-01-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: security: generate certs on the tserver, sign them on the master .. Patch Set 2: (5 comments)

[kudu-CR] security: generate certs on the tserver, sign them on the master

2017-01-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: security: generate certs on the tserver, sign them on the master .. Patch Set 2: (1 comment)

[kudu-CR] ca: allow creating a self-signed CA

2017-01-23 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: ca: allow creating a self-signed CA .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5765 To unsubscribe, visit

[kudu-CR] security: generate certs on the tserver, sign them on the master

2017-01-23 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: security: generate certs on the tserver, sign them on the master .. Patch Set 2: (5 comments)

[kudu-CR] ca: allow creating a self-signed CA

2017-01-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: ca: allow creating a self-signed CA .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5765 To unsubscribe, visit

[kudu-CR] ca: allow creating a self-signed CA

2017-01-23 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5765 to look at the new patch set (#2). Change subject: ca: allow creating a self-signed CA .. ca: allow creating a

[kudu-CR] ca: allow creating a self-signed CA

2017-01-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ca: allow creating a self-signed CA .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5765/1/src/kudu/security/ca/cert_management.h File

[kudu-CR] ca: allow creating a self-signed CA

2017-01-23 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: ca: allow creating a self-signed CA .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5765/1/src/kudu/security/ca/cert_management.h File

[kudu-CR] ca: allow creating a self-signed CA

2017-01-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ca: allow creating a self-signed CA .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/5765/1/src/kudu/security/ca/cert_management.cc File

[kudu-CR] Control mutex stack walking in DEBUG mode with a gflag

2017-01-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Control mutex stack walking in DEBUG mode with a gflag .. Patch Set 6: Filed glog issue for this @ https://github.com/google/glog/issues/160 -- To view, visit

[kudu-CR] Use Traits to avoid duplicate code in SSL wrappers

2017-01-23 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Use Traits to avoid duplicate code in SSL wrappers .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5767 To unsubscribe, visit

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-23 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 2: -Code-Review (1 comment) Jun, what motivated you to

[kudu-CR] tool: remove dead code

2017-01-23 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: tool: remove dead code .. tool: remove dead code Change-Id: I93b173c4f2f91d1d7466f99ddc3264a8796e5b51 Reviewed-on: http://gerrit.cloudera.org:8080/5770

[kudu-CR] Use Traits to avoid duplicate code in SSL wrappers

2017-01-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Use Traits to avoid duplicate code in SSL wrappers .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] tool: remove dead code

2017-01-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: tool: remove dead code .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5770 To unsubscribe, visit

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 21: (13 comments) http://gerrit.cloudera.org:8080/#/c/5620/20/build-support/jenkins/build-and-test.sh File

[kudu-CR] Use Traits to avoid duplicate code in SSL wrappers

2017-01-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Use Traits to avoid duplicate code in SSL wrappers .. Patch Set 3: (2 comments)

[kudu-CR] TLS-negotiation [5/n]: Rename sasl [client|server] to [client|server] negotiation

2017-01-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: TLS-negotiation [5/n]: Rename sasl_[client|server] to [client|server]_negotiation .. TLS-negotiation [5/n]: Rename sasl_[client|server] to

[kudu-CR] TLS-negotiation [5/n]: Rename sasl [client|server] to [client|server] negotiation

2017-01-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [5/n]: Rename sasl_[client|server] to [client|server]_negotiation .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] TLS-negotiation [4/n]: rename Negotiation steps

2017-01-23 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: TLS-negotiation [4/n]: rename Negotiation steps .. TLS-negotiation [4/n]: rename Negotiation steps This makes it more clear which steps are

[kudu-CR] TLS-negotiation [3/n]: rename negotiation protobuf messages

2017-01-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: TLS-negotiation [3/n]: rename negotiation protobuf messages .. TLS-negotiation [3/n]: rename negotiation protobuf messages SASL negotiation in the RPC

[kudu-CR] TLS-negotiation [4/n]: rename Negotiation steps

2017-01-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [4/n]: rename Negotiation steps .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5758 To unsubscribe, visit

[kudu-CR] TLS-negotiation [3/n]: rename negotiation protobuf messages

2017-01-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [3/n]: rename negotiation protobuf messages .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5757 To unsubscribe,

[kudu-CR](gh-pages) Change links for old releases to Apache archive

2017-01-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Change links for old releases to Apache archive .. Change links for old releases to Apache archive Apache doesn't like to keep old versions around on

[kudu-CR] KUDU-1835 (part 2): enable WAL compression

2017-01-23 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5736 to look at the new patch set (#8). Change subject: KUDU-1835 (part 2): enable WAL compression .. KUDU-1835 (part

[kudu-CR] Use Traits to avoid duplicate code in SSL wrappers

2017-01-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Use Traits to avoid duplicate code in SSL wrappers .. Patch Set 3: (2 comments)

[kudu-CR] Use Traits to avoid duplicate code in SSL wrappers

2017-01-23 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Use Traits to avoid duplicate code in SSL wrappers .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5767/3/src/kudu/security/ca/cert_management.cc

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

2017-01-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1836. Enable compression of DeltaFiles .. KUDU-1836. Enable compression of DeltaFiles This adds a new experimental flag for this setting, and

[kudu-CR] KUDU-1835 (part 1). Move compression codec classes to util

2017-01-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1835 (part 1). Move compression codec classes to util .. KUDU-1835 (part 1). Move compression codec classes to util This creates a new library

[kudu-CR] tool: remove dead code

2017-01-23 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: remove dead code .. Patch Set 1: Code-Review+1 It's good you noticed them Adar. Ship it from my side. -- To view, visit

[kudu-CR] [kudu-jepsen] fixed misprints in packaged mode

2017-01-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [kudu-jepsen] fixed misprints in packaged mode .. Patch Set 1: (1 comment) The regular Jenkins jobs overrides those properties -- it sets the names for nodes,

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-23 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#21). Change subject: Add Google Breakpad support to Kudu .. Add Google Breakpad

[kudu-CR] tool: remove dead code

2017-01-23 Thread Adar Dembo (Code Review)
Hello Dinesh Bhat, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5770 to review the following change. Change subject: tool: remove dead code .. tool: remove dead code

[kudu-CR] rpc: add basic service and method-level authorization

2017-01-23 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: rpc: add basic service and method-level authorization .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4897/1/src/kudu/rpc/service_if.cc File

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

2017-01-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1836. Enable compression of DeltaFiles .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5737 To unsubscribe, visit

[kudu-CR] [kudu-jepsen] fixed misprints in packaged mode

2017-01-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] fixed misprints in packaged mode .. Patch Set 1: (1 comment) also are you sure that the regular jenkins job would not be broken by the

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-23 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation .. Patch Set 6: (12 comments) http://gerrit.cloudera.org:8080/#/c/5760/5/src/kudu/rpc/client_negotiation.cc File

[kudu-CR] TLS-negotiation [5/n]: Rename sasl [client|server] to [client|server] negotiation

2017-01-23 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5759 to look at the new patch set (#4). Change subject: TLS-negotiation [5/n]: Rename sasl_[client|server] to [client|server]_negotiation

[kudu-CR] TLS-negotiation [3/n]: rename negotiation protobuf messages

2017-01-23 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [3/n]: rename negotiation protobuf messages .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5757/2/src/kudu/rpc/sasl_server.cc

[kudu-CR] TLS-negotiation [3/n]: rename negotiation protobuf messages

2017-01-23 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5757 to look at the new patch set (#3). Change subject: TLS-negotiation [3/n]: rename negotiation protobuf messages ..

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-23 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5760 to look at the new patch set (#6). Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation ..

[kudu-CR] TLS-negotiation [4/n]: rename Negotiation steps

2017-01-23 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5758 to look at the new patch set (#3). Change subject: TLS-negotiation [4/n]: rename Negotiation steps ..

[kudu-CR] [kudu-jepsen] fixed misprints in packaged mode

2017-01-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5769 Change subject: [kudu-jepsen] fixed misprints in packaged mode .. [kudu-jepsen] fixed misprints in packaged mode Fixed misprint in

[kudu-CR] ca: allow creating a self-signed CA

2017-01-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: ca: allow creating a self-signed CA .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/5765/1/src/kudu/security/ca/cert_management.cc File

[kudu-CR] TLS-negotiation [1/n]: deprecate unused SaslAuth fields

2017-01-23 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: TLS-negotiation [1/n]: deprecate unused SaslAuth fields .. TLS-negotiation [1/n]: deprecate unused SaslAuth fields This commit deprecates two fields in

[kudu-CR] TLS-negotiation [2/n]: remove SASL ANONYMOUS mechanism

2017-01-23 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: TLS-negotiation [2/n]: remove SASL ANONYMOUS mechanism .. TLS-negotiation [2/n]: remove SASL ANONYMOUS mechanism ANONYMOUS has not been enabled on any

[kudu-CR] Use Traits to avoid duplicate code in SSL wrappers

2017-01-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Use Traits to avoid duplicate code in SSL wrappers .. Patch Set 3: (2 comments) Thank you for doing this. I was thinking to do that at some point as well, but