[kudu-CR] [java client] Limit the message size in Status

2017-02-10 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Limit the message size in Status .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/5956/1//COMMIT_MSG Commit Message: Line 16

[kudu-CR] [java client] Limit the message size in Status

2017-02-10 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5956 to look at the new patch set (#2). Change subject: [java client] Limit the message size in Status .. [java client]

[kudu-CR] [docs] Update encodings section

2017-02-10 Thread Jean-Daniel Cryans (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5966 to review the following change. Change subject: [docs] Update encodings section .. [docs] Update encodings section Wi

[kudu-CR] java: add TLS support

2017-02-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: java: add TLS support .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5949 To unsubscribe, visit http://gerrit.cloudera.org:8080/s

[kudu-CR] java: implement Channel Bindings

2017-02-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: java: implement Channel Bindings .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5953/2/java/kudu-client/src/main/java/org/apache/ku

[kudu-CR] [security] tailored TokenSigner for system catalog

2017-02-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] tailored TokenSigner for system catalog .. Patch Set 7: (3 comments) I have some high level questions about the direction of TokenSigner and AuthnToke

[kudu-CR] [security] tailored TokenSigner for system catalog

2017-02-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] tailored TokenSigner for system catalog .. Patch Set 7: > (3 comments) Thank you for the review. > I have some high level questions about the dire

[kudu-CR] KUDU-1866: Add request-side sidecars

2017-02-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: KUDU-1866: Add request-side sidecars .. Patch Set 6: Looks like an unrelated test failure to me, although I'm unable to build locally to confirm. -- To view,

[kudu-CR] KUDU-1866: Add request-side sidecars

2017-02-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: KUDU-1866: Add request-side sidecars .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5908/6/src/kudu/rpc/outbound_call.h File src/kudu/rpc/outb

[kudu-CR] KUDU-1866: Add request-side sidecars

2017-02-10 Thread Henry Robinson (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5908 to look at the new patch set (#7). Change subject: KUDU-1866: Add request-side sidecars .. KUDU-1866: Add request-s

[kudu-CR] [rpc] Assume existence of TlsContext during negotiation

2017-02-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [rpc] Assume existence of TlsContext during negotiation .. Patch Set 2: > (1 comment) ok, doing that in a separate patch sounds like a good option. -- To view

[kudu-CR] [rpc] Assume existence of TlsContext during negotiation

2017-02-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [rpc] Assume existence of TlsContext during negotiation .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5946 To unsubscribe, vis

[kudu-CR] [rpc] Assume existence of TlsContext during negotiation

2017-02-10 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [rpc] Assume existence of TlsContext during negotiation .. [rpc] Assume existence of TlsContext during negotiation This changes the client and server RPC

[kudu-CR] [java client] Limit the message size in Status

2017-02-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Limit the message size in Status .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5956 To unsubscribe, visit http://ge

[kudu-CR] WIP [security] load/store public TSK in the system table

2017-02-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP [security] load/store public TSK in the system table .. Patch Set 5: (34 comments) I did a first pass. I think the most important question to settle is whether

[kudu-CR] [security] generate self-signed certs on server startup

2017-02-10 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5955 to look at the new patch set (#4). Change subject: [security] generate self-signed certs on server startup .. [secu

[kudu-CR] [security] generate self-signed certs on server startup

2017-02-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] generate self-signed certs on server startup .. Patch Set 4: (9 comments) It looks like the leak that's causing asan test failures may be internal to

[kudu-CR] [security] tailored TokenSigner for system catalog

2017-02-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] tailored TokenSigner for system catalog .. Patch Set 7: > Good observation. As I understand, AuthnTokenManager was modeled to run > along with MasterC

[kudu-CR] java: add TLS support

2017-02-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: java: add TLS support .. java: add TLS support This adds support for negotiating and speaking TLS in the Java client. Testing is a bit light here, becaus

[kudu-CR] java: implement Channel Bindings

2017-02-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: java: implement Channel Bindings .. java: implement Channel Bindings This adds a utility function for calculating RFC 5929 "tls-server-endpoint" channel b

[kudu-CR] [java client] Limit the message size in Status

2017-02-10 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Limit the message size in Status .. [java client] Limit the message size in Status We've seen cases where RPC traces that are getting

[kudu-CR] [security] tailored TokenSigner for system catalog

2017-02-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] tailored TokenSigner for system catalog .. Patch Set 7: > > Good observation. As I understand, AuthnTokenManager was modeled > to run along with Mas

[kudu-CR] csd: remove from repo

2017-02-10 Thread Adar Dembo (Code Review)
Hello Jean-Daniel Cryans, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5973 to review the following change. Change subject: csd: remove from repo .. csd: remove from repo It