[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-22 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#17). Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. KUDU-1601. Delete ancient UNDO delta blocks in the background This patch adds a maintenance manager

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 16: (7 comments) http://gerrit.cloudera.org:8080/#/c/4363/16/src/kudu/tablet/de

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 16: Verified+1 The ITClient test failed most likely due to KUDU-1894. Overriding. -- To

[kudu-CR] security: authorize all RPCs against coarse-grained ACLs

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: security: authorize all RPCs against coarse-grained ACLs .. Patch Set 6: Verified+1 Both test failures seem unrelated. This needs a bit of touch-up but it's worth

[kudu-CR] security: authorize all RPCs against coarse-grained ACLs

2017-02-22 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5998 to look at the new patch set (#6). Change subject: security: authorize all RPCs against coarse-grained ACLs .. secu

[kudu-CR] [security] Add require authentication option to C++ client

2017-02-22 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6121 to look at the new patch set (#2). Change subject: [security] Add require_authentication option to C++ client .. [s

[kudu-CR] [token-test] fixed TestTokenSignerAddKeys flakiness

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [token-test] fixed TestTokenSignerAddKeys flakiness .. Patch Set 3: Verified+1 Flaky MasterStressTest.Test -- To view, visit http://gerrit.cloudera.org:8080/61

[kudu-CR] [security] Add require authentication option to C++ client

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] Add require_authentication option to C++ client .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6121/1/src/kudu/rpc/messenger.cc Fil

[kudu-CR] [security] Add require authentication option to C++ client

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] Add require_authentication option to C++ client .. Patch Set 1: ... but I think I forgot to set --keytab_file. Either way, we should probably error out

[kudu-CR] [security] Add require authentication option to C++ client

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] Add require_authentication option to C++ client .. Patch Set 1: testing this on a cluster I'm getting Not authorized: Could not connect to the cluster:

[kudu-CR] [token-test] fixed TestTokenSignerAddKeys flakiness

2017-02-22 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6117 to look at the new patch set (#3). Change subject: [token-test] fixed TestTokenSignerAddKeys flakiness

[kudu-CR] [IPKI] log WARNING --> INFO on CA info generation

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [IPKI] log WARNING --> INFO on CA info generation .. Patch Set 1: Verified+1 Known flaky MasterReplicationTest.TestCycleThroughAllMasters -- To view, visit htt

[kudu-CR] [IPKI] log WARNING --> INFO on CA info generation

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [IPKI] log WARNING --> INFO on CA info generation .. [IPKI] log WARNING --> INFO on CA info generation Changed log level from WARNING to INFO on the eve

[kudu-CR] IPKI: master CA should verify x509 attributes before signing certs

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: IPKI: master CA should verify x509 attributes before signing certs .. IPKI: master CA should verify x509 attributes before signing certs This makes the m

[kudu-CR] master: don't issue new authn tokens to TOKEN-authenticated users

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: master: don't issue new authn tokens to TOKEN-authenticated users .. master: don't issue new authn tokens to TOKEN-authenticated users Doing so would bas

[kudu-CR] [IPKI] log WARNING --> INFO on CA info generation

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [IPKI] log WARNING --> INFO on CA info generation .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6123 To unsubscribe, visit http:

[kudu-CR] [IPKI] log WARNING --> INFO on CA info generation

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6123 Change subject: [IPKI] log WARNING --> INFO on CA info generation .. [IPKI] log WARNING --> INFO on CA info generation Changed log level

[kudu-CR] [token-test] fixed TestTokenSignerAddKeys flakiness

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [token-test] fixed TestTokenSignerAddKeys flakiness .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6117/2/src/kudu/security/token-test.cc File

[kudu-CR] IPKI: master CA should verify x509 attributes before signing certs

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: IPKI: master CA should verify x509 attributes before signing certs .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6118/2/src/kud

[kudu-CR] master: don't issue new authn tokens to TOKEN-authenticated users

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: master: don't issue new authn tokens to TOKEN-authenticated users .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6119/2/src/kudu

[kudu-CR] WIP: authorize all RPCs against coarse-grained ACLs

2017-02-22 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5998 to look at the new patch set (#5). Change subject: WIP: authorize all RPCs against coarse-grained ACLs .. WIP: auth

[kudu-CR] [security] TokenSigner requires non-empty username

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [security] TokenSigner requires non-empty username .. [security] TokenSigner requires non-empty username TokenSigner requires non-empty username when ge

[kudu-CR] [security] added info on non-renewable authn tokens

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6122 Change subject: [security] added info on non-renewable authn tokens .. [security] added info on non-renewable authn tokens It's not poss

[kudu-CR] client: support exporting/importing authentication data

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: client: support exporting/importing authentication data .. Patch Set 5: Code-Review+2 Carrying +2 -- To view, visit http://gerrit.cloudera.org:8080/6086 To unsub

[kudu-CR] client: support exporting/importing authentication data

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: client: support exporting/importing authentication data .. client: support exporting/importing authentication data This adds the C++ side of being able to

[kudu-CR] [security] Add require authentication option to C++ client

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] Add require_authentication option to C++ client .. Patch Set 1: (1 comment) looks like this needs a rebase on top of the import/export creds patch (som

[kudu-CR] [security] Add require authentication option to C++ client

2017-02-22 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6121 to review the following change. Change subject: [security] Add require_authentication option to C++ client .

[kudu-CR] [token-test] fixed TestTokenSignerAddKeys flakiness

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [token-test] fixed TestTokenSignerAddKeys flakiness .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6117/2/src/kudu/security/token-test.cc File sr

[kudu-CR] rpc: separately capture full principal name and short username

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: rpc: separately capture full principal name and short username .. rpc: separately capture full principal name and short username This changes GSSAPI authe

[kudu-CR] rpc: separately capture full principal name and short username

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: separately capture full principal name and short username .. Patch Set 7: Code-Review+2 Carrying +2 -- To view, visit http://gerrit.cloudera.org:8080/6106 T

[kudu-CR] [token-test] fixed TestTokenSignerAddKeys flakiness

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [token-test] fixed TestTokenSignerAddKeys flakiness .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6117/2/src/kudu/security/token-test.cc File

[kudu-CR] [token-test] fixed TestTokenSignerAddKeys flakiness

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [token-test] fixed TestTokenSignerAddKeys flakiness .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6117/2/src/kudu/security/token-test.cc File s

[kudu-CR] [security] TokenSigner requires non-empty username

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] TokenSigner requires non-empty username .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6120 To unsubscribe, visit http

[kudu-CR] rpc: separately capture full principal name and short username

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: rpc: separately capture full principal name and short username .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6106/6/src/kudu/rpc/server_negoti

[kudu-CR] [security] TokenSigner requires non-empty username

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6120 Change subject: [security] TokenSigner requires non-empty username .. [security] TokenSigner requires non-empty username TokenSigner req

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-22 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4363 to look at the new patch set (#16). Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background ..

[kudu-CR] client: support exporting/importing authentication data

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: client: support exporting/importing authentication data .. Patch Set 4: Just a rebase (hit some conflicts from concurrent patches) -- To view, visit http://gerri

[kudu-CR] client: support exporting/importing authentication data

2017-02-22 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6086 to look at the new patch set (#5). Change subject: client: support exporting/importing authentication data ...

[kudu-CR] client: support exporting/importing authentication data

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: client: support exporting/importing authentication data .. Patch Set 4: Verified+1 Known flake again -- To view, visit http://gerrit.cloudera.org:8080/6086 To un

[kudu-CR] rpc: separately capture full principal name and short username

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: separately capture full principal name and short username .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6106/6/src/kudu/rpc/server_negotiat

[kudu-CR] rpc: separately capture full principal name and short username

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: rpc: separately capture full principal name and short username .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6106/6/src/kudu/rpc/server_negoti

[kudu-CR] master: don't issue new authn tokens to TOKEN-authenticated users

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: master: don't issue new authn tokens to TOKEN-authenticated users .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6119/2/src/kudu/master/master_s

[kudu-CR] rpc: add a new RemoteUser class for the server side user info

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: add a new RemoteUser class for the server side user info .. Patch Set 5: Code-Review+2 Carrying +2 after rebase -- To view, visit http://gerrit.cloudera.org

[kudu-CR] IPKI: change X509 attribute fields

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: IPKI: change X509 attribute fields .. Patch Set 4: Same flake. Will prioritize fixing that ASAP but not due to this patch. -- To view, visit http://gerrit.cloude

[kudu-CR] rpc: add a new RemoteUser class for the server side user info

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: rpc: add a new RemoteUser class for the server side user info .. rpc: add a new RemoteUser class for the server side user info We were previously using Us

[kudu-CR] IPKI: change X509 attribute fields

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: IPKI: change X509 attribute fields .. IPKI: change X509 attribute fields This switches the attributes of the IPKI certs as follows: CN = FQDN of host use

[kudu-CR] IPKI: change X509 attribute fields

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: IPKI: change X509 attribute fields .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6116 To unsubscribe, visit http://gerrit.cloudera.

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-22 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4363 to look at the new patch set (#15). Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background ..

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 14: (11 comments) http://gerrit.cloudera.org:8080/#/c/4363/13/src/kudu/tablet/tablet.cc

[kudu-CR] master: don't issue new authn tokens to TOKEN-authenticated users

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: master: don't issue new authn tokens to TOKEN-authenticated users .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6119/2/src/kudu/master/master

[kudu-CR] master: don't issue new authn tokens to TOKEN-authenticated users

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: master: don't issue new authn tokens to TOKEN-authenticated users .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6119 To unsub

[kudu-CR] IPKI: master CA should verify x509 attributes before signing certs

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: IPKI: master CA should verify x509 attributes before signing certs .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6118/2/src/kudu/integration-te

[kudu-CR] IPKI: master CA should verify x509 attributes before signing certs

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: IPKI: master CA should verify x509 attributes before signing certs .. Patch Set 2: (1 comment) lgtm, just one small nit. http://gerrit.cloudera.org:8080/#/c/6

[kudu-CR] KUDU-1493: Implement SchemaRelationProvider

2017-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1493: Implement SchemaRelationProvider .. KUDU-1493: Implement SchemaRelationProvider Implement SchemaRelationProvider org.apache.kudu.spark.kudu.Def

[kudu-CR] KUDU-1493: Implement SchemaRelationProvider

2017-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1493: Implement SchemaRelationProvider .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5167 To unsubscribe, visit http://gerr

[kudu-CR] IPKI: master CA should verify x509 attributes before signing certs

2017-02-22 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6118 to look at the new patch set (#2). Change subject: IPKI: master CA should verify x509 attributes before signing certs .

[kudu-CR] rpc: separately capture full principal name and short username

2017-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: rpc: separately capture full principal name and short username .. Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6106/5/src/kudu/rpc/n

[kudu-CR] [docs] added info on TSK an CA entries in systable

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [docs] added info on TSK an CA entries in systable .. [docs] added info on TSK an CA entries in systable Change-Id: I3c75d792981c3152f5844a2ea6934c0ce00

[kudu-CR] [docs] added info on TSK an CA entries in systable

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [docs] added info on TSK an CA entries in systable .. Patch Set 4: Verified+1 Unrelated flaky MasterReplicationTest.TestCycleThroughAllMasters -- To view, visi

[kudu-CR] master: don't issue new authn tokens to TOKEN-authenticated users

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: master: don't issue new authn tokens to TOKEN-authenticated users .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6119 To unsub

[kudu-CR] [token-test] fixed TestTokenSignerAddKeys flakiness

2017-02-22 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6117 to look at the new patch set (#2). Change subject: [token-test] fixed TestTokenSignerAddKeys flakiness

[kudu-CR] KuduRDD.collect fails because of NoSerializableException

2017-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KuduRDD.collect fails because of NoSerializableException .. Patch Set 4: I'm still keen to merge https://gerrit.cloudera.org/#/c/5636/ instead of this one. Will

[kudu-CR] KUDU-1824. KuduRDD.collect fails because of NoSerializableException

2017-02-22 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5636 to look at the new patch set (#3). Change subject: KUDU-1824. KuduRDD.collect fails because of NoSerializableException

[kudu-CR] KUDU-1824. KuduRDD.collect fails because of NoSerializableException

2017-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1824. KuduRDD.collect fails because of NoSerializableException .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5636/2//COMMIT_MSG Commit Me

[kudu-CR] master: don't issue new authn tokens to TOKEN-authenticated users

2017-02-22 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6119 to review the following change. Change subject: master: don't issue new authn tokens to TOKEN-authenticated users .

[kudu-CR] IPKI: master CA should verify x509 attributes before signing certs

2017-02-22 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6118 to review the following change. Change subject: IPKI: master CA should verify x509 attributes before signing certs

[kudu-CR] rpc: separately capture full principal name and short username

2017-02-22 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6106 to look at the new patch set (#6). Change subject: rpc: separately capture full principal name and short username ..

[kudu-CR] rpc: separately capture full principal name and short username

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: separately capture full principal name and short username .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6106/5/src/kudu/rpc/negotiation-tes

[kudu-CR] IPKI: change X509 attribute fields

2017-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: IPKI: change X509 attribute fields .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6116 To unsubscribe, visit http://gerrit.cloude

[kudu-CR] rpc: separately capture full principal name and short username

2017-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: rpc: separately capture full principal name and short username .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/6106/5/src/kudu/rpc/negotiation-te

[kudu-CR] IPKI: change X509 attribute fields

2017-02-22 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6116 to look at the new patch set (#4). Change subject: IPKI: change X509 attribute fields ..

[kudu-CR] rpc: add a new RemoteUser class for the server side user info

2017-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: rpc: add a new RemoteUser class for the server side user info .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6105 To unsubscribe,

[kudu-CR] IPKI: remove unused fields from cert code

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: IPKI: remove unused fields from cert code .. Patch Set 3: Known flake (tracked on JIRA) -- To view, visit http://gerrit.cloudera.org:8080/6115 To unsubscribe, vi

[kudu-CR] IPKI: remove unused fields from cert code

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: IPKI: remove unused fields from cert code .. IPKI: remove unused fields from cert code This removes all of the X509 attributes that we weren't currently s

[kudu-CR] IPKI: remove unused fields from cert code

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: IPKI: remove unused fields from cert code .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6115 To unsubscribe, visit http://gerrit.cl

[kudu-CR] rpc: separately capture full principal name and short username

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: separately capture full principal name and short username .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/6106/5/src/kudu/rpc/negotiation-te

[kudu-CR] rpc: separately capture full principal name and short username

2017-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: rpc: separately capture full principal name and short username .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/6106/5/src/kudu/rpc/negotiation-te

[kudu-CR] rpc: add a new RemoteUser class for the server side user info

2017-02-22 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6105 to look at the new patch set (#4). Change subject: rpc: add a new RemoteUser class for the server side user info .

[kudu-CR] rpc: add a new RemoteUser class for the server side user info

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: add a new RemoteUser class for the server side user info .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6105/3/src/kudu/rpc/connection.h Fi

[kudu-CR] rpc: add a new RemoteUser class for the server side user info

2017-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: rpc: add a new RemoteUser class for the server side user info .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6105/3/src/kudu/rpc/server_negotiati

[kudu-CR] rpc: add a new RemoteUser class for the server side user info

2017-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: rpc: add a new RemoteUser class for the server side user info .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6105/3/src/kudu/rpc/server_negotiati

[kudu-CR] client: support exporting/importing authentication data

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: client: support exporting/importing authentication data .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6086 To unsubscribe, vis

[kudu-CR] rpc: add a new RemoteUser class for the server side user info

2017-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: rpc: add a new RemoteUser class for the server side user info .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6105/3/src/kudu/rpc/connection.h Fi

[kudu-CR] rpc: add a new RemoteUser class for the server side user info

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: rpc: add a new RemoteUser class for the server side user info .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6105/3/src/kudu/rpc/server_negotia

[kudu-CR] client: support exporting/importing authentication data

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: client: support exporting/importing authentication data .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6086/3/src/kudu/client/client.h File src/

[kudu-CR] client: support exporting/importing authentication data

2017-02-22 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6086 to look at the new patch set (#4). Change subject: client: support exporting/importing authentication data .

[kudu-CR] rpc: add a new RemoteUser class for the server side user info

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: add a new RemoteUser class for the server side user info .. Patch Set 3: Verified+1 Same master replication deadlock flake -- To view, visit http://gerrit.c

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 13: (11 comments) http://gerrit.cloudera.org:8080/#/c/4363/13/src/kudu/tablet/t

[kudu-CR] [docs] added info on TSK an CA entries in systable

2017-02-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [docs] added info on TSK an CA entries in systable .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6111 To unsubscribe, visit http:

[kudu-CR] [docs] added info on TSK an CA entries in systable

2017-02-22 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6111 to look at the new patch set (#4). Change subject: [docs] added info on TSK an CA entries in systable .. [docs] add

[kudu-CR] [token-test] fixed TestTokenSignerAddKeys flakiness

2017-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [token-test] fixed TestTokenSignerAddKeys flakiness .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6117 To unsubscribe, visit htt

[kudu-CR] java: fetch and adopt authn token and CA from master

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: java: fetch and adopt authn token and CA from master .. java: fetch and adopt authn token and CA from master This makes the Java client fetch a token and

[kudu-CR] client: support exporting/importing authentication data

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: client: support exporting/importing authentication data .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6086/3/src/kudu/client/client.h File sr

[kudu-CR] IPKI: change X509 attribute fields

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: IPKI: change X509 attribute fields .. Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/6116/1/src/kudu/security/cert-test.cc File src

[kudu-CR] java: fetch and adopt authn token and CA from master

2017-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: java: fetch and adopt authn token and CA from master .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6077 To unsubscribe, visit ht

[kudu-CR] [docs] added info on TSK an CA entries in systable

2017-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [docs] added info on TSK an CA entries in systable .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6111/1/docs/design-docs/master.md File docs/

[kudu-CR] IPKI: use authenticated local username as CN in certs

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. Change subject: IPKI: use authenticated local username as CN in certs .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6088 To unsubscribe, visit http://gerrit.cloudera.org:

[kudu-CR] IPKI: change X509 attribute fields

2017-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: IPKI: change X509 attribute fields .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6116/3/src/kudu/security/init.cc File src/kudu/security/init.cc

[kudu-CR] IPKI: change X509 attribute fields

2017-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: IPKI: change X509 attribute fields .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6116/3/src/kudu/security/init.cc File src/kudu/security/init.cc

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-22 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4363 to look at the new patch set (#14). Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background ..

  1   2   >