[kudu-CR] [delete table-test] Disable log compression on some tests

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: [delete_table-test] Disable log compression on some tests .. [delete_table-test] Disable log compression on some tests Some tests rely on log roll

[kudu-CR] [security] use shorter RSA keys in tests

2017-02-28 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6194 to look at the new patch set (#3). Change subject: [security] use shorter RSA keys in tests .. [security] use short

[kudu-CR] [security] protect against master SASL negotiation short-circuit

2017-02-28 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [security] protect against master SASL negotiation short-circuit .. [security] protect against master SASL negotiation short-circuit In both clients we we

[kudu-CR] [delete table-test] Disable log compression on some tests

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [delete_table-test] Disable log compression on some tests .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6200 To unsubscribe, vis

[kudu-CR] [delete table-test] Disable log compression on some tests

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6200 Change subject: [delete_table-test] Disable log compression on some tests .. [delete_table-test] Disable log compression on some te

[kudu-CR] KUDU-1898: /varz page doesn't HTML-escape flag values

2017-02-28 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1898: /varz page doesn't HTML-escape flag values .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6173/6/src/kudu/server/default-path-handlers.cc

[kudu-CR] KUDU-1898: /varz page doesn't HTML-escape flag values

2017-02-28 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6173 to look at the new patch set (#7). Change subject: KUDU-1898: /varz page doesn't HTML-escape flag values .. KUDU-18

[kudu-CR] [security] protect against master SASL negotiation short-circuit

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] protect against master SASL negotiation short-circuit .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6148 To unsubscri

[kudu-CR] server negotiation: improve error handling

2017-02-28 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: server_negotiation: improve error handling .. server_negotiation: improve error handling Unlike in the client negotiator, the server negotiator should sen

[kudu-CR] Make reduce flake from KUDU-1642 tests in client-test

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Make reduce flake from KUDU-1642 tests in client-test .. Make reduce flake from KUDU-1642 tests in client-test This ups the timeouts so the tests should b

[kudu-CR] Make reduce flake from KUDU-1642 tests in client-test

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Make reduce flake from KUDU-1642 tests in client-test .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5882 To unsubscribe, visit h

[kudu-CR] [security] protect against master SASL negotiation short-circuit

2017-02-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] protect against master SASL negotiation short-circuit .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6148/4/src/kudu/rpc/client_negoti

[kudu-CR] [security] protect against master SASL negotiation short-circuit

2017-02-28 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6148 to look at the new patch set (#5). Change subject: [security] protect against master SASL negotiation short-circuit .

[kudu-CR] server negotiation: improve error handling

2017-02-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: server_negotiation: improve error handling .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6154 To unsubscribe, visit http://ger

[kudu-CR] [security] protect against master SASL negotiation short-circuit

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] protect against master SASL negotiation short-circuit .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6148/4/src/kudu/rpc/client_negoti

[kudu-CR] [client-test] Reduce flakyness of TestWriteWithDeadTabletServer

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [client-test] Reduce flakyness of TestWriteWithDeadTabletServer .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6198 To unsubscrib

[kudu-CR] Reserve 512 MB of disk space by default

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Reserve 512 MB of disk space by default .. Patch Set 1: Sorry, above should say "disable this if we detect that the total disk size is *LESS* than 10G" -- To vi

[kudu-CR] [client-test] Reduce flakyness of TestWriteWithDeadTabletServer

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [client-test] Reduce flakyness of TestWriteWithDeadTabletServer .. [client-test] Reduce flakyness of TestWriteWithDeadTabletServer This test fails often d

[kudu-CR](branch-1.2.x) KUDU-1899. Fix support for empty string keys

2017-02-28 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6178 to look at the new patch set (#2). Change subject: KUDU-1899. Fix support for empty string keys ...

[kudu-CR] [security] use shorter RSA keys in tests

2017-02-28 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6194 to look at the new patch set (#2). Change subject: [security] use shorter RSA keys in tests .. [security] use short

[kudu-CR] [security] use shorter RSA keys in tests

2017-02-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] use shorter RSA keys in tests .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6194/1/src/kudu/integration-tests/external_mini_cluste

[kudu-CR] Workaround a leak in OpenSSL 1.0.0

2017-02-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Workaround a leak in OpenSSL 1.0.0 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6197 To unsubscribe, visit http://gerrit.cloude

[kudu-CR] [client-test] Reduce flakyness of TestWriteWithDeadTabletServer

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6198 Change subject: [client-test] Reduce flakyness of TestWriteWithDeadTabletServer .. [client-test] Reduce flakyness of TestWriteWithD

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. KUDU-1880 Prevent eager ignoring of NULLs During a nullable block scan, if a NULL set of cells is reached bef

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1904 Don't seek on empty RLE blocks .. KUDU-1904 Don't seek on empty RLE blocks Seeking in RLE blocks enforces that the seek position is less than th

[kudu-CR] [security] use 512 bit RSA keys for TSK in tests

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] use 512 bit RSA keys for TSK in tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6194/1/src/kudu/integration-tests/external_mini_c

[kudu-CR] KUDU-1898: /varz page doesn't HTML-escape flag values

2017-02-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1898: /varz page doesn't HTML-escape flag values .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6173/6/src/kudu/server/default-path-handlers.

[kudu-CR] Workaround a leak in OpenSSL 1.0.0

2017-02-28 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6197 to review the following change. Change subject: Workaround a leak in OpenSSL 1.0.0 .. Workaround a leak in OpenSSL 1.0

[kudu-CR] [security] protect against master SASL negotiation short-circuit

2017-02-28 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6148 to look at the new patch set (#4). Change subject: [security] protect against master SASL negotiation short-circuit .

[kudu-CR] server negotiation: improve error handling

2017-02-28 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6154 to look at the new patch set (#4). Change subject: server_negotiation: improve error handling .. server_negotiation

[kudu-CR] KUDU-1898: /varz page doesn't HTML-escape flag values

2017-02-28 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6173 to look at the new patch set (#6). Change subject: KUDU-1898: /varz page doesn't HTML-escape flag values .. KUDU-18

[kudu-CR] KUDU-1898: /varz page doesn't HTML-escape flag values

2017-02-28 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1898: /varz page doesn't HTML-escape flag values .. Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/6173/4/src/kudu/server/default-path-handlers.cc

[kudu-CR] [security] use 512 bit RSA keys for TSK in tests

2017-02-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] use 512 bit RSA keys for TSK in tests .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6194/1/src/kudu/integration-tests/external_mini_

[kudu-CR] KUDU-1896 (part 2): enable redaction on the web UI

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1896 (part 2): enable redaction on the web UI .. KUDU-1896 (part 2): enable redaction on the web UI When we first added log redaction, we decided not

[kudu-CR] KUDU-1898: /varz page doesn't HTML-escape flag values

2017-02-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1898: /varz page doesn't HTML-escape flag values .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/6173/5/src/kudu/server/default-path-handlers

[kudu-CR] Implement SchemaRelationProvider

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. Change subject: Implement SchemaRelationProvider .. Abandoned got done in http://gerrit.cloudera.org:8080/5167 -- To view, visit http://gerrit.cloudera.org:8080/3529 To unsubscribe, visi

[kudu-CR] [security] interface for certificate signing service

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. Change subject: [security] interface for certificate signing service .. Abandoned got done elsewhere -- To view, visit http://gerrit.cloudera.org:8080/5673 To unsubscribe, visit http://g

[kudu-CR] [security] Kudu certificate signing service

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. Change subject: [security] Kudu certificate signing service .. Abandoned got done elsewhere -- To view, visit http://gerrit.cloudera.org:8080/5674 To unsubscribe, visit http://gerrit.clo

[kudu-CR] [security] added TlsServer and TlsClient wrappers

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. Change subject: [security] added TlsServer and TlsClient wrappers .. Abandoned This got done in some other review by now -- To view, visit http://gerrit.cloudera.org:8080/4926 To unsubsc

[kudu-CR] KUDU-1898: /varz page doesn't HTML-escape flag values

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1898: /varz page doesn't HTML-escape flag values .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/6173/4/src/kudu/server/default-path-handler

[kudu-CR] KUDU-1898: /varz page doesn't HTML-escape flag values

2017-02-28 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6173 to look at the new patch set (#5). Change subject: KUDU-1898: /varz page doesn't HTML-escape flag values .. KUDU-18

[kudu-CR] KUDU-1898: /varz page doesn't HTML-escape flag values

2017-02-28 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6173 to look at the new patch set (#4). Change subject: KUDU-1898: /varz page doesn't HTML-escape flag values .. KUDU-18

[kudu-CR] KUDU-1898: /varz page doesn't HTML-escape flag values

2017-02-28 Thread Hao Hao (Code Review)
Hao Hao has abandoned this change. Change subject: KUDU-1898: /varz page doesn't HTML-escape flag values .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6195 To unsubscribe, visit http://gerrit.cloudera.org:8080

[kudu-CR] KUDU-1898: /varz page doesn't HTML-escape flag values

2017-02-28 Thread Hao Hao (Code Review)
Hao Hao has uploaded a new change for review. http://gerrit.cloudera.org:8080/6195 Change subject: KUDU-1898: /varz page doesn't HTML-escape flag values .. KUDU-1898: /varz page doesn't HTML-escape flag values This fixes the

[kudu-CR] [security] use 512 bit RSA keys for TSK in tests

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] use 512 bit RSA keys for TSK in tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6194/1/src/kudu/integration-tests/external_mini_c

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6112 To unsubscribe, visit http

[kudu-CR] [security] protect against master SASL negotiation short-circuit

2017-02-28 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6148 to look at the new patch set (#3). Change subject: [security] protect against master SASL negotiation short-circuit .

[kudu-CR] [security] use 512 bit RSA keys for TSK in tests

2017-02-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6194 Change subject: [security] use 512 bit RSA keys for TSK in tests .. [security] use 512 bit RSA keys for TSK in tests Change-Id: I1809087

[kudu-CR] KUDU-1898: /varz page doesn't HTML-escape flag values

2017-02-28 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1898: /varz page doesn't HTML-escape flag values .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6173/3/src/kudu/util/flags.h File src/kudu/util

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-28 Thread Hao Hao (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#15). Change subject: Combine redaction flag for log and flags into one. .

[kudu-CR] [delete table-test] Don't fail on multiple attempts to delete an orphaned tablet

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: [delete_table-test] Don't fail on multiple attempts to delete an orphaned tablet .. [delete_table-test] Don't fail on multiple attempts to delete

[kudu-CR] [delete table-test] Don't fail on multiple attempts to delete an orphaned tablet

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [delete_table-test] Don't fail on multiple attempts to delete an orphaned tablet .. Patch Set 4: Verified+1 unrelated flake TsRecoveryITest.TestRestartWit

[kudu-CR] KUDU-1896 (part 2): enable redaction on the web UI

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1896 (part 2): enable redaction on the web UI .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6193/1/src/kudu/server/webserver.cc File src/ku

[kudu-CR] spark: send authentication credentials to tasks

2017-02-28 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6081 to look at the new patch set (#6). Change subject: spark: send authentication credentials to tasks .. spark: send a

[kudu-CR] spark: send authentication credentials to tasks

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: spark: send authentication credentials to tasks .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6081/5/java/kudu-spark/src/main/scala/org/apache/k

[kudu-CR] Fix security tests on macOS

2017-02-28 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Fix security tests on macOS .. Fix security tests on macOS This fixes a few issues: * The macOS Heimdal Kerberos implementation stubs out krb5_anam

[kudu-CR] spark: send authentication credentials to tasks

2017-02-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: spark: send authentication credentials to tasks .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6081/5/java/kudu-spark/src/main/scala/org/apache/k

[kudu-CR] KUDU-1896 (part 2): enable redaction on the web UI

2017-02-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1896 (part 2): enable redaction on the web UI .. Patch Set 1: Code-Review+2 -Verified -- To view, visit http://gerrit.cloudera.org:8080/6193 To unsubscribe,

[kudu-CR] KUDU-1896 (part 2): enable redaction on the web UI

2017-02-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1896 (part 2): enable redaction on the web UI .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6193 To unsubscribe, visit http://

[kudu-CR] KUDU-1896 (part 2): enable redaction on the web UI

2017-02-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1896 (part 2): enable redaction on the web UI .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6193/1/src/kudu/server/webserver.c

[kudu-CR] KUDU-1896 (part 2): enable redaction on the web UI

2017-02-28 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Hao Hao, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6193 to review the following change. Change subject: KUDU-1896 (part 2): enable redaction on the web UI ...

[kudu-CR] Reserve 512 MB of disk space by default

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Reserve 512 MB of disk space by default .. Patch Set 1: Can we do something like disable this if we detect that the total disk size is more than 10G or something?

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 11: think these failures might be unrelated, should likely re-trigger -- To view, visit http://ger

[kudu-CR] Reserve 512 MB of disk space by default

2017-02-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Reserve 512 MB of disk space by default .. Patch Set 1: Code-Review+2 Looks reasonable to me, but let's also get a rough consensus from other committers that this

[kudu-CR] Reserve 512 MB of disk space by default

2017-02-28 Thread Mike Percy (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6192 to review the following change. Change subject: Reserve 512 MB of disk space by default .. Reserve 512 MB of disk space

[kudu-CR] Fix security tests on macOS

2017-02-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix security tests on macOS .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6176 To unsubscribe, visit http://gerrit.cloudera.org:8

[kudu-CR] [delete table-test] Don't fail on multiple attempts to delete an orphaned tablet

2017-02-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [delete_table-test] Don't fail on multiple attempts to delete an orphaned tablet .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6

[kudu-CR] server negotiation: improve error handling

2017-02-28 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6154 to look at the new patch set (#3). Change subject: server_negotiation: improve error handling .. server_negotiation

[kudu-CR] Fix security tests on macOS

2017-02-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Fix security tests on macOS .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/6176/2/src/kudu/security/init.cc File src/kudu/security/init.cc: Lin

[kudu-CR] [delete table-test] Don't fail on multiple attempts to delete an orphaned tablet

2017-02-28 Thread David Ribeiro Alves (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6191 to look at the new patch set (#4). Change subject: [delete_table-test] Don't fail on multiple attempts to delete an orphaned tablet ..

[kudu-CR] [delete table-test] Don't fail on multiple attempts to delete an orphaned tablet

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [delete_table-test] Don't fail on multiple attempts to delete an orphaned tablet .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6191/2/

[kudu-CR] [delete table-test] Don't fail on multiple attempts to delete an orphaned tablet

2017-02-28 Thread David Ribeiro Alves (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6191 to look at the new patch set (#3). Change subject: [delete_table-test] Don't fail on multiple attempts to delete an orphaned tablet ..

[kudu-CR] [delete table-test] Don't fail on multiple attempts to delete an orphaned tablet

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [delete_table-test] Don't fail on multiple attempts to delete an orphaned tablet .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] Fix security tests on macOS

2017-02-28 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6176 to look at the new patch set (#4). Change subject: Fix security tests on macOS .. Fix security tests on macOS This

[kudu-CR] [delete table-test] Don't fail on multiple attempts to delete an orphaned tablet

2017-02-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [delete_table-test] Don't fail on multiple attempts to delete an orphaned tablet .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6191/2/src/kudu/

[kudu-CR] [delete table-test] Don't fail on multiple attempts to delete an orphaned tablet

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: [delete_table-test] Don't fail on multiple attempts to delete an orphaned tablet .. [delete_table-test] Don't fail on multiple attempts to delete an orphaned

[kudu-CR] [delete table-test] Don't fail on multiple attempts to delete an orphaned tablet

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6191 Change subject: [delete_table-test] Don't fail on multiple attempts to delete an orphaned tablet .. [delete_table-test] Don't fail

[kudu-CR] spark: send authentication credentials to tasks

2017-02-28 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6081 to look at the new patch set (#5). Change subject: spark: send authentication credentials to tasks .

[kudu-CR] spark: send authentication credentials to tasks

2017-02-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: spark: send authentication credentials to tasks .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6081/3/java/kudu-spark/src/main/scala/org/apache/k

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-28 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#11). Change subject: KUDU-1880 Prevent eager ignoring of NULLs .

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 11: Code-Review+2 lgtm, assuming tests pass -- To view, visit http://gerrit.cloudera.org:8080/6029

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1904 Don't seek on empty RLE blocks .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6184 To unsubscribe, visit http:/

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

2017-02-28 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6184 to look at the new patch set (#5). Change subject: KUDU-1904 Don't seek on empty RLE blocks .. KUDU-1904 Don't seek

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-28 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#10). Change subject: KUDU-1880 Prevent eager ignoring of NULLs .

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6029 To unsubscribe, visit http:

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 9: (9 comments) http://gerrit.cloudera.org:8080/#/c/6029/6/src/kudu/common/column_materialization_context.h

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-28 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#9). Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. KUDU-1880 Prevent e

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-28 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#8). Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. KUDU-1880 Prevent e

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1904 Don't seek on empty RLE blocks .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6184/4/src/kudu/cfile/rle_block.h File src/kudu/c

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

2017-02-28 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6184 to look at the new patch set (#4). Change subject: KUDU-1904 Don't seek on empty RLE blocks .. KUDU-1904 Don't seek

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-28 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#7). Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. KUDU-1880 Prevent e

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1904 Don't seek on empty RLE blocks .. Patch Set 3: lgtm, just waiting for the commit that has coverage for this to +2 -- To view, visit http://gerr

[kudu-CR] WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-02-28 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/6066/2//COMMIT_MSG

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

2017-02-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1904 Don't seek on empty RLE blocks .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6184/2/src/kudu/cfile/rle_block.h File src/kudu/cfile/rle

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

2017-02-28 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6184 to look at the new patch set (#3). Change subject: KUDU-1904 Don't seek on empty RLE blocks .. KUDU-1904 Don't seek

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1904 Don't seek on empty RLE blocks .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6184/2/src/kudu/cfile/rle_block.h File src/kudu/c

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

2017-02-28 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#2). Change subject: KUDU-1904 Don't seek on empty RLE blocks .. KUDU-1904 Don't seek on empty RLE blocks Seeking in RLE blocks enforces that the seek position is less than the number of

[kudu-CR] KUDU-1901. Fix crash in concurrent OpenSSL usage

2017-02-28 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6187 to review the following change. Change subject: KUDU-1901. Fix crash in concurrent OpenSSL usage .. KUD

[kudu-CR] spark: send authentication credentials to tasks

2017-02-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: spark: send authentication credentials to tasks .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6081/3/java/kudu-spark/src/main/scala/org/apache/k

[kudu-CR] Fix security tests on macOS

2017-02-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix security tests on macOS .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6176/3/src/kudu/security/init.cc File src/kudu/security/init.cc: PS3,

  1   2   >