[kudu-CR] [docs] guide on assertions in the Java code

2017-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [docs] guide on assertions in the Java code .. Patch Set 1: Verified+1 Unrelated flake in RaftConsensusITest.TestElectPendingVoter -- To view, visit http://ger

[kudu-CR] [docs] guide on assertions in the Java code

2017-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7549 Change subject: [docs] guide on assertions in the Java code .. [docs] guide on assertions in the Java code Added guide on using assert a

[kudu-CR] [docs] fixed typos in raft-config-change.md

2017-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7548 Change subject: [docs] fixed typos in raft-config-change.md .. [docs] fixed typos in raft-config-change.md Change-Id: Ie1f43915b5f2a3939

[kudu-CR] consensus: always add backoff when snoozing failure detectors

2017-07-31 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7546 to look at the new patch set (#2). Change subject: consensus: always add backoff when snoozing failure detectors ..

[kudu-CR] consensus peers: capture weak refs in functors submitted to thread pools

2017-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus_peers: capture weak refs in functors submitted to thread pools .. Patch Set 3: Code-Review+2 Maybe worth looping raft_consensus-itest a bunch before com

[kudu-CR] consensus peers: capture weak refs in functors submitted to thread pools

2017-07-31 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7543 to look at the new patch set (#3). Change subject: consensus_peers: capture weak refs in functors submitted to thread pools ...

[kudu-CR] consensus peers: capture weak refs in functors submitted to thread pools

2017-07-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus_peers: capture weak refs in functors submitted to thread pools .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7543/2//COMMIT_MSG Commi

[kudu-CR] Expose running maintenance op info

2017-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Expose running maintenance op info .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7537/2/src/kudu/util/maintenance_manager.h File src/kudu/util/m

[kudu-CR] consensus peers: capture weak refs in functors submitted to thread pools

2017-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus_peers: capture weak refs in functors submitted to thread pools .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7543/2//COMMIT_MSG Comm

[kudu-CR] consensus: always add backoff when snoozing failure detectors

2017-07-31 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7546 to review the following change. Change subject: consensus: always add backoff when snoozing failure detectors .

[kudu-CR] KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-07-31 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7545 to review the following change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks ..

[kudu-CR] log block manager: mark container as read-only after syncing error

2017-07-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: mark container as read-only after syncing error .. Patch Set 21: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7374 To unsubs

[kudu-CR] log block manager: mark container as read-only after syncing error

2017-07-31 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: log block manager: mark container as read-only after syncing error .. Patch Set 21: (2 comments) http://gerrit.cloudera.org:8080/#/c/7374/20/src/kudu/fs/log_block_ma

[kudu-CR] log block manager: mark container as read-only after syncing error

2017-07-31 Thread Hao Hao (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7374 to look at the new patch set (#21). Change subject: log block manager: mark container as read-only after syncing error

[kudu-CR] log block manager: mark container as read-only after syncing error

2017-07-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: mark container as read-only after syncing error .. Patch Set 20: (2 comments) http://gerrit.cloudera.org:8080/#/c/7374/20/src/kudu/fs/log_block

[kudu-CR] log block manager: mark container as read-only after syncing error

2017-07-31 Thread Hao Hao (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7374 to look at the new patch set (#20). Change subject: log block manager: mark container as read-only after syncing error

[kudu-CR] consensus peers: capture weak refs in functors submitted to thread pools

2017-07-31 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7543 to review the following change. Change subject: consensus_peers: capture weak refs in functors submitted to thread pools .

[kudu-CR] consensus: switch RaftConsensus to shared ptr

2017-07-31 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: consensus: switch RaftConsensus to shared_ptr .. consensus: switch RaftConsensus to shared_ptr Using shared_ptr instead of scoped_refptr means we can creat

[kudu-CR] Expose running maintenance op info

2017-07-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Expose running maintenance op info .. Patch Set 2: (10 comments) http://gerrit.cloudera.org:8080/#/c/7537/2/src/kudu/tserver/tserver-path-handlers.h File src/kudu

[kudu-CR] disk failure: error-handling macros in blocks

2017-07-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: disk failure: error-handling macros in blocks .. Patch Set 21: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7030 To unsubscribe, visit http://gerri

[kudu-CR] disk failure: error-handling macros in blocks

2017-07-31 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: disk failure: error-handling macros in blocks .. disk failure: error-handling macros in blocks This patch adds macros to trigger error-handling code in the

[kudu-CR] disk failure: error-handling macros in blocks

2017-07-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: disk failure: error-handling macros in blocks .. Patch Set 21: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7030 To unsubscribe, visit http://ge

[kudu-CR] Add metrics for tablet state and tablet copy

2017-07-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add metrics for tablet state and tablet copy .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/7540/1//COMMIT_MSG Commit Message: PS1, Line 9: This

[kudu-CR] disk failure: reassign failed tablets

2017-07-31 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7440 to look at the new patch set (#7). Change subject: disk failure: reassign failed tablets .. disk failure: reassign

[kudu-CR] disk failure: error-handling macros in blocks

2017-07-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: error-handling macros in blocks .. Patch Set 21: Code-Review+1 Seems like another java client deadlock. -- To view, visit http://gerrit.cloudera.or

[kudu-CR] log block manager: mark container as read-only after syncing error

2017-07-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: mark container as read-only after syncing error .. Patch Set 19: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7374 To unsubs

[kudu-CR] log block manager: mark container as read-only after syncing error

2017-07-31 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7374 to look at the new patch set (#19). Change subject: log block manager: mark container as read-only after syncing error

[kudu-CR] disk failure: coordinate error handling

2017-07-31 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: disk failure: coordinate error handling .. disk failure: coordinate error handling IO errors are spawned when calls to env functions fail. The response to

[kudu-CR] disk failure: coordinate error handling

2017-07-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: disk failure: coordinate error handling .. Patch Set 26: Code-Review+2 Verified+1 Overriding Jenkins, I agree with Andrew that the failure looks unrelated to this

[kudu-CR] disk failure: error-handling macros in blocks

2017-07-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: disk failure: error-handling macros in blocks .. Patch Set 20: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7030 To unsubscribe, visit http://ge

[kudu-CR] log block manager: mark container as read-only after syncing error

2017-07-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: mark container as read-only after syncing error .. Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/7374/18/src/kudu/fs/block_mana

[kudu-CR] Add metrics for tablet state and tablet copy

2017-07-31 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7540 Change subject: Add metrics for tablet state and tablet copy .. Add metrics for tablet state and tablet copy This patch adds a metric to

[kudu-CR] disk failure: reassign failed tablets

2017-07-31 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7440 to look at the new patch set (#6). Change subject: disk failure: reassign failed tablets .. disk failure: reassign

[kudu-CR] [tools] Address potential flakiness of TestMoveTablet

2017-07-31 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7533 to look at the new patch set (#4). Change subject: [tools] Address potential flakiness of TestMoveTablet .. [tools]

[kudu-CR] [tools] Address potential flakiness of TestMoveTablet

2017-07-31 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [tools] Address potential flakiness of TestMoveTablet .. Patch Set 3: (2 comments) > btw can you also loop raft_consensus-itest and tablet_copy-itest a > bit s

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-07-31 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover .. Patch Set 6: (9 comments) http://gerrit.cloudera.org:8080/#/c/7456/5/java/kudu

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-07-31 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7456 to look at the new patch set (#7). Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover ...

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-07-31 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7456 to look at the new patch set (#6). Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover ...

[kudu-CR] disk failure: coordinate error handling

2017-07-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: coordinate error handling .. Patch Set 26: Failure seems unrelated. -- To view, visit http://gerrit.cloudera.org:8080/7029 To unsubscribe, visit ht

[kudu-CR] [tools] Address potential flakiness of TestMoveTablet

2017-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [tools] Address potential flakiness of TestMoveTablet .. Patch Set 3: btw can you also loop raft_consensus-itest and tablet_copy-itest a bit since they seem to be

[kudu-CR] [tools] Address potential flakiness of TestMoveTablet

2017-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [tools] Address potential flakiness of TestMoveTablet .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7533/3//COMMIT_MSG Commit Message: Line 20

[kudu-CR] [tools] Address potential flakiness of TestMoveTablet

2017-07-31 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7533 to look at the new patch set (#3). Change subject: [tools] Address potential flakiness of TestMoveTablet .. [tools]

[kudu-CR] disk failure: coordinate error handling

2017-07-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: coordinate error handling .. Patch Set 26: (1 comment) http://gerrit.cloudera.org:8080/#/c/7029/25/src/kudu/fs/block_manager-stress-test.cc File src

[kudu-CR] disk failure: error-handling macros in blocks

2017-07-31 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7030 to look at the new patch set (#20). Change subject: disk failure: error-handling macros in blocks .. di

[kudu-CR] disk failure: coordinate error handling

2017-07-31 Thread Andrew Wong (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7029 to look at the new patch set (#26). Change subject: disk failure: coordinate error handling .. disk fa

[kudu-CR] [tools] Address potential flakiness of TestMoveTablet

2017-07-31 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7533 to look at the new patch set (#2). Change subject: [tools] Address potential flakiness of TestMoveTablet .. [tools]

[kudu-CR] kudu client tools for hadoop and spark import/export(csv,parquet,avro)

2017-07-31 Thread Sandish Kumar HN (Code Review)
Sandish Kumar HN has posted comments on this change. Change subject: kudu client tools for hadoop and spark import/export(csv,parquet,avro) .. Patch Set 3: (31 comments) http://gerrit.cloudera.org:8080/#/c/7421/2/java/kudu-cl

[kudu-CR] kudu client tools for hadoop and spark import/export(csv,parquet,avro)

2017-07-31 Thread Sandish Kumar HN (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7421 to look at the new patch set (#3). Change subject: kudu client tools for hadoop and spark import/export(csv,parquet,avro) .