[kudu-CR] Bump protobuf to 3.4.1

2017-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Bump protobuf to 3.4.1 .. Patch Set 2: Code-Review+2 Looks like 3.4.1 isn't available for Java yet; I only see 3.4.0 artifacts. Could you bug the protobuf team abo

[kudu-CR] docs: clarify steps for changing master from multi-master deployment

2017-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: clarify steps for changing master from multi-master deployment .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8032/3/docs/adm

[kudu-CR] [iwyu] update std::move

2017-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [iwyu] update std::move .. Patch Set 1: (13 comments) Hmm, looks like our cpplint is making incorrect recommendations: Add #include for swap [build/include_wh

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-17 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8089 to review the following change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic ..

[kudu-CR] KUDU-1125: issue one catalog write per tablet report

2017-09-17 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8090 to review the following change. Change subject: KUDU-1125: issue one catalog write per tablet report .

[kudu-CR] KUDU-1807 (part 3): remove GetTableSchema.create table done

2017-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1807 (part 3): remove GetTableSchema.create_table_done .. Patch Set 4: Verified+1 All of the build failures were due to the build hosts running out of disk spa

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-17 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8089 to look at the new patch set (#2). Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. catal

[kudu-CR] master: fix TSAN data race on ToString()

2017-09-17 Thread Adar Dembo (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8092 to review the following change. Change subject: master: fix TSAN data race on ToString() .. master: fix TSAN data race

[kudu-CR] data dirs: fix a LOG statement

2017-09-17 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Andrew Wong (DEPRECATED: please use aw...@cloudera.com), I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8091 to review the following change. Change subject: data_dirs: fix a LOG statement ...

[kudu-CR] data dirs: fix a LOG statement

2017-09-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: data_dirs: fix a LOG statement .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8091 To unsubscribe, visit http://gerrit.cloudera.o

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: Verified+1 Overriding Jenkins, the only failure was an instance of KUDU-1521. -- To view,

[kudu-CR] KUDU-1125: issue one catalog write per tablet report

2017-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1125: issue one catalog write per tablet report .. Patch Set 2: Verified+1 Overriding Jenkins, the only failure was in setting up one of the TSAN tests. -- T