[kudu-CR] KUDU-2167: fix C++ client crash due to bad assumption regarding scan data

2017-10-03 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8204 to review the following change. Change subject: KUDU-2167: fix C++ client crash due to bad assumption regarding scan data ...

[kudu-CR] block compression: fix arg to Substitute

2017-10-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8203 ) Change subject: block_compression: fix arg to Substitute .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] block compression: fix arg to Substitute

2017-10-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8203 ) Change subject: block_compression: fix arg to Substitute .. block_compression: fix arg to Substitute Change-Id: If00035e39ba3f8

[kudu-CR] block compression: fix arg to Substitute

2017-10-03 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8203 Change subject: block_compression: fix arg to Substitute .. block_compression: fix arg to Substitute Change-Id: If00035e39ba3f837f42e398ca6

[kudu-CR](branch-1.4.x) KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-10-03 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8185 ) Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 2: nvm the backport-- I forgot it's tes

[kudu-CR] [webui] Allow custom response codes and headers

2017-10-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8141 ) Change subject: [webui] Allow custom response codes and headers .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/8141/6/s

[kudu-CR] tool: add cluster shell action

2017-10-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 ) Change subject: tool: add cluster shell action .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/t

[kudu-CR] [webui] Allow custom response codes and headers

2017-10-03 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8141 to look at the new patch set (#8). Change subject: [webui] Allow custom response codes and headers ..

[kudu-CR] [webui] Allow custom response codes and headers

2017-10-03 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8141 to look at the new patch set (#7). Change subject: [webui] Allow custom response codes and headers ..

[kudu-CR] [webui] Allow custom response codes and headers

2017-10-03 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8141 ) Change subject: [webui] Allow custom response codes and headers .. Patch Set 6: (9 comments) I let Impala people know about this patch

[kudu-CR](branch-1.4.x) KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-10-03 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8185 ) Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 2: https://issues.apache.org/jira/brows

[kudu-CR](branch-1.4.x) KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-10-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/8185 ) Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 2: > The latest Jenkins failure is

[kudu-CR](branch-1.4.x) KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-10-03 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8185 ) Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 2: Verified+1 The latest Jenkins failur

[kudu-CR](branch-1.4.x) KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-10-03 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/81

[kudu-CR] tool: add cluster shell action

2017-10-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 ) Change subject: tool: add cluster shell action .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/t

[kudu-CR](branch-1.4.x) KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-10-03 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8185 ) Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 2: I'm unable to repro these failures.

[kudu-CR] tool: add cluster shell action

2017-10-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 ) Change subject: tool: add cluster shell action .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/

[kudu-CR] KUDU-1125: issue one catalog write per tablet report

2017-10-03 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8090 ) Change subject: KUDU-1125: issue one catalog write per tablet report .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8090

[kudu-CR] mini-cluster: condition on NO TESTS=0

2017-10-03 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8199 ) Change subject: mini-cluster: condition on NO_TESTS=0 .. mini-cluster: condition on NO_TESTS=0 This module will be incorporated in

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-10-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 15: (3 comments) > Patch Set 15: > > > Patch Set 15: > >

[kudu-CR] mini-cluster: condition on NO TESTS=0

2017-10-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8199 ) Change subject: mini-cluster: condition on NO_TESTS=0 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] mini-cluster: condition on NO TESTS=0

2017-10-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8199 ) Change subject: mini-cluster: condition on NO_TESTS=0 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8199 T

[kudu-CR] mini-cluster: condition on NO TESTS=0

2017-10-03 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8199 to review the following change. Change subject: mini-cluster: condition on NO_TESTS=0 .. mini-cluster:

[kudu-CR] tool: add cluster shell action

2017-10-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 ) Change subject: tool: add cluster shell action .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/too

[kudu-CR] tool: add cluster shell action

2017-10-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 ) Change subject: tool: add cluster shell action .. Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/to

[kudu-CR] tool: add cluster shell action

2017-10-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 ) Change subject: tool: add cluster shell action .. Patch Set 8: (7 comments) http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/

[kudu-CR] tool: add cluster shell action

2017-10-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 ) Change subject: tool: add cluster shell action .. Patch Set 8: (11 comments) http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/C

[kudu-CR] KUDU-1125: issue one catalog write per tablet report

2017-10-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8090 ) Change subject: KUDU-1125: issue one catalog write per tablet report .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/809